Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Return singleton empty collection instead of null in Read service code
[controller.git]
/
opendaylight
/
protocol_plugins
/
openflow
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
protocol_plugin
/
openflow
/
internal
/
FlowStatisticsConverter.java
diff --git
a/opendaylight/protocol_plugins/openflow/src/main/java/org/opendaylight/controller/protocol_plugin/openflow/internal/FlowStatisticsConverter.java
b/opendaylight/protocol_plugins/openflow/src/main/java/org/opendaylight/controller/protocol_plugin/openflow/internal/FlowStatisticsConverter.java
index 6873b528a2631f2d01480387f46be430e58b57c0..74af3db5ef9465e519f36cd5f35e36f196f3f336 100644
(file)
--- a/
opendaylight/protocol_plugins/openflow/src/main/java/org/opendaylight/controller/protocol_plugin/openflow/internal/FlowStatisticsConverter.java
+++ b/
opendaylight/protocol_plugins/openflow/src/main/java/org/opendaylight/controller/protocol_plugin/openflow/internal/FlowStatisticsConverter.java
@@
-9,6
+9,7
@@
package org.opendaylight.controller.protocol_plugin.openflow.internal;
import java.util.ArrayList;
package org.opendaylight.controller.protocol_plugin.openflow.internal;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.List;
import org.opendaylight.controller.protocol_plugin.openflow.vendorextension.v6extension.V6StatsReply;
import java.util.List;
import org.opendaylight.controller.protocol_plugin.openflow.vendorextension.v6extension.V6StatsReply;
@@
-34,11
+35,10
@@
public class FlowStatisticsConverter {
private List<FlowOnNode> flowOnNodeList;
public FlowStatisticsConverter(List<OFStatistics> statsList) {
private List<FlowOnNode> flowOnNodeList;
public FlowStatisticsConverter(List<OFStatistics> statsList) {
- if (statsList == null) {
// || statsList.isEmpty()) {
- this.ofStatsList =
new ArrayList<OFStatistics>(1); // dummy list
+ if (statsList == null) {
+ this.ofStatsList =
Collections.emptyList();
} else {
} else {
- this.ofStatsList = statsList; // new
- // ArrayList<OFStatistics>(statsList);
+ this.ofStatsList = statsList;
}
this.flowOnNodeList = null;
}
}
this.flowOnNodeList = null;
}