Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Six more Equals/HashCode/StringBuilder replacements
[controller.git]
/
opendaylight
/
sal
/
api
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
sal
/
action
/
Action.java
diff --git
a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/action/Action.java
b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/action/Action.java
index 5e4f5f81fa15ef92d044324c667f97c7ddbffccd..d8144d7bb74eaaf7a043ce3cba623b58b53c041b 100644
(file)
--- a/
opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/action/Action.java
+++ b/
opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/action/Action.java
@@
-15,8
+15,6
@@
import javax.xml.bind.annotation.XmlRootElement;
import javax.xml.bind.annotation.XmlSeeAlso;
import javax.xml.bind.annotation.XmlTransient;
import javax.xml.bind.annotation.XmlSeeAlso;
import javax.xml.bind.annotation.XmlTransient;
-import org.apache.commons.lang3.builder.EqualsBuilder;
-import org.apache.commons.lang3.builder.HashCodeBuilder;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@
-122,12
+120,24
@@
public abstract class Action {
@Override
public int hashCode() {
@Override
public int hashCode() {
- return HashCodeBuilder.reflectionHashCode(this);
+ final int prime = 31;
+ int result = 1;
+ result = prime * result + ((type == null) ? 0 : type.hashCode());
+ return result;
}
@Override
public boolean equals(Object obj) {
}
@Override
public boolean equals(Object obj) {
- return EqualsBuilder.reflectionEquals(this, obj);
+ if (this == obj)
+ return true;
+ if (obj == null)
+ return false;
+ if (getClass() != obj.getClass())
+ return false;
+ Action other = (Action) obj;
+ if (type != other.type)
+ return false;
+ return true;
}
@Override
}
@Override