Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
new LinkedList() mostly redundant with Arrays.asList()
[controller.git]
/
opendaylight
/
sal
/
api
/
src
/
test
/
java
/
org
/
opendaylight
/
controller
/
sal
/
core
/
PathTest.java
diff --git
a/opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/PathTest.java
b/opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/PathTest.java
index 9058156b9e05ba607946f0dcb0b2b0dcfea142e6..656dd8ea5bf45b35d65f56e3ff71276967527aa9 100644
(file)
--- a/
opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/PathTest.java
+++ b/
opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/PathTest.java
@@
-63,7
+63,8
@@
public class PathTest {
Edge e2 = new Edge(c2, c3);
Edge e3 = new Edge(c3, c4);
Edge e4 = new Edge(c4, c5);
Edge e2 = new Edge(c2, c3);
Edge e3 = new Edge(c3, c4);
Edge e4 = new Edge(c4, c5);
- edges = new LinkedList(Arrays.asList(e0, e1, e2, e3, e4));
+ // actually need a LinkedList because we're going to .remove()
+ edges = new LinkedList<Edge>(Arrays.asList(e0, e1, e2, e3, e4));
} catch (ConstructionException e) {
// Exception is NOT expected if raised test will fail
Assert.assertTrue(false);
} catch (ConstructionException e) {
// Exception is NOT expected if raised test will fail
Assert.assertTrue(false);
@@
-130,7
+131,7
@@
public class PathTest {
Edge e2 = new Edge(c2, c3);
Edge e3 = new Edge(c3, c4);
Edge e4 = new Edge(c4, c5);
Edge e2 = new Edge(c2, c3);
Edge e3 = new Edge(c3, c4);
Edge e4 = new Edge(c4, c5);
- edges1 =
new LinkedList(Arrays.asList(e0, e1, e2, e3, e4)
);
+ edges1 =
Arrays.asList(e0, e1, e2, e3, e4
);
} catch (ConstructionException e) {
// Exception is NOT expected if raised test will fail
Assert.assertTrue(false);
} catch (ConstructionException e) {
// Exception is NOT expected if raised test will fail
Assert.assertTrue(false);
@@
-168,7
+169,7
@@
public class PathTest {
Edge e2 = new Edge(c2, c3);
Edge e3 = new Edge(c3, c4);
Edge e4 = new Edge(c4, c5);
Edge e2 = new Edge(c2, c3);
Edge e3 = new Edge(c3, c4);
Edge e4 = new Edge(c4, c5);
- edges2 =
new LinkedList(Arrays.asList(e0, e1, e2, e3, e4)
);
+ edges2 =
Arrays.asList(e0, e1, e2, e3, e4
);
} catch (ConstructionException e) {
// Exception is NOT expected if raised test will fail
Assert.assertTrue(false);
} catch (ConstructionException e) {
// Exception is NOT expected if raised test will fail
Assert.assertTrue(false);
@@
-206,7
+207,7
@@
public class PathTest {
Edge e2 = new Edge(c2, c3);
Edge e3 = new Edge(c3, c4);
Edge e4 = new Edge(c4, c5);
Edge e2 = new Edge(c2, c3);
Edge e3 = new Edge(c3, c4);
Edge e4 = new Edge(c4, c5);
- edges3 =
new LinkedList(Arrays.asList(e0, e1, e2, e3, e4)
);
+ edges3 =
Arrays.asList(e0, e1, e2, e3, e4
);
} catch (ConstructionException e) {
// Exception is NOT expected if raised test will fail
Assert.assertTrue(false);
} catch (ConstructionException e) {
// Exception is NOT expected if raised test will fail
Assert.assertTrue(false);
@@
-257,7
+258,7
@@
public class PathTest {
Edge e0 = new Edge(c0, c1);
Edge e0 = new Edge(c0, c1);
- Path path = new Path(
new LinkedList(Arrays.asList(e0)
));
+ Path path = new Path(
Arrays.asList(e0
));
} catch (ConstructionException e) {
// Exception is NOT expected if raised test will fail
Assert.assertTrue(false);
} catch (ConstructionException e) {
// Exception is NOT expected if raised test will fail
Assert.assertTrue(false);
@@
-299,7
+300,7
@@
public class PathTest {
Edge e2 = new Edge(c2, c3);
Edge e3 = new Edge(c3, c4);
Edge e4 = new Edge(c4, c5);
Edge e2 = new Edge(c2, c3);
Edge e3 = new Edge(c3, c4);
Edge e4 = new Edge(c4, c5);
- List<Edge> edges =
new LinkedList(Arrays.asList(e0, e1, e2, e3, e4)
);
+ List<Edge> edges =
Arrays.asList(e0, e1, e2, e3, e4
);
Path path = new Path(edges);
// Test start node
Path path = new Path(edges);
// Test start node
@@
-325,7
+326,7
@@
public class PathTest {
(short) 0x1), n1);
Edge e0 = new Edge(c0, c1);
(short) 0x1), n1);
Edge e0 = new Edge(c0, c1);
- List<Edge> edges =
new LinkedList(Arrays.asList(e0)
);
+ List<Edge> edges =
Arrays.asList(e0
);
Path path = new Path(edges);
// Test start node
Path path = new Path(edges);
// Test start node