Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
- Application is no longer blocked when programming hundreds of flows. The Barrier...
[controller.git]
/
opendaylight
/
sal
/
implementation
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
sal
/
implementation
/
internal
/
ReadService.java
diff --git
a/opendaylight/sal/implementation/src/main/java/org/opendaylight/controller/sal/implementation/internal/ReadService.java
b/opendaylight/sal/implementation/src/main/java/org/opendaylight/controller/sal/implementation/internal/ReadService.java
index da725f010cffedc7646edb82f2d5087a947252ae..0ee48d5b880b8efd4039e98d0d8c217aaf095a96 100644
(file)
--- a/
opendaylight/sal/implementation/src/main/java/org/opendaylight/controller/sal/implementation/internal/ReadService.java
+++ b/
opendaylight/sal/implementation/src/main/java/org/opendaylight/controller/sal/implementation/internal/ReadService.java
@@
-328,9
+328,9
@@
public class ReadService implements IReadService, CommandProvider {
try {
node = new Node(NodeIDType.OPENFLOW, Long.valueOf(nodeId));
} catch (NumberFormatException e) {
try {
node = new Node(NodeIDType.OPENFLOW, Long.valueOf(nodeId));
} catch (NumberFormatException e) {
-
e.printStackTrace(
);
+
logger.error("",e
);
} catch (ConstructionException e) {
} catch (ConstructionException e) {
-
e.printStackTrace(
);
+
logger.error("",e
);
}
List<FlowOnNode> list = (cached) ? this.readAllFlows(node) : this
.nonCachedReadAllFlows(node);
}
List<FlowOnNode> list = (cached) ? this.readAllFlows(node) : this
.nonCachedReadAllFlows(node);
@@
-355,9
+355,9
@@
public class ReadService implements IReadService, CommandProvider {
try {
node = new Node(NodeIDType.OPENFLOW, Long.valueOf(nodeId));
} catch (NumberFormatException e) {
try {
node = new Node(NodeIDType.OPENFLOW, Long.valueOf(nodeId));
} catch (NumberFormatException e) {
-
e.printStackTrace(
);
+
logger.error("",e
);
} catch (ConstructionException e) {
} catch (ConstructionException e) {
-
e.printStackTrace(
);
+
logger.error("",e
);
}
Flow flow = getSampleFlow(node);
FlowOnNode flowOnNode = (cached) ? this.readFlow(node, flow) : this
}
Flow flow = getSampleFlow(node);
FlowOnNode flowOnNode = (cached) ? this.readFlow(node, flow) : this
@@
-382,9
+382,9
@@
public class ReadService implements IReadService, CommandProvider {
try {
node = new Node(NodeIDType.OPENFLOW, Long.valueOf(nodeId));
} catch (NumberFormatException e) {
try {
node = new Node(NodeIDType.OPENFLOW, Long.valueOf(nodeId));
} catch (NumberFormatException e) {
-
e.printStackTrace(
);
+
logger.error("",e
);
} catch (ConstructionException e) {
} catch (ConstructionException e) {
-
e.printStackTrace(
);
+
logger.error("",e
);
}
List<NodeConnectorStatistics> list = (cached) ? this
.readNodeConnectors(node) : this
}
List<NodeConnectorStatistics> list = (cached) ? this
.readNodeConnectors(node) : this
@@
-438,9
+438,9
@@
public class ReadService implements IReadService, CommandProvider {
try {
node = new Node(NodeIDType.OPENFLOW, Long.valueOf(nodeId));
} catch (NumberFormatException e) {
try {
node = new Node(NodeIDType.OPENFLOW, Long.valueOf(nodeId));
} catch (NumberFormatException e) {
-
e.printStackTrace(
);
+
logger.error("",e
);
} catch (ConstructionException e) {
} catch (ConstructionException e) {
-
e.printStackTrace(
);
+
logger.error("",e
);
}
NodeDescription desc = (cached) ? this.readDescription(node) : this
.nonCachedReadDescription(node);
}
NodeDescription desc = (cached) ? this.readDescription(node) : this
.nonCachedReadDescription(node);