import java.io.ObjectOutput;
import java.util.ArrayList;
import java.util.List;
-import java.util.Optional;
import org.opendaylight.controller.cluster.access.concepts.AbstractSuccessProxy;
import org.opendaylight.controller.cluster.access.concepts.ClientIdentifier;
private List<ActorSelection> alternates;
private ActorRef backend;
- private long maxMessages;
+ private int maxMessages;
+ // checkstyle flags the public modifier as redundant however it is explicitly needed for Java serialization to
+ // be able to create instances via reflection.
+ @SuppressWarnings("checkstyle:RedundantModifier")
public ConnectClientSuccessProxyV1() {
// For Externalizable
}
super(success);
this.alternates = success.getAlternates();
this.backend = success.getBackend();
+ this.maxMessages = success.getMaxMessages();
// We are ignoring the DataTree, it is not serializable anyway
}
public void writeExternal(final ObjectOutput out) throws IOException {
super.writeExternal(out);
- out.writeUTF(Serialization.serializedActorPath(backend));
+ out.writeObject(Serialization.serializedActorPath(backend));
+ out.writeInt(maxMessages);
out.writeInt(alternates.size());
for (ActorSelection b : alternates) {
out.writeObject(b.toSerializationFormat());
}
-
- out.writeLong(maxMessages);
}
@Override
public void readExternal(final ObjectInput in) throws IOException, ClassNotFoundException {
super.readExternal(in);
- backend = JavaSerializer.currentSystem().value().provider().resolveActorRef(in.readUTF());
-
- final int backendsSize = in.readInt();
- if (backendsSize < 1) {
- throw new IOException("Illegal number of backends " + backendsSize);
- }
+ backend = JavaSerializer.currentSystem().value().provider().resolveActorRef((String) in.readObject());
+ maxMessages = in.readInt();
- alternates = new ArrayList<>(backendsSize);
- for (int i = 0; i < backendsSize; ++i) {
+ final int alternatesSize = in.readInt();
+ alternates = new ArrayList<>(alternatesSize);
+ for (int i = 0; i < alternatesSize; ++i) {
alternates.add(ActorSelection.apply(ActorRef.noSender(), (String)in.readObject()));
}
-
- maxMessages = in.readLong();
}
@Override
- protected ConnectClientSuccess createSuccess(final ClientIdentifier target) {
- return new ConnectClientSuccess(target, backend, alternates, Optional.empty(), maxMessages);
+ protected ConnectClientSuccess createSuccess(final ClientIdentifier target, final long sequence) {
+ return new ConnectClientSuccess(target, sequence, backend, alternates, maxMessages, null);
}
@Override