Switch ABIVersion.current() to CHLORINE_SR2

[controller.git] / opendaylight / md-sal / cds-access-api / src / main / java / org / opendaylight / controller / cluster / access / commands / ReadTransactionSuccess.java

diff --git a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccess.java b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccess.java
index 77bd430fc539721f03dbd7fce471f264fb3621e7..b65473aa381516f7fafc3d53af00113ea239d161 100644 (file)
--- a/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccess.java
+++ b/opendaylight/md-sal/cds-access-api/src/main/java/org/opendaylight/controller/cluster/access/commands/ReadTransactionSuccess.java
@@ -7,43 +7,82 @@
  */
 package org.opendaylight.controller.cluster.access.commands;
 
-import com.google.common.annotations.Beta;
-import com.google.common.base.Optional;
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import java.io.IOException;
+import java.io.ObjectInput;
+import java.io.ObjectOutput;
+import java.util.Optional;
 import org.opendaylight.controller.cluster.access.ABIVersion;
 import org.opendaylight.controller.cluster.access.concepts.SliceableMessage;
 import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
 import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
+import org.opendaylight.yangtools.yang.data.codec.binfmt.NormalizedNodeDataInput;
 
 /**
  * Successful reply to an {@link ReadTransactionRequest}. It indicates presence of requested data via
  * {@link #getData()}.
- *
- * @author Robert Varga
  */
-@Beta
 public final class ReadTransactionSuccess extends TransactionSuccess<ReadTransactionSuccess>
         implements SliceableMessage {
+    interface SerialForm extends TransactionSuccess.SerialForm<ReadTransactionSuccess> {
+        @Override
+        default ReadTransactionSuccess readExternal(final ObjectInput in, final TransactionIdentifier target,
+                final long sequence) throws IOException {
+            final Optional<NormalizedNode> data;
+            if (in.readBoolean()) {
+                data = Optional.of(NormalizedNodeDataInput.newDataInput(in).readNormalizedNode());
+            } else {
+                data = Optional.empty();
+            }
+            return new ReadTransactionSuccess(target, sequence, data);
+        }
+
+        @Override
+        default void writeExternal(final ObjectOutput out, final ReadTransactionSuccess msg) throws IOException {
+            TransactionSuccess.SerialForm.super.writeExternal(out, msg);
+
+            final var data = msg.getData();
+            if (data.isPresent()) {
+                out.writeBoolean(true);
+                try (var nnout = msg.getVersion().getStreamVersion().newDataOutput(out)) {
+                    nnout.writeNormalizedNode(data.orElseThrow());
+                }
+            } else {
+                out.writeBoolean(false);
+            }
+        }
+    }
+
+    @java.io.Serial
     private static final long serialVersionUID = 1L;
-    private final Optional<NormalizedNode<?, ?>> data;
+
+    @SuppressFBWarnings(value = "SE_BAD_FIELD", justification = "interface-based best effort")
+    private final Optional<NormalizedNode> data;
+
+    private ReadTransactionSuccess(final ReadTransactionSuccess request, final ABIVersion version) {
+        super(request, version);
+        data = request.data;
+    }
 
     public ReadTransactionSuccess(final TransactionIdentifier identifier, final long sequence,
-            final Optional<NormalizedNode<?, ?>> data) {
+            final Optional<NormalizedNode> data) {
         super(identifier, sequence);
-        this.data = Preconditions.checkNotNull(data);
+        this.data = requireNonNull(data);
     }
 
-    public Optional<NormalizedNode<?, ?>> getData() {
+    public Optional<NormalizedNode> getData() {
         return data;
     }
 
     @Override
-    protected AbstractTransactionSuccessProxy<ReadTransactionSuccess> externalizableProxy(final ABIVersion version) {
-        return new ReadTransactionSuccessProxyV1(this);
+    protected SerialForm externalizableProxy(final ABIVersion version) {
+        return ABIVersion.MAGNESIUM.lt(version) ? new RTS(this) : new ReadTransactionSuccessProxyV1(this);
     }
 
     @Override
     protected ReadTransactionSuccess cloneAsVersion(final ABIVersion version) {
-        return this;
+        return new ReadTransactionSuccess(this, version);
     }
 }