*/
package org.opendaylight.controller.cluster.raft;
+import static org.junit.Assert.assertTrue;
+
import akka.actor.Actor;
import akka.actor.ActorIdentity;
import akka.actor.ActorRef;
import akka.util.Timeout;
import com.google.common.base.Stopwatch;
import com.google.common.util.concurrent.Uninterruptibles;
-import java.util.LinkedList;
+import java.time.Duration;
+import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.TimeUnit;
-import org.junit.Assert;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import scala.concurrent.Await;
private static final Logger LOG = LoggerFactory.getLogger(TestActorFactory.class);
private final ActorSystem system;
- List<ActorRef> createdActors = new LinkedList<>();
+ private final List<ActorRef> createdActors = new ArrayList<>();
private static int actorCount = 1;
- public TestActorFactory(ActorSystem system) {
+ public TestActorFactory(final ActorSystem system) {
this.system = system;
}
* @param props the actor Props
* @return the ActorRef
*/
- public ActorRef createActor(Props props) {
+ public ActorRef createActor(final Props props) {
ActorRef actorRef = system.actorOf(props);
return addActor(actorRef, true);
}
* @param actorId name of actor
* @return the ActorRef
*/
- public ActorRef createActor(Props props, String actorId) {
+ public ActorRef createActor(final Props props, final String actorId) {
ActorRef actorRef = system.actorOf(props, actorId);
return addActor(actorRef, true);
}
* @param actorId name of actor
* @return the ActorRef
*/
- public ActorRef createActorNoVerify(Props props, String actorId) {
+ public ActorRef createActorNoVerify(final Props props, final String actorId) {
ActorRef actorRef = system.actorOf(props, actorId);
return addActor(actorRef, false);
}
* @return the ActorRef
*/
@SuppressWarnings("unchecked")
- public <T extends Actor> TestActorRef<T> createTestActor(Props props, String actorId) {
+ public <T extends Actor> TestActorRef<T> createTestActor(final Props props, final String actorId) {
InvalidActorNameException lastError = null;
for (int i = 0; i < 10; i++) {
try {
* @return the TestActorRef
*/
@SuppressWarnings("unchecked")
- public <T extends Actor> TestActorRef<T> createTestActor(Props props) {
+ public <T extends Actor> TestActorRef<T> createTestActor(final Props props) {
TestActorRef<T> actorRef = TestActorRef.create(system, props);
return (TestActorRef<T>) addActor(actorRef, true);
}
- private <T extends ActorRef> ActorRef addActor(T actorRef, boolean verify) {
+ private <T extends ActorRef> ActorRef addActor(final T actorRef, final boolean verify) {
createdActors.add(actorRef);
if (verify) {
verifyActorReady(actorRef);
}
@SuppressWarnings("checkstyle:IllegalCatch")
- private void verifyActorReady(ActorRef actorRef) {
+ private void verifyActorReady(final ActorRef actorRef) {
// Sometimes we see messages go to dead letters soon after creation - it seems the actor isn't quite
// in a state yet to receive messages or isn't actually created yet. This seems to happen with
// actorSelection so, to alleviate it, we use an actorSelection and send an Identify message with
ActorSelection actorSelection = system.actorSelection(actorRef.path().toString());
Future<Object> future = Patterns.ask(actorSelection, new Identify(""), timeout);
ActorIdentity reply = (ActorIdentity)Await.result(future, timeout.duration());
- Assert.assertTrue("Identify returned non-present", reply.getActorRef().isPresent());
+ assertTrue("Identify returned non-present", reply.getActorRef().isPresent());
return;
} catch (Exception | AssertionError e) {
Uninterruptibles.sleepUninterruptibly(100, TimeUnit.MILLISECONDS);
* @param prefix the name prefix
* @return the actor name
*/
- public String generateActorId(String prefix) {
+ public String generateActorId(final String prefix) {
return prefix + actorCount++;
}
- public void killActor(ActorRef actor, TestKit kit) {
+ public void killActor(final ActorRef actor, final TestKit kit) {
killActor(actor, kit, true);
}
- private void killActor(ActorRef actor, TestKit kit, boolean remove) {
+ private void killActor(final ActorRef actor, final TestKit kit, final boolean remove) {
LOG.info("Killing actor {}", actor);
kit.watch(actor);
actor.tell(PoisonPill.getInstance(), ActorRef.noSender());
- kit.expectTerminated(kit.duration("5 seconds"), actor);
+ kit.expectTerminated(Duration.ofSeconds(5), actor);
if (remove) {
createdActors.remove(actor);
}
}
- public String createTestActorPath(String actorId) {
+ public String createTestActorPath(final String actorId) {
return "akka://test/user/" + actorId;
}