package org.opendaylight.controller.cluster.raft.messages;
import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertSame;
-import java.util.Arrays;
-import java.util.Collections;
+import static org.junit.Assert.assertFalse;
+
import java.util.Iterator;
-import org.apache.commons.lang.SerializationUtils;
-import org.junit.Assert;
+import java.util.List;
+import org.apache.commons.lang3.SerializationUtils;
import org.junit.Test;
import org.opendaylight.controller.cluster.raft.MockRaftActorContext.MockPayload;
import org.opendaylight.controller.cluster.raft.RaftVersions;
import org.opendaylight.controller.cluster.raft.ReplicatedLogEntry;
-import org.opendaylight.controller.cluster.raft.ReplicatedLogImplEntry;
-import org.opendaylight.controller.protobuff.messages.cluster.raft.AppendEntriesMessages;
+import org.opendaylight.controller.cluster.raft.persisted.SimpleReplicatedLogEntry;
/**
* Unit tests for AppendEntries.
* @author Thomas Pantelis
*/
public class AppendEntriesTest {
-
@Test
public void testSerialization() {
- ReplicatedLogEntry entry1 = new ReplicatedLogImplEntry(1, 2, new MockPayload("payload1"));
+ ReplicatedLogEntry entry1 = new SimpleReplicatedLogEntry(1, 2, new MockPayload("payload1"));
- ReplicatedLogEntry entry2 = new ReplicatedLogImplEntry(3, 4, new MockPayload("payload2"));
+ ReplicatedLogEntry entry2 = new SimpleReplicatedLogEntry(3, 4, new MockPayload("payload2"));
short payloadVersion = 5;
- AppendEntries expected = new AppendEntries(5L, "node1", 7L, 8L, Arrays.asList(entry1, entry2), 10L,
- -1, payloadVersion);
- AppendEntries cloned = (AppendEntries) SerializationUtils.clone(expected);
+ // Without leader address
- verifyAppendEntries(expected, cloned);
- }
+ var expected = new AppendEntries(5L, "node1", 7L, 8L, List.of(entry1, entry2), 10L, -1, payloadVersion,
+ RaftVersions.CURRENT_VERSION, null);
- @Test
- public void testToAndFromSerializable() {
- AppendEntries entries = new AppendEntries(5L, "node1", 7L, 8L,
- Collections.<ReplicatedLogEntry>emptyList(), 10L, -1, (short)0);
+ var bytes = SerializationUtils.serialize(expected);
+ assertEquals(285, bytes.length);
+ var cloned = (AppendEntries) SerializationUtils.deserialize(bytes);
+
+ verifyAppendEntries(expected, cloned, RaftVersions.CURRENT_VERSION);
+
+ // With leader address
+
+ expected = new AppendEntries(5L, "node1", 7L, 8L, List.of(entry1, entry2), 10L, -1, payloadVersion,
+ RaftVersions.CURRENT_VERSION, "leader address");
- assertSame("toSerializable", entries, entries.toSerializable());
- assertSame("fromSerializable", entries,
- org.opendaylight.controller.cluster.raft.SerializationUtils.fromSerializable(entries));
+ bytes = SerializationUtils.serialize(expected);
+ assertEquals(301, bytes.length);
+ cloned = (AppendEntries) SerializationUtils.deserialize(bytes);
+
+ verifyAppendEntries(expected, cloned, RaftVersions.CURRENT_VERSION);
}
@Test
- public void testToAndFromLegacySerializable() {
- ReplicatedLogEntry entry = new ReplicatedLogImplEntry(3, 4, new MockPayload("payload"));
- AppendEntries entries = new AppendEntries(5L, "node1", 7L, 8L, Arrays.asList(entry), 10L, -1, (short)0);
+ @Deprecated
+ public void testPreFluorineSerialization() {
+ ReplicatedLogEntry entry1 = new SimpleReplicatedLogEntry(1, 2, new MockPayload("payload1"));
+
+ ReplicatedLogEntry entry2 = new SimpleReplicatedLogEntry(3, 4, new MockPayload("payload2"));
+
+ short payloadVersion = 5;
- Object serializable = entries.toSerializable(RaftVersions.HELIUM_VERSION);
- Assert.assertTrue(serializable instanceof AppendEntriesMessages.AppendEntries);
+ final var expected = new AppendEntries(5L, "node1", 7L, 8L, List.of(entry1, entry2), 10L, -1,
+ payloadVersion, RaftVersions.BORON_VERSION, "leader address");
- AppendEntries entries2 = (AppendEntries)
- org.opendaylight.controller.cluster.raft.SerializationUtils.fromSerializable(serializable);
+ final var bytes = SerializationUtils.serialize(expected);
+ assertEquals(350, bytes.length);
+ final var cloned = (AppendEntries) SerializationUtils.deserialize(bytes);
- verifyAppendEntries(entries, entries2);
+ verifyAppendEntries(expected, cloned, RaftVersions.BORON_VERSION);
}
- private static void verifyAppendEntries(AppendEntries expected, AppendEntries actual) {
+ private static void verifyAppendEntries(final AppendEntries expected, final AppendEntries actual,
+ final short recipientRaftVersion) {
assertEquals("getLeaderId", expected.getLeaderId(), actual.getLeaderId());
assertEquals("getTerm", expected.getTerm(), actual.getTerm());
assertEquals("getLeaderCommit", expected.getLeaderCommit(), actual.getLeaderCommit());
assertEquals("getEntries size", expected.getEntries().size(), actual.getEntries().size());
Iterator<ReplicatedLogEntry> iter = expected.getEntries().iterator();
- for(ReplicatedLogEntry e: actual.getEntries()) {
+ for (ReplicatedLogEntry e: actual.getEntries()) {
verifyReplicatedLogEntry(iter.next(), e);
}
+
+ if (recipientRaftVersion > RaftVersions.BORON_VERSION) {
+ assertEquals("getLeaderAddress", expected.getLeaderAddress(), actual.getLeaderAddress());
+ assertEquals("getLeaderRaftVersion", RaftVersions.CURRENT_VERSION, actual.getLeaderRaftVersion());
+ } else {
+ assertFalse(actual.getLeaderAddress().isPresent());
+ assertEquals("getLeaderRaftVersion", RaftVersions.BORON_VERSION, actual.getLeaderRaftVersion());
+ }
}
- private static void verifyReplicatedLogEntry(ReplicatedLogEntry expected, ReplicatedLogEntry actual) {
+ private static void verifyReplicatedLogEntry(final ReplicatedLogEntry expected, final ReplicatedLogEntry actual) {
assertEquals("getIndex", expected.getIndex(), actual.getIndex());
assertEquals("getTerm", expected.getTerm(), actual.getTerm());
assertEquals("getData", expected.getData().toString(), actual.getData().toString());