*/
package org.opendaylight.controller.cluster.datastore.entityownership;
+import static java.util.Objects.requireNonNull;
import static org.opendaylight.controller.cluster.datastore.entityownership.EntityOwnersModel.CANDIDATE_NODE_ID;
import static org.opendaylight.controller.cluster.datastore.entityownership.EntityOwnersModel.ENTITY_OWNER_NODE_ID;
import static org.opendaylight.controller.cluster.datastore.entityownership.EntityOwnersModel.entityPath;
import akka.pattern.Patterns;
import akka.util.Timeout;
import com.google.common.annotations.VisibleForTesting;
-import com.google.common.base.Optional;
-import com.google.common.base.Preconditions;
import com.google.common.base.Strings;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import java.util.Collection;
+import java.util.Optional;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.TimeUnit;
-import javax.annotation.Nonnull;
import org.opendaylight.controller.cluster.access.concepts.MemberName;
import org.opendaylight.controller.cluster.datastore.config.Configuration;
import org.opendaylight.controller.cluster.datastore.config.ModuleShardConfiguration;
import org.opendaylight.controller.cluster.datastore.messages.CreateShard;
import org.opendaylight.controller.cluster.datastore.messages.GetShardDataTree;
import org.opendaylight.controller.cluster.datastore.shardstrategy.ModuleShardStrategy;
-import org.opendaylight.controller.cluster.datastore.utils.ActorContext;
+import org.opendaylight.controller.cluster.datastore.utils.ActorUtils;
import org.opendaylight.mdsal.eos.common.api.CandidateAlreadyRegisteredException;
import org.opendaylight.mdsal.eos.common.api.EntityOwnershipState;
import org.opendaylight.mdsal.eos.dom.api.DOMEntity;
private static final Timeout MESSAGE_TIMEOUT = new Timeout(1, TimeUnit.MINUTES);
private final ConcurrentMap<DOMEntity, DOMEntity> registeredEntities = new ConcurrentHashMap<>();
- private final ActorContext context;
+ private final ActorUtils context;
private volatile ActorRef localEntityOwnershipShard;
private volatile DataTree localEntityOwnershipShardDataTree;
- private DistributedEntityOwnershipService(final ActorContext context) {
- this.context = Preconditions.checkNotNull(context);
+ DistributedEntityOwnershipService(final ActorUtils context) {
+ this.context = requireNonNull(context);
}
- public static DistributedEntityOwnershipService start(final ActorContext context,
+ public static DistributedEntityOwnershipService start(final ActorUtils context,
final EntityOwnerSelectionStrategyConfig strategyConfig) {
ActorRef shardManagerActor = context.getShardManager();
"entity-owners", ENTITY_OWNERSHIP_SHARD_NAME, ModuleShardStrategy.NAME, entityOwnersMemberNames),
newShardBuilder(context, strategyConfig), null);
- Future<Object> createFuture = context.executeOperationAsync(shardManagerActor,
- createShard, MESSAGE_TIMEOUT);
-
+ Future<Object> createFuture = context.executeOperationAsync(shardManagerActor, createShard, MESSAGE_TIMEOUT);
createFuture.onComplete(new OnComplete<Object>() {
@Override
public void onComplete(final Throwable failure, final Object response) {
@Override
public void onComplete(final Throwable failure, final Object response) {
if (failure != null) {
- LOG.debug("Error sending message {} to {}", message, shardActor, failure);
+ // FIXME: CONTROLLER-1904: reduce the severity to info once we have a retry mechanism
+ LOG.error("Error sending message {} to {}", message, shardActor, failure);
} else {
- LOG.debug("{} message to {} succeeded", message, shardActor, failure);
+ LOG.debug("{} message to {} succeeded", message, shardActor);
}
}
}, context.getClientDispatcher());
@Override
public void onComplete(final Throwable failure, final ActorRef shardActor) {
if (failure != null) {
+ // FIXME: CONTROLLER-1904: reduce the severity to info once we have a retry mechanism
LOG.error("Failed to find local {} shard", ENTITY_OWNERSHIP_SHARD_NAME, failure);
} else {
localEntityOwnershipShard = shardActor;
@Override
public DOMEntityOwnershipCandidateRegistration registerCandidate(final DOMEntity entity)
throws CandidateAlreadyRegisteredException {
- Preconditions.checkNotNull(entity, "entity cannot be null");
+ requireNonNull(entity, "entity cannot be null");
if (registeredEntities.putIfAbsent(entity, entity) != null) {
throw new CandidateAlreadyRegisteredException(entity);
@Override
public DOMEntityOwnershipListenerRegistration registerListener(final String entityType,
final DOMEntityOwnershipListener listener) {
- Preconditions.checkNotNull(entityType, "entityType cannot be null");
- Preconditions.checkNotNull(listener, "listener cannot be null");
-
RegisterListenerLocal registerListener = new RegisterListenerLocal(listener, entityType);
LOG.debug("Registering listener with message: {}", registerListener);
@Override
public Optional<EntityOwnershipState> getOwnershipState(final DOMEntity forEntity) {
- Preconditions.checkNotNull(forEntity, "forEntity cannot be null");
+ requireNonNull(forEntity, "forEntity cannot be null");
DataTree dataTree = getLocalEntityOwnershipShardDataTree();
if (dataTree == null) {
- return Optional.absent();
+ return Optional.empty();
}
Optional<NormalizedNode<?, ?>> entityNode = dataTree.takeSnapshot().readNode(
entityPath(forEntity.getType(), forEntity.getIdentifier()));
if (!entityNode.isPresent()) {
- return Optional.absent();
+ return Optional.empty();
}
// Check if there are any candidates, if there are none we do not really have ownership state
final boolean hasCandidates = optionalCandidates.isPresent()
&& ((MapNode) optionalCandidates.get()).getValue().size() > 0;
if (!hasCandidates) {
- return Optional.absent();
+ return Optional.empty();
}
MemberName localMemberName = context.getCurrentMemberName();
}
@Override
- public boolean isCandidateRegistered(@Nonnull final DOMEntity entity) {
+ public boolean isCandidateRegistered(final DOMEntity entity) {
return registeredEntities.get(entity) != null;
}
@VisibleForTesting
@SuppressWarnings("checkstyle:IllegalCatch")
+ @SuppressFBWarnings(value = "REC_CATCH_EXCEPTION", justification = "Akka's Await.result() API contract")
DataTree getLocalEntityOwnershipShardDataTree() {
if (localEntityOwnershipShardDataTree == null) {
try {
public void close() {
}
- private static EntityOwnershipShard.Builder newShardBuilder(final ActorContext context,
+ private static EntityOwnershipShard.Builder newShardBuilder(final ActorUtils context,
final EntityOwnerSelectionStrategyConfig strategyConfig) {
return EntityOwnershipShard.newBuilder().localMemberName(context.getCurrentMemberName())
.ownerSelectionStrategyConfig(strategyConfig);