package org.opendaylight.controller.cluster.datastore.entityownership.selectionstrategy;
import com.google.common.base.Preconditions;
-import java.io.IOException;
-import java.util.Dictionary;
-import java.util.Enumeration;
-import javax.annotation.Nullable;
-import org.osgi.framework.BundleContext;
-import org.osgi.framework.ServiceReference;
-import org.osgi.service.cm.Configuration;
-import org.osgi.service.cm.ConfigurationAdmin;
+import java.util.Map;
+import java.util.Map.Entry;
+import org.opendaylight.controller.cluster.datastore.entityownership.selectionstrategy.EntityOwnerSelectionStrategyConfig.Builder;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class EntityOwnerSelectionStrategyConfigReader {
- public static final String CONFIG_ID = "org.opendaylight.controller.cluster.entity-owner-selection-strategies";
+/**
+ * Reads the entity owner selection strategy config.
+ *
+ */
+public final class EntityOwnerSelectionStrategyConfigReader {
private static final Logger LOG = LoggerFactory.getLogger(EntityOwnerSelectionStrategyConfigReader.class);
- private final BundleContext bundleContext;
- private final EntityOwnerSelectionStrategyConfig config;
-
- public EntityOwnerSelectionStrategyConfigReader(BundleContext bundleContext) {
- this.bundleContext = Preconditions.checkNotNull(bundleContext);
- ServiceReference<ConfigurationAdmin> configAdminServiceReference =
- bundleContext.getServiceReference(ConfigurationAdmin.class);
- if(configAdminServiceReference == null) {
- LOG.warn("No ConfigurationAdmin service found");
- this.config = EntityOwnerSelectionStrategyConfig.newBuilder().build();
+ private static final String ENTITY_TYPE_PREFIX = "entity.type.";
+
+ private EntityOwnerSelectionStrategyConfigReader() {
+ // Hidden on purpose
+ }
+
+ @SuppressWarnings("checkstyle:IllegalCatch")
+ public static EntityOwnerSelectionStrategyConfig loadStrategyWithConfig(final Map<Object, Object> props) {
+ final EntityOwnerSelectionStrategyConfig.Builder builder = EntityOwnerSelectionStrategyConfig.newBuilder();
+
+ if (props != null && !props.isEmpty()) {
+ parseConfiguration(builder, props);
} else {
- this.config = readConfiguration(configAdminServiceReference);
+ if (props == null) {
+ LOG.debug("Could not read strategy configuration file, will use default configuration.");
+ } else {
+ LOG.debug("Configuration file is empty, will use default configuration.");
+ }
}
+ return builder.build();
}
- private EntityOwnerSelectionStrategyConfig readConfiguration(ServiceReference<ConfigurationAdmin> configAdminServiceReference) {
- EntityOwnerSelectionStrategyConfig.Builder builder = EntityOwnerSelectionStrategyConfig.newBuilder();
- ConfigurationAdmin configAdmin = null;
- try {
- configAdmin = bundleContext.getService(configAdminServiceReference);
- Dictionary<String, Object> properties = getProperties(configAdmin);
- if(properties != null) {
- Enumeration<String> keys = properties.keys();
- while (keys.hasMoreElements()) {
- String key = keys.nextElement();
- String strategyProps = (String) properties.get(key);
- String[] strategyClassAndDelay = strategyProps.split(",");
- if(strategyClassAndDelay.length >= 1) {
- @SuppressWarnings("unchecked")
- Class<? extends EntityOwnerSelectionStrategy> aClass
- = (Class<? extends EntityOwnerSelectionStrategy>) getClass().getClassLoader().loadClass(strategyClassAndDelay[0]);
- long delay = 0;
- if(strategyClassAndDelay.length > 1){
- delay = Long.parseLong(strategyClassAndDelay[1]);
- }
- builder.addStrategy(key, aClass, delay);
- }
- }
+ private static EntityOwnerSelectionStrategyConfig parseConfiguration(final Builder builder,
+ final Map<Object, Object> properties) {
+
+ for (final Entry<Object, Object> entry : properties.entrySet()) {
+ final String key = (String) entry.getKey();
+ if (!key.startsWith(ENTITY_TYPE_PREFIX)) {
+ LOG.debug("Ignoring non-conforming property key : {}", key);
+ continue;
}
- } catch(Exception e){
- LOG.warn("Failed to read selection strategy configuration file. All configuration will be ignored.", e);
- } finally {
- if(configAdmin != null) {
- try {
- bundleContext.ungetService(configAdminServiceReference);
- } catch (Exception e) {
- LOG.debug("Error from ungetService", e);
- }
+
+ final String[] strategyClassAndDelay = ((String) properties.get(key)).split(",");
+ final Class<? extends EntityOwnerSelectionStrategy> aClass = loadClass(strategyClassAndDelay[0]);
+
+ final long delay;
+ if (strategyClassAndDelay.length > 1) {
+ delay = Long.parseLong(strategyClassAndDelay[1]);
+ } else {
+ delay = 0;
}
+
+ final String entityType = key.substring(key.lastIndexOf(".") + 1);
+ builder.addStrategy(entityType, aClass, delay);
+ LOG.debug("Entity Type '{}' using strategy {} delay {}", entityType, aClass, delay);
}
return builder.build();
}
- @Nullable
- private static Dictionary<String, Object> getProperties(ConfigurationAdmin configAdmin) throws IOException {
- Configuration config = configAdmin.getConfiguration(CONFIG_ID);
- return config != null ? config.getProperties() : null;
- }
+ @SuppressWarnings("unchecked")
+ private static Class<? extends EntityOwnerSelectionStrategy> loadClass(final String strategyClassAndDelay) {
+ final Class<?> clazz;
+ try {
+ clazz = EntityOwnerSelectionStrategyConfigReader.class.getClassLoader().loadClass(strategyClassAndDelay);
+ } catch (final ClassNotFoundException e) {
+ throw new IllegalArgumentException("Failed to load strategy " + strategyClassAndDelay, e);
+ }
+
+ Preconditions.checkArgument(EntityOwnerSelectionStrategy.class.isAssignableFrom(clazz),
+ "Selected implementation %s must implement EntityOwnerSelectionStrategy, clazz");
- public EntityOwnerSelectionStrategyConfig getConfig() {
- return config;
+ return (Class<? extends EntityOwnerSelectionStrategy>) clazz;
}
}
Code Review / controller.git / blobdiff