Fix checkstyle reported by odlparent-3.0.0

[controller.git] / opendaylight / md-sal / sal-distributed-datastore / src / main / java / org / opendaylight / controller / cluster / sharding / DistributedShardChangePublisher.java

diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardChangePublisher.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardChangePublisher.java
index 0eef92ad145cb1d3c8497dc972c695f7f3ee1645..f91dc3b2600dd09a5ed815b4d7a24f391d527404 100644 (file)
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardChangePublisher.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/sharding/DistributedShardChangePublisher.java
@@ -57,9 +57,6 @@ public class DistributedShardChangePublisher
     private final AbstractDataStore distributedDataStore;
     private final YangInstanceIdentifier shardPath;
 
-    // This will be useful for signaling back pressure
-    private final DataStoreClient client;
-
     private final Map<DOMDataTreeIdentifier, ChildShardContext> childShards;
 
     @GuardedBy("this")
@@ -69,7 +66,6 @@ public class DistributedShardChangePublisher
                                            final AbstractDataStore distributedDataStore,
                                            final DOMDataTreeIdentifier prefix,
                                            final Map<DOMDataTreeIdentifier, ChildShardContext> childShards) {
-        this.client = client;
         this.distributedDataStore = distributedDataStore;
         // TODO keeping the whole dataTree thats contained in subshards doesn't seem like a good idea
         // maybe the whole listener logic would be better in the backend shards where we have direct access to the
@@ -182,7 +178,7 @@ public class DistributedShardChangePublisher
         return listenerPathArgs;
     }
 
-    private static class ProxyRegistration implements ListenerRegistration<DOMDataTreeChangeListener> {
+    private static final class ProxyRegistration implements ListenerRegistration<DOMDataTreeChangeListener> {
 
         private final ListenerRegistration<org.opendaylight.controller.md.sal.dom.api.DOMDataTreeChangeListener> proxy;
         private final DOMDataTreeChangeListener listener;
@@ -306,7 +302,7 @@ public class DistributedShardChangePublisher
                 // data tree yet. Postpone processing of these changes till we
                 // receive changes from current shard.
                 LOG.debug("Validation for modification built from subshard {} changes {} failed, current data tree {}.",
-                        pathFromRoot, changes, dataTree);
+                        pathFromRoot, changes, dataTree, e);
                 stashedDataTreeCandidates.addAll(newCandidates);
             }
         }
@@ -353,6 +349,7 @@ public class DistributedShardChangePublisher
 
         @Nullable
         @Override
+        @SuppressWarnings("checkstyle:hiddenField")
         public DataTreeCandidateNode getModifiedChild(final PathArgument identifier) {
             return null;
         }