package org.opendaylight.controller.cluster.datastore;
import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
-import static org.mockito.Mockito.when;
import akka.actor.ActorRef;
import akka.actor.ActorSystem;
import akka.actor.AddressFromURIString;
import com.google.common.base.Optional;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
-import com.google.common.collect.Sets;
import com.google.common.util.concurrent.Uninterruptibles;
import com.typesafe.config.ConfigFactory;
-import java.net.URI;
import java.util.Arrays;
-import java.util.Collection;
-import java.util.HashSet;
import java.util.List;
import java.util.Map;
-import java.util.Set;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import org.junit.After;
import org.junit.Test;
import org.mockito.Mock;
import org.mockito.MockitoAnnotations;
-import org.opendaylight.controller.cluster.DataPersistenceProvider;
import org.opendaylight.controller.cluster.datastore.exceptions.NoShardLeaderException;
import org.opendaylight.controller.cluster.datastore.exceptions.NotInitializedException;
import org.opendaylight.controller.cluster.datastore.exceptions.PrimaryNotFoundException;
import org.opendaylight.controller.cluster.datastore.messages.LocalPrimaryShardFound;
import org.opendaylight.controller.cluster.datastore.messages.LocalShardFound;
import org.opendaylight.controller.cluster.datastore.messages.LocalShardNotFound;
+import org.opendaylight.controller.cluster.datastore.messages.PrimaryShardInfo;
import org.opendaylight.controller.cluster.datastore.messages.RemotePrimaryShardFound;
import org.opendaylight.controller.cluster.datastore.messages.ShardLeaderStateChanged;
import org.opendaylight.controller.cluster.datastore.messages.UpdateSchemaContext;
import org.opendaylight.controller.cluster.raft.utils.InMemoryJournal;
import org.opendaylight.controller.md.cluster.datastore.model.TestModel;
import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTree;
-import org.opendaylight.yangtools.yang.model.api.ModuleIdentifier;
import org.opendaylight.yangtools.yang.model.api.SchemaContext;
import scala.concurrent.Await;
import scala.concurrent.Future;
shardManager.tell(new ActorInitialized(), mockShardActor);
DataTree mockDataTree = mock(DataTree.class);
- shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, Optional.of(mockDataTree)), getRef());
+ shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, Optional.of(mockDataTree),
+ DataStoreVersions.CURRENT_VERSION), getRef());
MessageCollectorActor.expectFirstMatching(mockShardActor, RegisterRoleChangeListener.class);
shardManager.tell((new RoleChangeNotification(memberId, RaftState.Candidate.name(),
String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
shardManager.tell(new RoleChangeNotification(memberId1,
RaftState.Candidate.name(), RaftState.Follower.name()), mockShardActor);
- shardManager.tell(new LeaderStateChanged(memberId1, memberId2), mockShardActor);
+ shardManager.tell(new LeaderStateChanged(memberId1, memberId2, DataStoreVersions.CURRENT_VERSION), mockShardActor);
shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), getRef());
String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
shardManager.tell(new RoleChangeNotification(memberId1,
RaftState.Candidate.name(), RaftState.Follower.name()), mockShardActor);
- shardManager.tell(new ShardLeaderStateChanged(memberId1, memberId2, Optional.<DataTree>absent()), mockShardActor);
+ shardManager.tell(new ShardLeaderStateChanged(memberId1, memberId2, Optional.<DataTree>absent(),
+ DataStoreVersions.CURRENT_VERSION), mockShardActor);
shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), getRef());
expectMsgClass(duration("5 seconds"), NoShardLeaderException.class);
DataTree mockDataTree = mock(DataTree.class);
- shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, Optional.of(mockDataTree)), mockShardActor);
+ shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, Optional.of(mockDataTree),
+ DataStoreVersions.CURRENT_VERSION), mockShardActor);
shardManager.tell(new FindPrimary(Shard.DEFAULT_NAME, false), getRef());
expectNoMsg(FiniteDuration.create(150, TimeUnit.MILLISECONDS));
DataTree mockDataTree = mock(DataTree.class);
- shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, Optional.of(mockDataTree)), mockShardActor);
+ shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, Optional.of(mockDataTree),
+ DataStoreVersions.CURRENT_VERSION), mockShardActor);
LocalPrimaryShardFound primaryFound = expectMsgClass(duration("5 seconds"), LocalPrimaryShardFound.class);
assertTrue("Unexpected primary path " + primaryFound.getPrimaryPath(),
String memberId2 = "member-2-shard-astronauts-" + shardMrgIDSuffix;
shardManager2.tell(new ShardLeaderStateChanged(memberId2, memberId2,
- Optional.of(mock(DataTree.class))), mockShardActor2);
+ Optional.of(mock(DataTree.class)), DataStoreVersions.CURRENT_VERSION), mockShardActor2);
shardManager2.tell(new RoleChangeNotification(memberId2,
RaftState.Candidate.name(), RaftState.Leader.name()), mockShardActor2);
String memberId2 = "member-2-shard-default-" + shardMrgIDSuffix;
String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
shardManager1.tell(new ShardLeaderStateChanged(memberId1, memberId2,
- Optional.of(mock(DataTree.class))), mockShardActor1);
+ Optional.of(mock(DataTree.class)), DataStoreVersions.CURRENT_VERSION), mockShardActor1);
shardManager1.tell(new RoleChangeNotification(memberId1,
RaftState.Candidate.name(), RaftState.Follower.name()), mockShardActor1);
- shardManager2.tell(new ShardLeaderStateChanged(memberId2, memberId2, Optional.of(mock(DataTree.class))),
+ shardManager2.tell(new ShardLeaderStateChanged(memberId2, memberId2, Optional.of(mock(DataTree.class)),
+ DataStoreVersions.CURRENT_VERSION),
mockShardActor2);
shardManager2.tell(new RoleChangeNotification(memberId2,
RaftState.Candidate.name(), RaftState.Leader.name()), mockShardActor2);
String memberId2 = "member-2-shard-default-" + shardMrgIDSuffix;
String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
shardManager1.tell(new ShardLeaderStateChanged(memberId1, memberId2,
- Optional.of(mock(DataTree.class))), mockShardActor1);
+ Optional.of(mock(DataTree.class)), DataStoreVersions.CURRENT_VERSION), mockShardActor1);
shardManager1.tell(new RoleChangeNotification(memberId1,
RaftState.Candidate.name(), RaftState.Follower.name()), mockShardActor1);
- shardManager2.tell(new ShardLeaderStateChanged(memberId2, memberId2, Optional.of(mock(DataTree.class))),
+ shardManager2.tell(new ShardLeaderStateChanged(memberId2, memberId2, Optional.of(mock(DataTree.class)),
+ DataStoreVersions.CURRENT_VERSION),
mockShardActor2);
shardManager2.tell(new RoleChangeNotification(memberId2,
RaftState.Candidate.name(), RaftState.Leader.name()), mockShardActor2);
String path = found.getPrimaryPath();
assertTrue("Unexpected primary path " + path, path.contains("member-2-shard-default-config"));
+ primaryShardInfoCache.putSuccessful("default", new PrimaryShardInfo(system1.actorSelection(
+ mockShardActor1.path()), Optional.<DataTree>absent()));
+
shardManager1.underlyingActor().onReceiveCommand(MockClusterWrapper.
createUnreachableMember("member-2", "akka.tcp://cluster-test@127.0.0.1:2558"));
expectMsgClass(duration("5 seconds"), NoShardLeaderException.class);
- shardManager1.tell(new ShardLeaderStateChanged(memberId1, memberId1, Optional.of(mock(DataTree.class))),
- mockShardActor1);
+ assertNull("Expected primaryShardInfoCache entry removed", primaryShardInfoCache.getIfPresent("default"));
+
+ shardManager1.tell(new ShardLeaderStateChanged(memberId1, memberId1, Optional.of(mock(DataTree.class)),
+ DataStoreVersions.CURRENT_VERSION), mockShardActor1);
shardManager1.tell(new RoleChangeNotification(memberId1,
RaftState.Follower.name(), RaftState.Leader.name()), mockShardActor1);
// Journal entries up to the last one should've been deleted
Map<Long, Object> journal = InMemoryJournal.get(shardMgrID);
synchronized (journal) {
- assertEquals("Journal size", 1, journal.size());
- assertEquals("Journal entry seq #", Long.valueOf(2), journal.keySet().iterator().next());
+ assertEquals("Journal size", 0, journal.size());
}
}};
}
- @Test
- public void testOnRecoveryPreviouslyKnownModulesAreDiscovered() throws Exception {
- final ImmutableSet<String> persistedModules = ImmutableSet.of("foo", "bar");
- InMemoryJournal.addEntry(shardMgrID, 1L, new ShardManager.SchemaContextModules(
- persistedModules));
- new JavaTestKit(getSystem()) {{
- TestActorRef<TestShardManager> shardManager = TestActorRef.create(getSystem(),
- Props.create(new TestShardManagerCreator(shardMrgIDSuffix)));
-
- shardManager.underlyingActor().waitForRecoveryComplete();
-
- Collection<String> knownModules = shardManager.underlyingActor().getKnownModules();
-
- assertEquals("getKnownModules", persistedModules, Sets.newHashSet(knownModules));
- }};
- }
-
- @Test
- public void testOnUpdateSchemaContextUpdateKnownModulesIfTheyContainASuperSetOfTheKnownModules()
- throws Exception {
- new JavaTestKit(getSystem()) {{
- final TestActorRef<ShardManager> shardManager =
- TestActorRef.create(getSystem(), newShardMgrProps(true));
-
- assertEquals("getKnownModules size", 0, shardManager.underlyingActor().getKnownModules().size());
-
- ModuleIdentifier foo = mock(ModuleIdentifier.class);
- when(foo.getNamespace()).thenReturn(new URI("foo"));
-
- Set<ModuleIdentifier> moduleIdentifierSet = new HashSet<>();
- moduleIdentifierSet.add(foo);
-
- SchemaContext schemaContext = mock(SchemaContext.class);
- when(schemaContext.getAllModuleIdentifiers()).thenReturn(moduleIdentifierSet);
-
- shardManager.underlyingActor().onReceiveCommand(new UpdateSchemaContext(schemaContext));
-
- assertEquals("getKnownModules", Sets.newHashSet("foo"),
- Sets.newHashSet(shardManager.underlyingActor().getKnownModules()));
-
- ModuleIdentifier bar = mock(ModuleIdentifier.class);
- when(bar.getNamespace()).thenReturn(new URI("bar"));
-
- moduleIdentifierSet.add(bar);
-
- shardManager.underlyingActor().onReceiveCommand(new UpdateSchemaContext(schemaContext));
-
- assertEquals("getKnownModules", Sets.newHashSet("foo", "bar"),
- Sets.newHashSet(shardManager.underlyingActor().getKnownModules()));
- }};
- }
-
- @Test
- public void testOnUpdateSchemaContextDoNotUpdateKnownModulesIfTheyDoNotContainASuperSetOfKnownModules()
- throws Exception {
- new JavaTestKit(getSystem()) {{
- final TestActorRef<ShardManager> shardManager =
- TestActorRef.create(getSystem(), newShardMgrProps(true));
-
- SchemaContext schemaContext = mock(SchemaContext.class);
- Set<ModuleIdentifier> moduleIdentifierSet = new HashSet<>();
-
- ModuleIdentifier foo = mock(ModuleIdentifier.class);
- when(foo.getNamespace()).thenReturn(new URI("foo"));
-
- moduleIdentifierSet.add(foo);
-
- when(schemaContext.getAllModuleIdentifiers()).thenReturn(moduleIdentifierSet);
-
- shardManager.underlyingActor().onReceiveCommand(new UpdateSchemaContext(schemaContext));
-
- assertEquals("getKnownModules", Sets.newHashSet("foo"),
- Sets.newHashSet(shardManager.underlyingActor().getKnownModules()));
-
- //Create a completely different SchemaContext with only the bar module in it
- //schemaContext = mock(SchemaContext.class);
- moduleIdentifierSet.clear();
- ModuleIdentifier bar = mock(ModuleIdentifier.class);
- when(bar.getNamespace()).thenReturn(new URI("bar"));
-
- moduleIdentifierSet.add(bar);
-
- shardManager.underlyingActor().onReceiveCommand(new UpdateSchemaContext(schemaContext));
-
- assertEquals("getKnownModules", Sets.newHashSet("foo"),
- Sets.newHashSet(shardManager.underlyingActor().getKnownModules()));
-
- }};
- }
-
- @Test
- public void testRecoveryApplicable(){
- new JavaTestKit(getSystem()) {
- {
- final Props persistentProps = newShardMgrProps(true);
- final TestActorRef<ShardManager> persistentShardManager =
- TestActorRef.create(getSystem(), persistentProps);
-
- DataPersistenceProvider dataPersistenceProvider1 = persistentShardManager.underlyingActor().getDataPersistenceProvider();
-
- assertTrue("Recovery Applicable", dataPersistenceProvider1.isRecoveryApplicable());
-
- final Props nonPersistentProps = newShardMgrProps(false);
- final TestActorRef<ShardManager> nonPersistentShardManager =
- TestActorRef.create(getSystem(), nonPersistentProps);
-
- DataPersistenceProvider dataPersistenceProvider2 = nonPersistentShardManager.underlyingActor().getDataPersistenceProvider();
-
- assertFalse("Recovery Not Applicable", dataPersistenceProvider2.isRecoveryApplicable());
-
-
- }};
-
- }
-
- @Test
- public void testOnUpdateSchemaContextUpdateKnownModulesCallsDataPersistenceProvider()
- throws Exception {
- final CountDownLatch persistLatch = new CountDownLatch(1);
- final Creator<ShardManager> creator = new Creator<ShardManager>() {
- private static final long serialVersionUID = 1L;
- @Override
- public ShardManager create() throws Exception {
- return new ShardManager(new MockClusterWrapper(), new MockConfiguration(), DatastoreContext.newBuilder().build(),
- ready, new PrimaryShardInfoFutureCache()) {
- @Override
- protected DataPersistenceProvider createDataPersistenceProvider(boolean persistent) {
- DataPersistenceProviderMonitor dataPersistenceProviderMonitor
- = new DataPersistenceProviderMonitor();
- dataPersistenceProviderMonitor.setPersistLatch(persistLatch);
- return dataPersistenceProviderMonitor;
- }
- };
- }
- };
-
- new JavaTestKit(getSystem()) {{
-
- final TestActorRef<ShardManager> shardManager =
- TestActorRef.create(getSystem(), Props.create(new DelegatingShardManagerCreator(creator)));
-
- ModuleIdentifier foo = mock(ModuleIdentifier.class);
- when(foo.getNamespace()).thenReturn(new URI("foo"));
-
- Set<ModuleIdentifier> moduleIdentifierSet = new HashSet<>();
- moduleIdentifierSet.add(foo);
-
- SchemaContext schemaContext = mock(SchemaContext.class);
- when(schemaContext.getAllModuleIdentifiers()).thenReturn(moduleIdentifierSet);
-
- shardManager.underlyingActor().onReceiveCommand(new UpdateSchemaContext(schemaContext));
-
- assertEquals("Persisted", true,
- Uninterruptibles.awaitUninterruptibly(persistLatch, 5, TimeUnit.SECONDS));
-
- }};
- }
-
@Test
public void testRoleChangeNotificationAndShardLeaderStateChangedReleaseReady() throws Exception {
new JavaTestKit(getSystem()) {
verify(ready, never()).countDown();
shardManager.underlyingActor().onReceiveCommand(new ShardLeaderStateChanged(memberId, memberId,
- Optional.of(mock(DataTree.class))));
+ Optional.of(mock(DataTree.class)), DataStoreVersions.CURRENT_VERSION));
verify(ready, times(1)).countDown();
shardManager.underlyingActor().onReceiveCommand(MockClusterWrapper.createMemberUp("member-2", getRef().path().toString()));
shardManager.underlyingActor().onReceiveCommand(new ShardLeaderStateChanged(memberId,
- "member-2-shard-default-" + shardMrgIDSuffix, Optional.of(mock(DataTree.class))));
+ "member-2-shard-default-" + shardMrgIDSuffix, Optional.of(mock(DataTree.class)),
+ DataStoreVersions.CURRENT_VERSION));
verify(ready, times(1)).countDown();
verify(ready, never()).countDown();
shardManager.underlyingActor().onReceiveCommand(new ShardLeaderStateChanged(memberId,
- "member-2-shard-default-" + shardMrgIDSuffix, Optional.of(mock(DataTree.class))));
+ "member-2-shard-default-" + shardMrgIDSuffix, Optional.of(mock(DataTree.class)),
+ DataStoreVersions.CURRENT_VERSION));
shardManager.underlyingActor().onReceiveCommand(MockClusterWrapper.createMemberUp("member-2", getRef().path().toString()));
Code Review / controller.git / blobdiff