package org.opendaylight.controller.cluster.datastore.entityownership;
import static org.junit.Assert.assertEquals;
+import static org.mockito.Matchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.reset;
import static org.mockito.Mockito.timeout;
import static org.mockito.Mockito.verify;
+
+import akka.actor.ActorContext;
import akka.actor.ActorRef;
import akka.actor.Props;
-import akka.actor.UntypedActorContext;
-import akka.testkit.JavaTestKit;
import akka.testkit.TestActorRef;
+import akka.testkit.javadsl.TestKit;
import com.google.common.util.concurrent.Uninterruptibles;
+import java.util.ArrayList;
+import java.util.List;
import java.util.concurrent.TimeUnit;
import org.junit.After;
+import org.junit.Before;
import org.junit.Test;
-import org.opendaylight.controller.cluster.datastore.AbstractActorTest;
import org.opendaylight.controller.cluster.raft.TestActorFactory;
import org.opendaylight.controller.cluster.raft.utils.DoNothingActor;
-import org.opendaylight.controller.md.sal.common.api.clustering.Entity;
-import org.opendaylight.controller.md.sal.common.api.clustering.EntityOwnershipListener;
+import org.opendaylight.mdsal.eos.dom.api.DOMEntity;
+import org.opendaylight.mdsal.eos.dom.api.DOMEntityOwnershipChange;
+import org.opendaylight.mdsal.eos.dom.api.DOMEntityOwnershipListener;
import org.opendaylight.yangtools.yang.common.QName;
import org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier;
import scala.collection.Iterator;
*
* @author Thomas Pantelis
*/
-public class EntityOwnershipListenerSupportTest extends AbstractActorTest {
+public class EntityOwnershipListenerSupportTest extends AbstractEntityOwnershipTest {
private final TestActorFactory actorFactory = new TestActorFactory(getSystem());
+ private ActorContext actorContext;
+
+ @Before
+ public void setup() {
+ TestActorRef<DoNothingActor> actor = actorFactory.createTestActor(
+ Props.create(DoNothingActor.class), actorFactory.generateActorId("test"));
+
+ actorContext = actor.underlyingActor().getContext();
+ }
@After
public void tearDown() {
@Test
public void testNotifyEntityOwnershipListeners() {
- TestActorRef<DoNothingActor> actor = actorFactory.createTestActor(
- Props.create(DoNothingActor.class), actorFactory.generateActorId("test"));
-
- UntypedActorContext actorContext = actor.underlyingActor().getContext();
- EntityOwnershipListenerSupport support = new EntityOwnershipListenerSupport(actorContext);
-
- EntityOwnershipListener mockListener1 = mock(EntityOwnershipListener.class, "EntityOwnershipListener1");
- EntityOwnershipListener mockListener2 = mock(EntityOwnershipListener.class, "EntityOwnershipListener2");
- Entity entity1 = new Entity("test", YangInstanceIdentifier.of(QName.create("test", "id1")));
- Entity entity2 = new Entity("test", YangInstanceIdentifier.of(QName.create("test", "id2")));
+ EntityOwnershipListenerSupport support = new EntityOwnershipListenerSupport(actorContext, "test");
+
+ DOMEntityOwnershipListener mockListener1 = mock(DOMEntityOwnershipListener.class, "EntityOwnershipListener1");
+ DOMEntityOwnershipListener mockListener2 = mock(DOMEntityOwnershipListener.class, "EntityOwnershipListener2");
+ DOMEntityOwnershipListener mockListener12 = mock(DOMEntityOwnershipListener.class,
+ "EntityOwnershipListener1_2");
+ String entityType1 = "type1";
+ String entityType2 = "type2";
+ final DOMEntity entity1 = new DOMEntity(entityType1, YangInstanceIdentifier.of(QName.create("test", "id1")));
+ final DOMEntity entity2 = new DOMEntity(entityType2, YangInstanceIdentifier.of(QName.create("test", "id2")));
+ final DOMEntity entity3 = new DOMEntity("noListener", YangInstanceIdentifier.of(QName.create("test", "id5")));
// Add EntityOwnershipListener registrations.
- support.addEntityOwnershipListener(entity1, mockListener1);
- support.addEntityOwnershipListener(entity2, mockListener1);
- support.addEntityOwnershipListener(entity1, mockListener2);
+ support.addEntityOwnershipListener(entityType1, mockListener1);
+ support.addEntityOwnershipListener(entityType1, mockListener1); // register again - should be noop
+ support.addEntityOwnershipListener(entityType1, mockListener12);
+ support.addEntityOwnershipListener(entityType2, mockListener2);
- // Notify entity1 changed and verify both listeners are notified.
+ // Notify entity1 changed and verify appropriate listeners are notified.
- support.notifyEntityOwnershipListeners(entity1, false, true);
+ support.notifyEntityOwnershipListeners(entity1, false, true, true);
- verify(mockListener1, timeout(5000)).ownershipChanged(entity1, false, true);
- verify(mockListener2, timeout(5000)).ownershipChanged(entity1, false, true);
+ verify(mockListener1, timeout(5000)).ownershipChanged(ownershipChange(entity1, false, true, true));
+ verify(mockListener12, timeout(5000)).ownershipChanged(ownershipChange(entity1, false, true, true));
+ Uninterruptibles.sleepUninterruptibly(300, TimeUnit.MILLISECONDS);
+ verify(mockListener2, never()).ownershipChanged(any(DOMEntityOwnershipChange.class));
assertEquals("# of listener actors", 2, actorContext.children().size());
+ reset(mockListener1, mockListener2, mockListener12);
- // Notify entity2 changed and verify only mockListener1 is notified.
+ // Notify entity2 changed and verify appropriate listeners are notified.
- support.notifyEntityOwnershipListeners(entity2, false, true);
+ support.notifyEntityOwnershipListeners(entity2, false, true, true);
- verify(mockListener1, timeout(5000)).ownershipChanged(entity2, false, true);
- verify(mockListener2, never()).ownershipChanged(entity2, false, true);
- assertEquals("# of listener actors", 2, actorContext.children().size());
-
- // Notify entity3 changed and verify neither listener is notified.
+ verify(mockListener2, timeout(5000)).ownershipChanged(ownershipChange(entity2, false, true, true));
+ Uninterruptibles.sleepUninterruptibly(300, TimeUnit.MILLISECONDS);
+ verify(mockListener1, never()).ownershipChanged(any(DOMEntityOwnershipChange.class));
+ verify(mockListener12, never()).ownershipChanged(any(DOMEntityOwnershipChange.class));
+ assertEquals("# of listener actors", 3, actorContext.children().size());
+ reset(mockListener1, mockListener2, mockListener12);
- Entity entity3 = new Entity("test", YangInstanceIdentifier.of(QName.create("test", "id3")));
- support.notifyEntityOwnershipListeners(entity3, false, true);
+ // Notify entity3 changed and verify no listeners are notified.
- Uninterruptibles.sleepUninterruptibly(500, TimeUnit.MILLISECONDS);
+ support.notifyEntityOwnershipListeners(entity3, true, false, true);
- verify(mockListener1, never()).ownershipChanged(entity3, false, true);
- verify(mockListener2, never()).ownershipChanged(entity3, false, true);
+ Uninterruptibles.sleepUninterruptibly(300, TimeUnit.MILLISECONDS);
+ verify(mockListener1, never()).ownershipChanged(any(DOMEntityOwnershipChange.class));
+ verify(mockListener2, never()).ownershipChanged(any(DOMEntityOwnershipChange.class));
+ verify(mockListener12, never()).ownershipChanged(any(DOMEntityOwnershipChange.class));
+ reset(mockListener1, mockListener2, mockListener12);
- reset(mockListener1, mockListener2);
+ Iterable<ActorRef> listenerActors = actorContext.children();
+ assertEquals("# of listener actors", 3, listenerActors.size());
- // Unregister mockListener1 for entity1, issue a change and verify only mockListener2 is notified.
+ // Unregister mockListener1, issue a change for entity1 and verify only remaining listeners are notified.
- support.removeEntityOwnershipListener(entity1, mockListener1);
+ support.removeEntityOwnershipListener(entityType1, mockListener1);
+ support.notifyEntityOwnershipListeners(entity1, true, false, true);
- support.notifyEntityOwnershipListeners(entity1, false, true);
+ verify(mockListener12, timeout(5000)).ownershipChanged(ownershipChange(entity1, true, false, true));
+ Uninterruptibles.sleepUninterruptibly(300, TimeUnit.MILLISECONDS);
+ verify(mockListener1, never()).ownershipChanged(any(DOMEntityOwnershipChange.class));
+ reset(mockListener1, mockListener2, mockListener12);
- verify(mockListener2, timeout(5000)).ownershipChanged(entity1, false, true);
- verify(mockListener1, never()).ownershipChanged(entity1, false, true);
+ // Unregister all listeners and verify their listener actors are destroyed.
- // Completely unregister both listeners and verify their listener actors are destroyed.
+ List<TestKit> watchers = new ArrayList<>();
+ for (Iterator<ActorRef> iter = listenerActors.iterator(); iter.hasNext();) {
+ TestKit kit = new TestKit(getSystem());
+ kit.watch(iter.next());
+ watchers.add(kit);
+ }
- Iterable<ActorRef> listenerActors = actorContext.children();
- assertEquals("# of listener actors", 2, listenerActors.size());
+ support.removeEntityOwnershipListener(entityType1, mockListener12);
+ support.removeEntityOwnershipListener(entityType1, mockListener12); // un-register again - should be noop
+ support.removeEntityOwnershipListener(entityType2, mockListener2);
Iterator<ActorRef> iter = listenerActors.iterator();
- ActorRef listenerActor1 = iter.next();
- ActorRef listenerActor2 = iter.next();
+ for (TestKit kit: watchers) {
+ kit.expectTerminated(kit.duration("3 seconds"), iter.next());
+ }
- JavaTestKit kit1 = new JavaTestKit(getSystem());
- kit1.watch(listenerActor1);
-
- JavaTestKit kit2 = new JavaTestKit(getSystem());
- kit2.watch(listenerActor2);
-
- support.removeEntityOwnershipListener(entity2, mockListener1);
- support.removeEntityOwnershipListener(entity1, mockListener2);
-
- kit1.expectTerminated(JavaTestKit.duration("3 seconds"), listenerActor1);
- kit2.expectTerminated(JavaTestKit.duration("3 seconds"), listenerActor2);
assertEquals("# of listener actors", 0, actorContext.children().size());
- // Re-register mockListener1 for entity1 and verify it is notified.
+ // Re-register mockListener1 and verify it is notified.
reset(mockListener1, mockListener2);
- support.addEntityOwnershipListener(entity1, mockListener1);
-
- support.notifyEntityOwnershipListeners(entity1, false, true);
+ support.addEntityOwnershipListener(entityType1, mockListener1);
+ support.notifyEntityOwnershipListeners(entity1, false, false, true);
- verify(mockListener1, timeout(5000)).ownershipChanged(entity1, false, true);
- verify(mockListener2, never()).ownershipChanged(entity2, false, true);
+ verify(mockListener1, timeout(5000)).ownershipChanged(ownershipChange(entity1, false, false, true));
+ verify(mockListener12, never()).ownershipChanged(any(DOMEntityOwnershipChange.class));
+ verify(mockListener2, never()).ownershipChanged(any(DOMEntityOwnershipChange.class));
// Quickly register and unregister mockListener2 - expecting no exceptions.
- support.addEntityOwnershipListener(entity1, mockListener2);
- support.removeEntityOwnershipListener(entity1, mockListener2);
+ support.addEntityOwnershipListener(entityType1, mockListener2);
+ support.removeEntityOwnershipListener(entityType1, mockListener2);
}
}
Code Review / controller.git / blobdiff