import com.google.common.base.Optional;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Lists;
-import com.google.common.collect.Maps;
import com.google.common.util.concurrent.CheckedFuture;
import com.google.common.util.concurrent.FluentFuture;
import com.google.common.util.concurrent.FutureCallback;
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.MoreExecutors;
import com.google.common.util.concurrent.SettableFuture;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import java.util.EnumMap;
+import java.util.LinkedList;
import java.util.Map;
import java.util.Queue;
-import javax.annotation.concurrent.NotThreadSafe;
import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType;
import org.opendaylight.controller.md.sal.common.api.data.ReadFailedException;
import org.opendaylight.controller.md.sal.dom.api.DOMDataReadOnlyTransaction;
* subtree in conceptual data tree. We define this subtree by first write
* operation performed on transaction. All next read and write operations
* should be performed just in this initial subtree.
+ *
*/
// FIXME explicitly enforce just one subtree requirement
-@NotThreadSafe
+@Deprecated
class ShardedDOMDataBrokerDelegatingReadWriteTransaction implements DOMDataReadWriteTransaction {
private final DOMDataReadOnlyTransaction readTxDelegate;
private final DOMDataWriteTransaction writeTxDelegate;
this.readTxDelegate = requireNonNull(readTxDelegate);
this.writeTxDelegate = requireNonNull(writeTxDelegate);
this.txIdentifier = requireNonNull(readWriteTxId);
- this.initialReadMap = Maps.newEnumMap(LogicalDatastoreType.class);
+ this.initialReadMap = new EnumMap<>(LogicalDatastoreType.class);
final InMemoryDataTreeFactory treeFactory = new InMemoryDataTreeFactory();
final ImmutableMap.Builder<LogicalDatastoreType, DataTreeSnapshot> snapshotMapBuilder = ImmutableMap.builder();
tree.setSchemaContext(ctx);
snapshotMapBuilder.put(store, tree.takeSnapshot());
- modificationHistoryMapBuilder.put(store, Lists.newLinkedList());
+ modificationHistoryMapBuilder.put(store, new LinkedList<>());
}
modificationHistoryMap = modificationHistoryMapBuilder.build();
: DataTreeConfiguration.DEFAULT_OPERATIONAL;
}
+ @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD",
+ justification = "https://github.com/spotbugs/spotbugs/issues/811")
private static void applyModificationHistoryToSnapshot(final DataTreeModification dataTreeModification,
- final Queue<Modification> modificationHistory) {
+ final Queue<Modification> modificationHistory) {
while (!modificationHistory.isEmpty()) {
final Modification modification = modificationHistory.poll();
switch (modification.getOperation()) {