package org.opendaylight.controller.netconf.confignetconfconnector.osgi;
+import java.lang.management.ManagementFactory;
+import javax.management.MBeanServer;
import org.opendaylight.controller.config.util.ConfigRegistryJMXClient;
import org.opendaylight.controller.netconf.mapping.api.NetconfOperationServiceFactory;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import javax.management.MBeanServer;
-import java.lang.management.ManagementFactory;
-
public class NetconfOperationServiceFactoryImpl implements NetconfOperationServiceFactory {
public static final int ATTEMPT_TIMEOUT_MS = 1000;
private final YangStoreService yangStoreService;
private final ConfigRegistryJMXClient jmxClient;
- private static final Logger logger = LoggerFactory.getLogger(NetconfOperationServiceFactoryImpl.class);
+ private static final Logger LOG = LoggerFactory.getLogger(NetconfOperationServiceFactoryImpl.class);
public NetconfOperationServiceFactoryImpl(YangStoreService yangStoreService) {
this(yangStoreService, ManagementFactory.getPlatformMBeanServer());
} catch (IllegalStateException e) {
++i;
if (i > SILENT_ATTEMPTS) {
- logger.info("JMX client not created after {} attempts, still trying", i, e);
+ LOG.info("JMX client not created after {} attempts, still trying", i, e);
} else {
- logger.debug("JMX client could not be created, reattempting, try {}", i, e);
+ LOG.debug("JMX client could not be created, reattempting, try {}", i, e);
}
try {
Thread.sleep(ATTEMPT_TIMEOUT_MS);
} catch (InterruptedException e1) {
Thread.currentThread().interrupt();
- throw new RuntimeException("Interrupted while reattempting connection", e1);
+ throw new IllegalStateException("Interrupted while reattempting connection", e1);
}
}
}
jmxClient = configRegistryJMXClient;
if (i > SILENT_ATTEMPTS) {
- logger.info("Created JMX client after {} attempts", i);
+ LOG.info("Created JMX client after {} attempts", i);
} else {
- logger.debug("Created JMX client after {} attempts", i);
+ LOG.debug("Created JMX client after {} attempts", i);
}
}
@Override
- public NetconfOperationServiceImpl createService(long netconfSessionId, String netconfSessionIdForReporting) {
- try {
- return new NetconfOperationServiceImpl(yangStoreService, jmxClient, netconfSessionIdForReporting);
- } catch (YangStoreException e) {
- throw new IllegalStateException(e);
- }
+ public NetconfOperationServiceImpl createService(String netconfSessionIdForReporting) {
+ return new NetconfOperationServiceImpl(yangStoreService, jmxClient, netconfSessionIdForReporting);
}
}