Simple changes to eliminate pmd warnings

[controller.git] / opendaylight / sal / api / src / main / java / org / opendaylight / controller / sal / core / Description.java

diff --git a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/Description.java b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/Description.java
index 4233dcbb683b0db55ab9170aefa6561152e7820b..ebc12cdbf7a28d86cdafce135e0e98881846806b 100644 (file)
--- a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/Description.java
+++ b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/Description.java
@@ -3,17 +3,14 @@ package org.opendaylight.controller.sal.core;
 import javax.xml.bind.annotation.XmlElement;
 import javax.xml.bind.annotation.XmlRootElement;
 
-import org.apache.commons.lang3.builder.EqualsBuilder;
-import org.apache.commons.lang3.builder.HashCodeBuilder;
-
 /**
  * The class represents the Name property of an element.
  */
 @XmlRootElement
 @SuppressWarnings("serial")
 public class Description extends Property {
-    @XmlElement
-    private String description;
+    @XmlElement(name="value")
+    private String descriptionValue;
     public static final String propertyName = "description";
 
     /*
@@ -21,34 +18,56 @@ public class Description extends Property {
      */
     private Description() {
         super(propertyName);
-        this.description = null;
+        this.descriptionValue = null;
     }
 
     public Description(String description) {
         super(propertyName);
-        this.description = description;
+        this.descriptionValue = description;
     }
 
+    @Override
     public Description clone() {
-        return new Description(this.description);
+        return new Description(this.descriptionValue);
     }
 
     public String getValue() {
-        return this.description;
+        return this.descriptionValue;
     }
 
     @Override
     public int hashCode() {
-        return HashCodeBuilder.reflectionHashCode(this);
+        final int prime = 31;
+        int result = super.hashCode();
+        result = prime * result
+                + ((descriptionValue == null) ? 0 : descriptionValue.hashCode());
+        return result;
     }
 
     @Override
     public boolean equals(Object obj) {
-        return EqualsBuilder.reflectionEquals(this, obj);
+        if (this == obj)
+            return true;
+        if (!super.equals(obj))
+            return false;
+        if (getClass() != obj.getClass())
+            return false;
+        Description other = (Description) obj;
+        if (descriptionValue == null) {
+            if (other.descriptionValue != null)
+                return false;
+        } else if (!descriptionValue.equals(other.descriptionValue))
+            return false;
+        return true;
     }
 
     @Override
     public String toString() {
-        return "Description[" + description + "]";
+        return "Description[" + descriptionValue + "]";
+    }
+
+    @Override
+    public String getStringValue() {
+        return descriptionValue;
     }
 }