Simple changes to eliminate pmd warnings

[controller.git] / opendaylight / sal / api / src / main / java / org / opendaylight / controller / sal / core / Tier.java

diff --git a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/Tier.java b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/Tier.java
index f45599f6c80bd5b980aa0c488f1472a564f978f4..d1af778526bce58b9a1e8841a3cb8d2d64aa5712 100644 (file)
--- a/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/Tier.java
+++ b/opendaylight/sal/api/src/main/java/org/opendaylight/controller/sal/core/Tier.java
@@ -12,9 +12,6 @@ package org.opendaylight.controller.sal.core;
 import javax.xml.bind.annotation.XmlElement;
 import javax.xml.bind.annotation.XmlRootElement;
 
-import org.apache.commons.lang3.builder.EqualsBuilder;
-import org.apache.commons.lang3.builder.HashCodeBuilder;
-
 /**
  * The class represents the Tier property of a node
  *
@@ -23,7 +20,7 @@ import org.apache.commons.lang3.builder.HashCodeBuilder;
 @XmlRootElement
 @SuppressWarnings("serial")
 public class Tier extends Property {
-    @XmlElement
+    @XmlElement(name="value")
     private int tierValue;
     public static final String TierPropName = "tier";
 
@@ -40,6 +37,7 @@ public class Tier extends Property {
         this.tierValue = 0;
     }
 
+    @Override
     public Tier clone() {
         return new Tier(this.tierValue);
     }
@@ -50,16 +48,33 @@ public class Tier extends Property {
 
     @Override
     public int hashCode() {
-        return HashCodeBuilder.reflectionHashCode(this);
+        final int prime = 31;
+        int result = super.hashCode();
+        result = prime * result + tierValue;
+        return result;
     }
 
     @Override
     public boolean equals(Object obj) {
-        return EqualsBuilder.reflectionEquals(this, obj);
+        if (this == obj)
+            return true;
+        if (!super.equals(obj))
+            return false;
+        if (getClass() != obj.getClass())
+            return false;
+        Tier other = (Tier) obj;
+        if (tierValue != other.tierValue)
+            return false;
+        return true;
     }
 
     @Override
     public String toString() {
         return "Tier[" + tierValue + "]";
     }
+
+    @Override
+    public String getStringValue() {
+        return String.valueOf(tierValue);
+    }
 }