Fixing warnings in the sal sub-project.

[controller.git] / opendaylight / sal / api / src / test / java / org / opendaylight / controller / sal / core / PathTest.java

diff --git a/opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/PathTest.java b/opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/PathTest.java
index 9058156b9e05ba607946f0dcb0b2b0dcfea142e6..0ea88558ded7e0113e283b520f61bc426aa735ea 100644 (file)
--- a/opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/PathTest.java
+++ b/opendaylight/sal/api/src/test/java/org/opendaylight/controller/sal/core/PathTest.java
@@ -21,11 +21,6 @@ import java.util.List;
 import java.util.Arrays;
 import org.junit.Assert;
 import org.junit.Test;
-import org.opendaylight.controller.sal.core.ConstructionException;
-import org.opendaylight.controller.sal.core.Edge;
-import org.opendaylight.controller.sal.core.Node;
-import org.opendaylight.controller.sal.core.NodeConnector;
-import org.opendaylight.controller.sal.core.Path;
 
 public class PathTest {
     @Test
@@ -63,13 +58,15 @@ public class PathTest {
             Edge e2 = new Edge(c2, c3);
             Edge e3 = new Edge(c3, c4);
             Edge e4 = new Edge(c4, c5);
-            edges = new LinkedList(Arrays.asList(e0, e1, e2, e3, e4));
+            // actually need a LinkedList because we're going to .remove()
+            edges = new LinkedList<Edge>(Arrays.asList(e0, e1, e2, e3, e4));
         } catch (ConstructionException e) {
             // Exception is NOT expected if raised test will fail
             Assert.assertTrue(false);
         }
 
         try {
+            @SuppressWarnings("unused")
             Path res = new Path(edges);
         } catch (ConstructionException e) {
             // Exception is NOT expected if raised test will fail
@@ -82,6 +79,7 @@ public class PathTest {
         edges.remove(2);
 
         try {
+            @SuppressWarnings("unused")
             Path res = new Path(edges);
             // Exception is expected if not raised test will fail
             Assert.assertTrue(false);
@@ -130,7 +128,7 @@ public class PathTest {
             Edge e2 = new Edge(c2, c3);
             Edge e3 = new Edge(c3, c4);
             Edge e4 = new Edge(c4, c5);
-            edges1 = new LinkedList(Arrays.asList(e0, e1, e2, e3, e4));
+            edges1 = Arrays.asList(e0, e1, e2, e3, e4);
         } catch (ConstructionException e) {
             // Exception is NOT expected if raised test will fail
             Assert.assertTrue(false);
@@ -168,7 +166,7 @@ public class PathTest {
             Edge e2 = new Edge(c2, c3);
             Edge e3 = new Edge(c3, c4);
             Edge e4 = new Edge(c4, c5);
-            edges2 = new LinkedList(Arrays.asList(e0, e1, e2, e3, e4));
+            edges2 = Arrays.asList(e0, e1, e2, e3, e4);
         } catch (ConstructionException e) {
             // Exception is NOT expected if raised test will fail
             Assert.assertTrue(false);
@@ -206,7 +204,7 @@ public class PathTest {
             Edge e2 = new Edge(c2, c3);
             Edge e3 = new Edge(c3, c4);
             Edge e4 = new Edge(c4, c5);
-            edges3 = new LinkedList(Arrays.asList(e0, e1, e2, e3, e4));
+            edges3 = Arrays.asList(e0, e1, e2, e3, e4);
         } catch (ConstructionException e) {
             // Exception is NOT expected if raised test will fail
             Assert.assertTrue(false);
@@ -235,7 +233,8 @@ public class PathTest {
     @Test
     public void testPathEmpty() {
         try {
-            Path path = new Path(new LinkedList());
+            @SuppressWarnings("unused")
+            Path path = new Path(new LinkedList<Edge>());
             // Exception is expected if not raised test will fail
             Assert.assertTrue(false);
         } catch (ConstructionException e) {
@@ -257,7 +256,8 @@ public class PathTest {
 
             Edge e0 = new Edge(c0, c1);
 
-            Path path = new Path(new LinkedList(Arrays.asList(e0)));
+            @SuppressWarnings("unused")
+            Path path = new Path(Arrays.asList(e0));
         } catch (ConstructionException e) {
             // Exception is NOT expected if raised test will fail
             Assert.assertTrue(false);
@@ -299,7 +299,7 @@ public class PathTest {
             Edge e2 = new Edge(c2, c3);
             Edge e3 = new Edge(c3, c4);
             Edge e4 = new Edge(c4, c5);
-            List<Edge> edges = new LinkedList(Arrays.asList(e0, e1, e2, e3, e4));
+            List<Edge> edges = Arrays.asList(e0, e1, e2, e3, e4);
             Path path = new Path(edges);
 
             // Test start node
@@ -325,7 +325,7 @@ public class PathTest {
                             (short) 0x1), n1);
 
             Edge e0 = new Edge(c0, c1);
-            List<Edge> edges = new LinkedList(Arrays.asList(e0));
+            List<Edge> edges = Arrays.asList(e0);
             Path path = new Path(edges);
 
             // Test start node