guillaume.lambert [Tue, 13 Oct 2020 13:58:55 +0000 (15:58 +0200)]
fix/rename transportpce-network-topology YANG file
The filename was inconsistent with its namespace and prefix i.e.
transportpce-topology and tpce-topology.
JIRA: TRNSPRTPCE-340
Change-Id: Ica44bef1026842de8258dbb77e69d37f3bd89716
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
(cherry picked from commit
d387a85da6807f60a1eace010ceeecff440a0512)
Balagangadhar Bathula [Wed, 7 Oct 2020 16:00:48 +0000 (12:00 -0400)]
Clean up API YANG models with the help of pyang
This addresses the following pyang generated warnings
- Remove any unused imports
- Add revision dates to the imports
- Order the revisions
- Fix a warning in org-openroadm-resource (MSA related)
JIRA: TRNSPRTPCE-340
Change-Id: I37dae25c3a54d5245a84b209b0f1f1981799fe5a
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
(cherry picked from commit
722de361b95b7aa8c199b774653e67c78e661adb)
Balagangadhar Bathula [Wed, 7 Oct 2020 15:31:24 +0000 (11:31 -0400)]
rename API transportpce-renderer-device YANG file
and modify java code / imports accordingly.
The filename was inconsistent with its namespace and prefix i.e.
transportpce-device-renderer.
JIRA: TRNSPRTPCE-340
Change-Id: I088813daa46472745400cd4cdd764061c1e20444
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
(cherry picked from commit
70443644ba70b8634539ca58e94d61ab57fc2c22)
Balagangadhar Bathula [Wed, 7 Oct 2020 14:37:15 +0000 (10:37 -0400)]
fix a bug in ServiceHandler ModelMappingUtil
OTU, ODU and CLLI are wrongly assigned twice.
JIRA: TRNSPRTPCE-339
Change-Id: I3277d7d97bf43be2ddfd501d64d827107e84ce28
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
(cherry picked from commit
6b2681f7128d84c1f602f6a3cdd0142e2bbec858)
manuedelf [Fri, 9 Oct 2020 18:42:54 +0000 (20:42 +0200)]
Technical debt - fix SH deprecated warnings
JIRA: TRNSPRTPCE-334
Signed-off-by: manuedelf <emmanuelle.delfour@orange.com>
Change-Id: Ia7ed580e7c15050cbffd75be433aef5806097e2c
manuedelf [Fri, 9 Oct 2020 13:30:06 +0000 (15:30 +0200)]
Technical debt - Service handler Sonar issues
JIRA: TRNSPRTPCE-214
Change-Id: Ibdae3184f6f261e371db8d12e4719b105ca61705
Signed-off-by: manuedelf <emmanuelle.delfour@orange.com>
manuedelf [Mon, 12 Oct 2020 09:43:30 +0000 (11:43 +0200)]
Bump to Aluminium SR1 dev version
JIRA: TRNSPRTPCE-336
Signed-off-by: manuedelf <emmanuelle.delfour@orange.com>
Change-Id: Ie16a4d93061a0e92cc24cb39d150c569b09345d6
Gilles Thouenon [Tue, 13 Oct 2020 08:46:52 +0000 (08:46 +0000)]
Merge "Fix tpce internal Yang syntax" into stable/aluminium
manuedelf [Mon, 12 Oct 2020 12:36:26 +0000 (14:36 +0200)]
Fix tpce internal Yang syntax
- garbage/superflous "}" are no more tolerated by yangtools
JIRA: TRNSPRTPCE-336
Signed-off-by: manuedelf <emmanuelle.delfour@orange.com>
Change-Id: I4d9ec5ffc20a9daca4487a3e783e0183b517fbe3
guillaume.lambert [Thu, 17 Sep 2020 08:07:21 +0000 (10:07 +0200)]
rationalize inventory code
JIRA: TRNSPRTPCE-207
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3e3f0e9535b98652ac3643151f68dd02ee0e21a4
(cherry picked from commit
ebfb35225a621f0e4e19616057ee0ad870618009)
Guillaume Lambert [Mon, 12 Oct 2020 09:17:30 +0000 (09:17 +0000)]
Merge "Technical debt - Fix PCE sonar issues" into stable/aluminium
manuedelf [Fri, 9 Oct 2020 09:47:46 +0000 (11:47 +0200)]
Technical debt - Fix PCE sonar issues
JIRA: TRNSPRTPCE-274
Change-Id: If50936c2cf75be450212f9f568125cfb6033a0d8
Signed-off-by: manuedelf <emmanuelle.delfour@orange.com>
manuedelf [Thu, 8 Oct 2020 11:46:44 +0000 (13:46 +0200)]
Technical debt - fix Renderer sonar issues
JIRA: TRNSPRTPCE-213
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iadbd280f814b3ea7e9b8c55740bdb4a8698cdfc4
Gilles Thouenon [Wed, 7 Oct 2020 15:48:01 +0000 (17:48 +0200)]
Add OTN links support in TAPI topology
- Add OTN OTU4 and ODU4 links in TAPI topology. Replace 2
unidirectional OTU4 links in OpenROADM otn-topology by a single
bidirectional Photonics link in TAPI. In the same way, replace 2
unidirectional ODU4 links in OpenROADM otn-topology by a single
bidirectional ODU link in TAPI topology
- add new Unitary tests for TAPI otn links
- add a new sample OpenROADM otn-topology XML file
containing more nodes with OTN links as input for UTs
- adapt UUID creation to take into account new OTN topology context
- wait that the XML input file has been written in datastore before
getting topology from it in UT
JIRA: TRNSPRTPCE-185
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I5c762f30d3bd290b98d04d7f960fb1077be3a111
Gilles Thouenon [Tue, 6 Oct 2020 08:58:09 +0000 (10:58 +0200)]
Fix bug in TAPI for transitional links
UUID of transitional links were identical for SPDR-SA1 and SPDR-SC1.
To solve it, we can consider the node id to create a per-device unique
UUID.
JIRA: TRNSPRTPCE-333
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I00943607bdc553bfdaef045cb8fad03a8a80efd8
Guillaume Lambert [Sat, 3 Oct 2020 16:15:13 +0000 (16:15 +0000)]
Merge "Reactive remaining Junits tests for Al migration" into stable/aluminium
Guillaume Lambert [Sat, 3 Oct 2020 16:14:22 +0000 (16:14 +0000)]
Merge "Migrate to Al and reactivate some Junit tests" into stable/aluminium
manuedelf [Tue, 15 Sep 2020 14:31:11 +0000 (16:31 +0200)]
Reactive remaining Junits tests for Al migration
JIRA: TRNSPRTPCE-305
Change-Id: I0e684f389b4c9f4e0924d0cfef244992d0da8ca5
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
(cherry picked from commit
2df235e965f3b4ff99f2e7bfc5a2911869c97c03)
manuedelf [Tue, 15 Sep 2020 14:31:11 +0000 (16:31 +0200)]
Migrate to Al and reactivate some Junit tests
- Use of BindingDOMCodecServices in DataStoreContext
- remove @Ignore decorator and fix unit tests when needed
This commit reintroduces the import of mdsal.binding.dom.codec.impl
.BindingCodecContext in common/src/main/[..]/DataStoreContextImpl.java.
This dependency was preventing karaf from starting up correctly and was
removed previously in commit
243c08d8b7ad90b0cbaec76a33a639d6fa96f5c8
Since DataStoreContext is no more used outside of the test scope,
common/src/main/[..]/DataStoreContext.java and friends have been moved
into test-common before reintroducing this import.
They are now only used in test scope / build time.
This way, the karaf start-up problem is avoided.
JIRA: TRNSPRTPCE-305
Change-Id: I246a9d58879be047c470f8a683993bc81d3a54a3
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
(cherry picked from commit
01496e26615d33be24a427e0f4d12a161acbe064)
guillaume.lambert [Tue, 22 Sep 2020 08:11:12 +0000 (10:11 +0200)]
do not explicit serialVersionUID anymore
A new SpotBug rule has been introduced in odlparent Aluminium and
suggests to explicit the serialVersionUID in serializable classes to
avoid compilers interoperability problems due to a Java implementation
design flaw.
If this is useful in a few situations (rare today), this also means that
theorically developers must maintain this field and increment it across
classes incompatible versions.
Practically, this step is often forgotten, paving the way to more
serious problems.
Since the situation here does not require it, it is healthier to simply
ignore this (soon obsolete?) recommendation.
For more details:
git log pce/src/main/java/org/opendaylight/transportpce/pce/networkanalyzer/PceLink.java
https://github.com/rzwitserloot/lombok/wiki/WHY-NOT:-serialVersionUID
https://moi.vonos.net/java/serialization-synthetic/
https://rules.sonarsource.com/java/RSPEC-4926
https://www.vojtechruzicka.com/explicitly-declare-serialversionuid/
https://www.infoworld.com/article/
3275924/oracle-plans-to-dump-risky-java-serialization.html
JIRA: TRNSPRTPCE-292
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I4e36134061104d912a75f3a578d43ca0bc17ab1f
(cherry picked from commit
a00f3ee60b16735f27af765a5bf357c56a091bc5)
manuedelf [Tue, 15 Sep 2020 14:31:11 +0000 (16:31 +0200)]
Move common DataStoreContext and co to test-common
Before Al migration, DataStoreContext was used only by GNPy at run-time.
As GNPy does not use it anymore, move it to test scope by putting it in
the test-common module.
JIRA: TRNSPRTPCE-305
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I8ea8afbdab56de08c594c9edb55543cb8d1901b7
(cherry picked from commit
b6ad4ae8cec0ad9e3fa35b1e6e3153f045a97bf1)
Guillaume Lambert [Fri, 25 Sep 2020 09:34:53 +0000 (09:34 +0000)]
Merge "Test suite for flex-grid support" into stable/aluminium
Guillaume Lambert [Fri, 25 Sep 2020 08:40:35 +0000 (08:40 +0000)]
Merge changes from topic "pylint-issues-stable/aluminium" into stable/aluminium
* changes:
use dict instead of many elif in functional tests
convert test_topoPortmapping.py to snake case
remove dead code from topology221 test
fix some pylint issues
fix superflous parenthesis pointed out by pylint
fix functional tests linelength pylint issues
fix few bugs and unused issues in functional tests
fix pylint configuration
run autopep8 on functional tests
guillaume.lambert [Wed, 9 Sep 2020 10:06:26 +0000 (12:06 +0200)]
use dict instead of many elif in functional tests
and add some forgotten tests in topology tests
JIRA: TRNSPRTPCE-320
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ic0d0e00931527ecf421914fd3bf2048504758f49
(cherry picked from commit
868e64eafd77ca3e0238a41cb0c062fd777b9564)
guillaume.lambert [Thu, 10 Sep 2020 09:46:42 +0000 (11:46 +0200)]
convert test_topoPortmapping.py to snake case
JIRA: TRNSPRTPCE-320
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I815871de4609c724cffe5f7ccdbcbfa3cab70de9
(cherry picked from commit
9ba30212c854491c400b3702d481013f5b262880)
guillaume.lambert [Thu, 10 Sep 2020 09:42:53 +0000 (11:42 +0200)]
remove dead code from topology221 test
JIRA: TRNSPRTPCE-320
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3657ce7a6af97b8043577c38cd579df352d32718
(cherry picked from commit
f3259f5e419dea1bd0f295201c5c044ed1a6c951)
guillaume.lambert [Mon, 7 Sep 2020 14:44:51 +0000 (16:44 +0200)]
fix some pylint issues
and use a "#pylint disable=" comment to eliminate false positives
JIRA: TRNSPRTPCE-320
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I4a741f9f30f6d8e2e2ea209ad44f936cdaf6150f
(cherry picked from commit
6fe500a1bf557eb44d22584ac6bf7c924f12c47f)
guillaume.lambert [Fri, 4 Sep 2020 14:25:42 +0000 (16:25 +0200)]
fix superflous parenthesis pointed out by pylint
JIRA: TRNSPRTPCE-320
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ibe23741d5a18814575cd05f1590d7c5ce0379c92
(cherry picked from commit
3492e0ddd262c793fa03b1fcd8738ba9cded6ea5)
guillaume.lambert [Fri, 4 Sep 2020 13:13:33 +0000 (15:13 +0200)]
fix functional tests linelength pylint issues
JIRA: TRNSPRTPCE-320
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I4850052ec973fc799e956e1e4c5e817e8def4360
(cherry picked from commit
82ae34c05bd194c26ef4e30b2bdf1cf19093e19b)
guillaume.lambert [Fri, 4 Sep 2020 09:32:21 +0000 (11:32 +0200)]
fix few bugs and unused issues in functional tests
pointed out by pylint
JIRA: TRNSPRTPCE-320
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I37d95d2df919fd020fecf2750452442fb482ffb7
(cherry picked from commit
389574d637e154f75abb5244f50e0130b08e177c)
guillaume.lambert [Fri, 4 Sep 2020 08:52:02 +0000 (10:52 +0200)]
fix pylint configuration
- modify the method regex used:
Tests methods name are commonly above the default limit of 32 char.
They also use capital letters here to abide by the OpenROADM and WDM
naming conventions.
- modify the variable regex used:
It was supporting by default only the snake case and reported
camel case variables as errors.
Variable names also use capital letters here to abide by the OpenROADM
and WDM naming conventions.
- disable the no-member check (inline):
it reports many false positives since pylint is unable to retrieve
the HTTP return codes given in the request package dictionary
- disable the too-many-public-methods check (inline):
it reports many false positives since unittests requires many public
methods
JIRA: TRNSPRTPCE-320
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I21686442628591fd2c4af5182dc9f438e5701cb2
(cherry picked from commit
eb62dcae252d4ca82e7308b575c9babdbade868d)
guillaume.lambert [Fri, 4 Sep 2020 08:41:16 +0000 (10:41 +0200)]
run autopep8 on functional tests
JIRA: TRNSPRTPCE-320
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I6a4bc50291e1debde1ecf3bbdf57368ba235ace6
(cherry picked from commit
33dfc1e027c4eabdb78d5a30388840fa09a7157e)
manuedelf [Mon, 21 Sep 2020 12:31:11 +0000 (14:31 +0200)]
fix a bug in PceTestUtils Junit
JIRA: TRNSPRTPCE-305
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I727ea7dac4d68069cadb5d63f25ae704a26a4c1a
(cherry picked from commit
e34ba8f98dd4fbc3b1995b2137ba58526badad41)
guillaume.lambert [Thu, 24 Sep 2020 09:00:44 +0000 (11:00 +0200)]
improve TAPI feature installation Al documentation
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I8fea67fe31a8a94775f7800b2829c4f17c795a1d
manuedelf [Mon, 21 Sep 2020 12:26:12 +0000 (14:26 +0200)]
fix test-common dependency scope in some pom files
JIRA: TRNSPRTPCE-305
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I792c0e765b8b7f460ee77d5e51297f1d76e575ff
(cherry picked from commit
20f714ddd2e0bb1d4b23aad6398c2767e28d991c)
guillaume.lambert [Mon, 21 Sep 2020 08:02:31 +0000 (10:02 +0200)]
Remove dead code from Junit tests
JIRA: TRNSPRTPCE-305
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I8c584686a80bf4daf6eefd09c3250240bba39e1e
(cherry picked from commit
856861ad8949f6be6be0af162bea5e4a4067e020)
Gilles Thouenon [Tue, 22 Sep 2020 11:25:38 +0000 (13:25 +0200)]
Update Aluminium documentation
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Olivier Renais <olivier.renais@orange.com>
Change-Id: I6efff17677c201168e9fab06f42fc643a6056be3
Gilles Thouenon [Thu, 16 Jul 2020 09:40:24 +0000 (11:40 +0200)]
Update MgSR2 documentation for OTN part
JIRA: TRNSPRTPCE-289
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: Ie890eecdd9eb3f8c11dfe444986b7e2b12095d60
(cherry picked from commit
7087db699fa0738bb32d1f024c140e638ccaf4a4)
Balagangadhar Bathula [Mon, 20 Jul 2020 05:04:07 +0000 (01:04 -0400)]
Test suite for flex-grid support
- Add new config with mc-capabilities
- New functional tests to check the flex-grid interfaces
- Functional tests for updaed portmapping
- Functional test for device-renderer
JIRA: TRNSPRTPCE-253 TRNSPRTPCE-307
Change-Id: Ic4999c1b117d762ba2fe0f6b959a513f65235580
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
guillaume.lambert [Fri, 18 Sep 2020 06:34:40 +0000 (08:34 +0200)]
update .gitreview
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1ab1c37802f2d8039985e68f87f7029a20be3f6c
Christophe Betoule [Thu, 3 Sep 2020 16:27:08 +0000 (18:27 +0200)]
GNPy migration to Aluminium
- use BindingDOMCodecServices instead of direct implementation
- update the GNPy YANG model in the API
by removing the key index from route-object-include-exclude
- add log debug for request and response to and from GNPy api
- Junit tests will be managed in another change
JIRA: TRNSPRTPCE-314
Signed-off-by: Christophe Betoule <christophe.betoule@orange.com>
Co-authored-by: manuedelf <emmanuelle.delfour@orange.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ic9f7d04ab04f963e9c3374637b93b7920fe8a3d8
Gilles Thouenon [Mon, 31 Aug 2020 13:59:20 +0000 (15:59 +0200)]
Make TransportPCE functional tests running
- code request "not found" have been replaced by "conflict"
- adapt some tests to new structure returned by the REST API.
- increase karaf JAVA memory size in tapi functional test
JIRA: TRNSPRTPCE-310 TRNSPRTPCE-292
Co-authored-by: guillaume.lambert <guillaume.lambert@orange.com>
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I89b441d7fe17823397551b4af472e9d88e9683b2
guillaume.lambert [Tue, 18 Aug 2020 14:16:13 +0000 (16:16 +0200)]
Ignore Junit failures after dom.codec.impl removal
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-305
Change-Id: Ifac3667cfc34d0959047c901e04815ec7254d136
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
guillaume.lambert [Wed, 19 Aug 2020 15:23:07 +0000 (17:23 +0200)]
get rid of mdsal.binding.dom.codec.impl
to fix karaf startup issue.
Starting from Aluminium, this package can no more be consumed directly
outside of MDSAL by OSGi bundles- cf mdsal change 89040
https://git.opendaylight.org/gerrit/c/mdsal/+/89040
As a result, the code still builds but hangs at runtime.
Also since schemacontext is being retired, the best option for getting
rid of it is to migrate to EffectiveModelContext ConstantAdapterContext.
https://docs.opendaylight.org/en/latest/release-notes/upgrade-process.html#schemacontext-is-being-retired
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-295
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Id01b032411100c82dbf41b361a9c85d06aeb98d9
guillaume.lambert [Tue, 18 Aug 2020 14:16:13 +0000 (16:16 +0200)]
Ignore Junit tests in failure after Al migration
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-305
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I4b13e053a87865688b8884a7156df0a30aa08e23
guillaume.lambert [Mon, 17 Aug 2020 12:55:07 +0000 (14:55 +0200)]
Migrate TAPI module to Aluminium
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-304
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I23c0277460a265525e18662ba127691dd71fa284
guillaume.lambert [Tue, 18 Aug 2020 07:54:35 +0000 (09:54 +0200)]
Migrate SH module to Aluminium
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-303
Change-Id: I55c9df594ab1bec2f2de737c3a35bbec8db4e8b4
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
manuedelf [Tue, 18 Aug 2020 07:12:13 +0000 (09:12 +0200)]
Migrate PCE module to Aluminium
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-302
Co-authored-by: guillaume.lambert <guillaume.lambert@orange.com>
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ib533555abc85c2bb6b38eed02e01e6513e7afe47
guillaume.lambert [Tue, 15 Sep 2020 13:53:57 +0000 (15:53 +0200)]
Unplug savagely a GNPy link to the PCE module
MDSAL codecRegistry Serializer implementation can no more be used
directly as it is done in the PCE for GNPy. This operation must be done
now through the BindingDOMCodec OSGi Services instead.
However, this adaptation is easier to proceed after the PCE migration.
Let's unplug this part of the code for the moment.
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-302 TRNSPRTPCE-314
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: If841413637b1d6983bdae49d835f6ccb574036d8
manuedelf [Tue, 18 Aug 2020 07:03:07 +0000 (09:03 +0200)]
Migrate OLM module to Aluminium
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-301
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1d7a9cbc18399c1e211b07aaafd64057d52bb0f0
manuedelf [Tue, 18 Aug 2020 07:02:45 +0000 (09:02 +0200)]
Migrate inventory module to Aluminium
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-300
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: If4314c58461a1d6cc6f38475dbdf743cd674495e
manuedelf [Tue, 18 Aug 2020 07:02:13 +0000 (09:02 +0200)]
Migrate renderer module to Aluminium
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-299
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Co-authored-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I7c63b5b2edd53ec5424925449825e36a4edeacd7
manuedelf [Tue, 18 Aug 2020 07:01:39 +0000 (09:01 +0200)]
Migrate networkmodel module to Aluminium
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-298
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I2603b7b304f90a1c85e23c21884ce90e49b34318
manuedelf [Tue, 18 Aug 2020 07:00:02 +0000 (09:00 +0200)]
Migrate common module to Aluminium Step 2
mostly to use EffectiveModelContext instead of SchemaContext
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-297 TRNSPRTPCE-306
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I393d935c0d27d45fe068895e327baf7ff6408bcf
manuedelf [Thu, 27 Aug 2020 08:32:55 +0000 (10:32 +0200)]
Migrate common module to Aluminium Step 1
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-297
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I9d264136b83d1267cee4e59520b0a682d4258c24
manuedelf [Thu, 27 Aug 2020 08:38:19 +0000 (10:38 +0200)]
Remove common module deprecated methods
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I097d664cb06f9505ed94f04e899b0cae738b5fe3
Gilles Thouenon [Mon, 31 Aug 2020 13:54:19 +0000 (15:54 +0200)]
fix blueprints to let karaf inject mdsal deps
https://docs.opendaylight.org/en/latest/release-notes/upgrade-process.html#use-of-odl-type-in-blueprint-is-discouraged
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I43bf6c7d733656df2c4f0288b30e9ca777911927
guillaume.lambert [Mon, 17 Aug 2020 14:13:52 +0000 (16:13 +0200)]
package iana-afn-safi with ordmodels device
since it has been removed from mdsal
https://git.opendaylight.org/gerrit/c/mdsal/+/89095/
NB: iana-afn-safi and OpenROADM use 2 different licenses
but both are of the BSD family and are compatible with EPL
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-296 TRNSPRTPCE-293
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I0da1728b9e02acd801862316a322f43e37524797
Gilles Thouenon [Thu, 13 Aug 2020 08:21:44 +0000 (10:21 +0200)]
Bump projet dependencies to Aluminium
- odlparent => 7.0.5
- mdsal => 6.0.4
- netconf => 1.9.0-SNAPSHOT
- restconf => 1.12.0-SNAPSHOT
- controller => 2.0.3
- lighty.io => 13.0.0 (not yet available on maven central)
maybe 13.0.0-SNAPSHOT would be more indicated at that stage
but it is not referenced
the other option would be to build lighty-core master as before
https://docs.opendaylight.org/projects/integration-distribution/en/latest/platform-versions.html
https://docs.opendaylight.org/en/latest/release-notes/upgrade-process.html?highlight=upgrade#version-bump
JIRA: TRNSPRTPCE-292 TRNSPRTPCE-296 TRNSPRTPCE-294
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: manuedelf <emmanuelle.delfour@orange.com>
Co-authored-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ibe488f1822f39ece3c054c4dab9ceac253a2b555
Susmitha Avula [Mon, 15 Jun 2020 20:22:00 +0000 (16:22 -0400)]
Enabled flex-grid support for 2.2.1 Roadms
- Added FlexGridImpl class
- Modified device-renderer for creating MC and NMC
interfaces
JIRA: TRNSPRTPCE-253 TRNSPRTPCE-307
Change-Id: I6d3546d35d7dc80c4b3fb60a0a8916416d28658a
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Balagangadhar Bathula [Mon, 20 Jul 2020 03:44:35 +0000 (23:44 -0400)]
Upgrade portmapping YANG to enable flex-grid
- Add list in node container of portmapping to support flex-grid
mc-capabilities for ROADM node.
- modify import statements accordingly.
- modify tests that were failing.
JIRA: TRNSPRTPCE-253 TRNSPRTPCE-307
Change-Id: I4b821b46ca700295f024eef1ceaf39673c07de49
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
guillaume.lambert [Mon, 31 Aug 2020 07:59:15 +0000 (09:59 +0200)]
Bump dependencies to Mg SR3 dev versions
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I08f8f327084ad5849d2231f4957d5d56a9b281fc
guillaume.lambert [Tue, 25 Aug 2020 13:09:32 +0000 (15:09 +0200)]
improve OTN renderer functional test
port-types listed in supported-interface-capability are not ordered.
Thus, all possible order must be supported.
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Iadec827ba5fff1c8b462f5add104d543a40c734f
AhmedEldeeb50 [Mon, 6 Jul 2020 15:59:32 +0000 (17:59 +0200)]
add unit tests for crossconnect package
JIRA: TRNSPRTPCE-276
Signed-off-by: AhmedEldeeb50 <ahmed.eldeeb.ext@orange.com>
Change-Id: I4b2048c9272322bcc48b950f4db11afeb82494f8
guillaume.lambert [Wed, 12 Aug 2020 22:29:16 +0000 (00:29 +0200)]
add a path computation request method in functests
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I5eecbb906b79844fc829025f27893d57d2bad19b
guillaume.lambert [Thu, 13 Aug 2020 07:34:12 +0000 (09:34 +0200)]
use service deletion method in OTN E2E functest
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: If796ce6c712157c505b201f6c56559cfba77f146
guillaume.lambert [Wed, 12 Aug 2020 10:28:14 +0000 (12:28 +0200)]
rationalize service deletion in E2E functests
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I55c75329eb599ad8f525641d5eb694f6e42843d8
guillaume.lambert [Wed, 12 Aug 2020 09:08:56 +0000 (11:08 +0200)]
fix new methods forgotten calls in func tests
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I560f2a36610138b936791ba4c7cfd67d27d3ef6e
guillaume.lambert [Tue, 11 Aug 2020 08:27:31 +0000 (10:27 +0200)]
rationalize functional tests calls to service-path
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ib3833a5579361d5f8345d534d26ee9793f7b94d7
guillaume.lambert [Fri, 24 Jul 2020 12:17:41 +0000 (14:17 +0200)]
rationalize service creation vars in E2E functests
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Id904afaee15d1375dd806555fdc431e2092f6ae6
manuedelf [Fri, 31 Jul 2020 10:50:45 +0000 (12:50 +0200)]
Update honeynode simulator version
For device 2.2.1 in order to manage flex-grid parameters
Change-Id: Iecaf0634821553e8dde77672bd640e1d28f0bbcc
Anil Belur [Wed, 29 Jul 2020 21:58:48 +0000 (21:58 +0000)]
Merge "Add INFO.yaml for transportPCE"
Gilles Thouenon [Mon, 27 Jul 2020 08:14:36 +0000 (10:14 +0200)]
Update MgSR2 kernel dependencies
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ibe4dac2e5a6455d5494c5af9453a1f5977108c9a
(cherry picked from commit
7e8e49e8a20df1f6f0c1d5b891d1d307546d3cb0)
Guillaume Lambert [Fri, 24 Jul 2020 08:56:51 +0000 (08:56 +0000)]
Merge "add methods to manage service list in func tests"
Balagangadhar Bathula [Tue, 14 Jul 2020 05:00:37 +0000 (01:00 -0400)]
Missing modulation format for 2.2.1 OCH interface
- Modified the OCH builder for 2.2.1
- Modified the test-suites
JIRA: TRNSPRTPCE-288
Change-Id: If2411fb08c358b65c6af11fdc4684daff92ac111
guillaume.lambert [Thu, 16 Jul 2020 12:50:07 +0000 (14:50 +0200)]
add methods to manage service list in func tests
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I3348586596dd26ccf5ccf286029af326704a0954
guillaume.lambert [Thu, 23 Jul 2020 09:40:09 +0000 (11:40 +0200)]
fix E2E 2.2.1 tox profile
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1ce393b69df07b8319af342ef1407b1066a7ae5f
Gilles Thouenon [Mon, 20 Jul 2020 11:15:56 +0000 (13:15 +0200)]
Fix otn-link update issue
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I2fa649cff963f28d9260eceaa363af2178577153
(cherry picked from commit
21caf15f44c58c876d204aa4b19aa29a27061347)
Gilles Thouenon [Wed, 22 Jul 2020 15:29:58 +0000 (17:29 +0200)]
Update kernel dependencies
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: Ieaa69027e0ff23116860c737c4a8cea1f184f47b
(cherry picked from commit
107bc0be050a750197b8137b37a16e0f3d35696b)
Anil Belur [Sun, 12 Jul 2020 02:57:29 +0000 (12:57 +1000)]
Add INFO.yaml for transportPCE
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I28b0da67d7dcdd54345c673dda9979834c8d1d6d
guillaume.lambert [Sat, 11 Jul 2020 09:01:13 +0000 (11:01 +0200)]
add a portmapping method in func tests
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I56e0208cbac615defc8ff6db7b0dc8fd9859d6f0
guillaume.lambert [Fri, 10 Jul 2020 15:27:13 +0000 (17:27 +0200)]
add a method to manage otn topo in func tests
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ibe9730a53912793f54480c64561644df9c965dec
guillaume.lambert [Fri, 10 Jul 2020 14:25:55 +0000 (16:25 +0200)]
add a method to manage ordm network in func tests
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: If2d568fd26772dda8abf378a10d08aae0333dd4e
guillaume.lambert [Fri, 10 Jul 2020 13:30:25 +0000 (15:30 +0200)]
add methods to manage clli network in func tests
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ia7db97dd8ae93d1802ab384233deb5a7eafb4e4d
Gilles Thouenon [Fri, 10 Jul 2020 10:23:40 +0000 (12:23 +0200)]
Fix javadoc issue
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I19e5d932524209ed8b22ff2879fbff81519f4fde
Gilles Thouenon [Fri, 10 Jul 2020 15:41:02 +0000 (17:41 +0200)]
Update to Mg SR2 kernel dependencies
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Change-Id: I7027699dffdd21a39a747430b3b6df5bff08eb5f
Thanh Ha [Fri, 10 Jul 2020 14:11:36 +0000 (10:11 -0400)]
Do not fail on warnings for docs-linkcheck
This is a workaround due to sphinx-tabs being incompatible with the
Sphinx linkchecker which throws a warning. We mainly use linkchecker
to catch broken links so we don't really need to fail on warnings as
the main "docs" builder will still fail for warning level issues so
this is a reasonable workaround.
Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I545f7cfaea27f907c13b5c21af26f1ee4b7d1b62
guillaume.lambert [Thu, 9 Jul 2020 21:40:12 +0000 (23:40 +0200)]
activate otn E2E tests in releng
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I86784e91893551c699af11618aa6b3637f6ae953
Gilles Thouenon [Wed, 8 Jul 2020 15:59:15 +0000 (17:59 +0200)]
Functional tests for end-to-end otn services
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I10f3ac24a4a13bd6426afb9f0c396fe806a06464
guillaume.lambert [Thu, 9 Jul 2020 13:52:05 +0000 (15:52 +0200)]
add methods to manage ordm topo in func tests
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I2b46cf62b3a37e25a20f3e559af224f78db52e1e
guillaume.lambert [Thu, 9 Jul 2020 20:24:07 +0000 (22:24 +0200)]
force releng tox docs-linkcheck to success
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I47dad72c244c5ed54d8aa8d2941d9a8e06316323
Guillaume Lambert [Thu, 9 Jul 2020 20:32:57 +0000 (20:32 +0000)]
Merge "Fix service-name in otn-renderer FuncTest"
Gilles Thouenon [Tue, 7 Jul 2020 13:03:10 +0000 (15:03 +0200)]
Simplify spdrA configuration management in tests
Keep only one configuration (without existing interfaces) for SPDRA,
given the fact that interfaces may now be easily created by
TransportPCE.
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I65ba30a1f960f6ad9400a2ac925af69795b0ceba
Guillaume Lambert [Thu, 9 Jul 2020 09:23:47 +0000 (09:23 +0000)]
Merge changes I1ed16552,Ia080da84
* changes:
add a method to get nodes oper DS in func tests
add a method to check nodes configs in func tests
guillaume.lambert [Wed, 8 Jul 2020 13:06:42 +0000 (15:06 +0200)]
add a method to get nodes oper DS in func tests
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: I1ed16552d2941fc75f78a8fc85a6cc9763554e04
guillaume.lambert [Tue, 7 Jul 2020 15:09:11 +0000 (17:09 +0200)]
add a method to check nodes configs in func tests
Signed-off-by: guillaume.lambert <guillaume.lambert@orange.com>
Change-Id: Ia080da8480363c2387ffd0828eb3c9ed3583d64f
Gilles Thouenon [Tue, 7 Jul 2020 08:58:21 +0000 (10:58 +0200)]
Fix service-name in otn-renderer FuncTest
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I31b447faf8153619dea383aa7ca72f092927be57
Gilles Thouenon [Thu, 2 Jul 2020 06:55:17 +0000 (08:55 +0200)]
Integration of end-to-end otn services
-allow creation and deletion of new WDM service (OCH-OTU4) and OTN
services (HO-ODU4, 10GE/1GE) from Service Handler
-complements changes 87920 and 90616 with deletion of otn services
-for 10GE and 1GE services, use trib-port and trib-slot numbers provided
by PCE computation
-for service deletion, retreive and introduce the service header
description in order to distinguish the type of otn service to delete
and adapt its deletion consequently
-adapt Junit tests consequently
JIRA: TRNSPRTPCE-165, TRNSPRTPCE-194
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I83da87a0c61eb32c9ab023ad614adc79caa3ed75
Gilles Thouenon [Thu, 2 Jul 2020 06:51:40 +0000 (08:51 +0200)]
Adapt PCE output to include trib-port & trib-slot
JIRA: TRNSPRTPCE-164
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I170e12e07f16a0f7b0e7a61d79e976b78e64e705
Gilles Thouenon [Mon, 29 Jun 2020 09:11:07 +0000 (11:11 +0200)]
Upgrade path-description model to 1.6.1 for otn
- remove mandatory attribute for wavelength number (useful only for
OCH-OTU4 services)
- add trib-port and trib-slot number attributes for otn low order
services
JIRA: TRNSPRTPCE-164
Signed-off-by: Gilles Thouenon <gilles.thouenon@orange.com>
Co-authored-by: Christophe Betoule <christophe.betoule@orange.com>
Change-Id: I495ebacc5341b0cb3067f74e1c5e8f65602cf93a