Fix InMemory shard transaction chaining.

In case we had multiple transactions going after each other quickly
the next transaction might not observe the state of the previous transaction yet.
Fix this by reusing the DataTreeModification of the previous transaction.
Also introduce state transitions into InMemoryDOMDataTreeProducer so it
behaves more like a transaction chain.

Change-Id: I96c746c1b91ac9f6b87152dca612094c73c23387
Signed-off-by: Tomas Cere <tcere@cisco.com>

Fix warnings in AbstractDOMShardTreeChangePublisher

Raw types and potentially static method.

Change-Id: I271a7fe28df47dce6b8fd335a215d14c3f46b7b8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Add batching of non-isolated transaction in ShardedDOMDataTreeProducer

Change-Id: If5ee94a6b2f58c6fd5a243f8784c8b56200b7343
Signed-off-by: Tomas Cere <tcere@cisco.com>

BUG-5561: retain SchemaContext order for bits

This patch reworks BitsCodec so it retains the bit order
defined in SchemaContext, which by extension means the values
coming from Binding objects should end up being sorted
by position.

Change-Id: Ice154dd7e38e6b213c281ddb492408f619e3a5f8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Use lambdas for functional interfaces

Makes the code more concise.

Change-Id: I6b3ed4ebefbd72b63958a0b4db98129a4e35e317
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix redundancy in documentation of DOMStoreThreePhaseCommitCohort

Change-Id: Iaafbea0d5181856e5fdcd9674893848b5a8b69a5
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>

Bug 5947: additional tests for binding-dom-adapter #3

Change-Id: I34c38d7088fbe05048e8403c971d83d3a75c8d68
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Fix deprecated Assert imports

junit.framework.Assert has been deprecated in favor of org.junit.Assert.

Change-Id: I7507a55d596ad8c03c4c9777c05a78ab3ceda710
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5947: additional tests for binding-dom-adapter #2

Change-Id: I3ce80097609761ec7d43a96d0a22d9f43d3a897d
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 6540 - HotFix for IsolatedLeader message handler

Change-Id: Icc495dbbbc5583ed68f162ace0e7f2ab12c498c3
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Use a bounded blocking queue in InmemoryDOMDataTreeShards.

Change-Id: I72b02d9f77985ec80db87792424403b6960616a2
Signed-off-by: Tomas Cere <tcere@cisco.com>

checkStyleViolationSeverity=error implemented for mdsal-dom-inmemory-datastore
Changed the local variable indVal to index.
An unwanted folder was added accidentally, removed.
Code review comments are implemented.

Change-Id: Ie1736dbec9e00a49961a46c32f4433f60c211dc0
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>

Bug 5947: additional tests for binding-dom-adapter

- FutureSchema
- BindingDOMTransactionChainAdapter
- BindingDOMRpcImplementationAdapter
- BindingDOMRpcAdapterRegistration

Change-Id: I511d39671d6b32ae49a2c8dc58da1427e96c3207
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5947: yet another tests for binding-dom-adapter

Change-Id: I57abe83c9fc49beee81764977b3ae3528ee2dccc
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 1411-4: MDSAL Binding2 Generator Impl

- BindingGeneratorImpl decomposition proposal
- introduction for Twirl templates for Yang Snippets generation
- rather more templates, less logic, more content
- JUnit test - to be finished
- added several twirl templates for YANG
- review comments fixed
- apply https://git.opendaylight.org/gerrit/#/c/44939/ for spec v2

Change-Id: I79cb7e9c0d41c23408949dd5d4d40d572cc86652
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
Signed-off-by: Filip Gregor <fgregor@cisco.com>

Implementing checkStyleViolationSeverity=error for mdsal-eos-binding-api module

Change-Id: Ic5526189f5a646a369d43676b287034c0f781ce5
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>

Implementing checkStyleViolationSeverity=error for mdsal-eos-binding-adaptor module

Change-Id: Ibb2d726a1d2e40be605ebef21deda5a03757d0b6
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>

Bug 5947: additional set of tests for binding-dom-adapter

- LazyDataTreeModification
- BindingDOMCursorAwareWriteTransactionAdapter

Change-Id: Ib5c592d15a3e80559f5c81c5e56b0e75a5e783b5
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

checkStyleViolationSeverity=error implemented for mdsal-dom-broker
Resolved the merge conflicts.
Implemented code review comments.
Implemented another set of code review comments.

Change-Id: I3eecb17342e4fd7f4736ca67bc57f01f91115c0f
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>

Bug 1411-3: MDSAL Binding2 Generator Util

- general util classes & methods
- generated type & builder classes
- Types & BindingTypes
- Annotations, Enumeration
- Method signature support
- Deviation/AnnotationType issue fixed
- Objects.hash() used in hashCode() methods
- review comments fixed

FIXME/TODO:
Binding2GeneratorUtil - implement rest of static methods, colon-dash issue
Binding2Mapping - implement rest of static methods, underscore issue

Change-Id: I9f602a893f6cbd2e9e30c6ca6dc3810e0c678d89
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Execute the ShardedDOMDataTreeTransaction.submit() async.

Change-Id: I7e8a59f03a6ed2f3e37d0aa31a2fc12b983644a8
Signed-off-by: Tomas Cere <tcere@cisco.com>

checkStyleViolationSeverity=error implemented for mdsal-dom-spi module

Resolved the merge conflicts. Implemented code review comments.
Removed empty lines within import sections of some files
Implemented some more code review comments.
Somebody had changed checkStyleViolationSeverity to warning, so it was ignoring the trailing white spaces.
Fixed the pom for dom-api and spi module + fix the code.

Change-Id: I1ea8b60c8b5910ea9f30963ada55ecbed3363a95
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make ShardCoordinationTasks public

These will be reused in controller so make them public.

Change-Id: I89fb776768d8e975fd744fd1daefc2d0bb3eaa3f
Signed-off-by: Tomas Cere <tcere@cisco.com>

Bug 6413: Fix ipv4 and ipv6 patterns used by IpAddressNoZoneBuilder

due to vague regex definition there was no way to distinguish
if shorter ip address was ipv6 or ipv4 resulting in exception
added tests

Change-Id: Id81e26f018e718675fd58469204c7ad1b647a7b1
Signed-off-by: Filip Gregor <fgregor@cisco.com>

Fixed Checkstyle violation errors in mdsal-dom-api module

Implemented code review comment. 2nd round code review comments are implemented.

Change-Id: Iaa93e0786c54d80aa8cba8289570dc281442a055
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-6028: check value types for encapsulation

This is a fast check to see if the argument matches expected
value class. If it does not it does not make sense to invoke
the serializer, as it will fail.

Change-Id: I4ca556fea057f2188fa1c34d303467565af38d5c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 1411: MDSAL Binding2 Generator API fix

Since we narrowed down schemaPath in DocumentedNode
to List, this needs to be reflected also in
GeneratedTypeBuilderBase class.

Change-Id: Id9edb2fef730bab24415878c85ccc74c4b8a1e9d
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Bug 6252

Add target/generated-sources/spi & yang/ as resource folders
Follow-up patch for Binding v2

Change-Id: I52822ca5ed5d468f8d62238133a212c9773ddffb
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Bug 1411: MDSAL Binding2 Generator API Enumeration fix

- support for missing optional sub-statements of Enum statement added
- minor related Javadoc fixes

Change-Id: I45130065c183c4e0b6094fdb0a9d18fc9709caa7
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Fix NPE when creating a producer after shard was unregistered

Change-Id: I9f6728f4c885cc18d8adf8dc9d1c14e8c99977ef
Signed-off-by: Tomas Cere <tcere@cisco.com>

BUG-1411: MDSAL Binding2 Spec - comments/feedback fixed

- based on review by Martin Sunal

Change-Id: I7da6e1c35ffed18fe62c7d4092b1eb8557913762
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

BUG-1411 MDSAL Binding2 Generator API Enumeration fix

- missing getMappedName() method in Enumeration API

Change-Id: Ibcd79173745b14464614b494880d20b434070584
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Fix AbstractDOMShardTreeChangePublisher's initial data change event

Strip shard path from listener path, when reading initial data from non
root shard. Also add requirement on DOMStoreTreeChangePublisher
interface to send initial data change event to even when data does not
exist yet.

Change-Id: I90f3aa33764a4812703c37e91378a73270fe19a3
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

BUG-1411: MDSAL Binding2 Generator API small fix

- Enumeration import fix
- reflecting Yangtools API change - EnumPair.getValue() returns int now

Change-Id: I7148801e5b184e64294344f158483ca96cc58f56
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

.gitignore .factorypath created by m2e-apt

https://github.com/vorburger/opendaylight-eclipse-setup now bundles
https://github.com/jbosstools/m2e-apt, which creates .factorypath files
all over the place.

Change-Id: I0be119c2137f3bc1d7db3214230b7ce6651ae02a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

add target/generated-sources/spi & yang/ as resource folders

and remove src/main/yang as source folder

but obviously must keep Maven's default src/main/resources
(see https://lists.opendaylight.org/pipermail/release/2016-August/007788.html)

Bug: 6252
Change-Id: I66b5dcdebc88303fd2e3e25f16f5f362b135a13e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-6316: Fix Bit and EnumPair's position/value types

Follow-up patch for Yangtools API change:
https://git.opendaylight.org/gerrit/#/c/42855/

This solves issue with distibution-check jenkins job, where
EnumPair.getValue() returns Integer instead of correct int type.

Change-Id: I459364d17747e0adf10ec021a0bd9cc3e316726d
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Use methodhandle instead of a lambda

Less text, same effect.

Change-Id: Ifa6d57f94d925268f116d95e2aac85290f133ed8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Revert "Add target/generated-sources/spi & yang/ as resource folders"

This reverts commit af8757dcd1d4ea0c794877021406e15a12000cea.

Change-Id: Id61db4aa7a915e6054060c63b6f681d9a3c45511
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add target/generated-sources/spi & yang/ as resource folders

and remove src/main/yang as source folder

Bug: 6252
Change-Id: I5574716949d29b886855a233de1e0c005e4985eb
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fixed Checkstyle violation errors in mdsal-common-api

removed SupressWarning for CheckStyle violation errors
changed checkStyleViolationSeverity=error to warning as per code review comments
Implimented some more code review comments, reverted back to checkStyleViolationSeverity=error  from warning.

Change-Id: I0b79f06ba6056d0813e8ddf7bad8896e7931b1e6
Signed-off-by: Brinda Jana <brinda.jana@nexusis.com>
Signed-off-by: Colin Dixon <colin@colindixon.com>

Bump ietf versions to ...10-SNAPSHOT

Bumping according to:
https://lists.opendaylight.org/pipermail/release/2016-August/007731.html

Change-Id: I2fc611f84c056ddea4a531d9e9e976ace3d4b557
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fix ietf-yang-types version

The version bump script messed up the ietf-yang-types version. Fixing it
with this patch.

Change-Id: Idb9b79f3b32a4fc605acbc3f94a89c5dbcfd83ee
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bump versions by 0.1.0 for next dev cycle

Change-Id: I661f05513feb495a1f1a47ffaeeb7fc6630bcd33
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

BUG-865: remove String-based getDataChildByName()

This is follow-up patch to reflect Yangtools changes
and needs to be merged after
https://git.opendaylight.org/gerrit/#/c/42898

Note:
based on information from YT devs, relying on string-based
choice node local-name when lookup by QName failed
was useful when dealing with augmented cases.
This is supposed to be fixed now in YT and MDSAL should
rely on lookup by QName only. See patch:
https://git.opendaylight.org/gerrit/#/c/40158/

Change-Id: I1300f3ee01ad678757d564ae76e23ce2c57c76fb
Signed-off-by: Martin Ciglan <mciglan@cisco.com>

Bug 6165: Do not omit java.lang prefix in various places

Yang expression "typedef String" leads to java class String,
creating potential naming conflict with java.lang.String.
Few places places in EnumTemplate are fixed by using «String.importedName».

Also, YangModuleInfoTemplate#getExplicitType
no longer removes java.lang unconditionally.

+ Ifs against void are re-ordered to occur sooner in getExplicitType.

Change-Id: If014aca30875589e361733317dfb47eaa07df031
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Add PMD configuration

PMD does not allow specifying wildcards, hence we have to enrich
its configuration here.

Change-Id: I45b7b8618950ec43f3c03cc9e4ee9d3b714d14ee
Signed-off-by: Robert Varga <rovarga@cisco.com>

Make AbstractDOMShardTreeChangePublisher advertise initial data change

Change-Id: Ia9d5a7fcb8bedcb3494b4acc55c372ca5e812424
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

BUG-6316: emit value unconditionally

In the effective model of the world, value is always present.
This is a follow-up fix for the API change introduced in
yangtools.

Change-Id: I3fae5d57fce868e03fd36a7d521f87a83205bcce
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5699 - Migrate existing code to use new sharding apis

This adds adapters that translates DOMDataBroker API calls to cursor aware
API calls

Change-Id: Iab0a94af598f355768f6ef48ac8cb358960418b1
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>

Bug 6126: Use importedName for java.lang types in ClassTemplate

There may be a type definition in Yang, which generates class name
which are the same as a class name in java.lang.

This patch fixes the conflict at defaultInstance(),
there may be other places which need fixing.

Change-Id: I3a73b5bb284db031dbfd45468cbbb8dd2a354737
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Signed-off-by: Filip Gregor <fgregor@cisco.com>

Fix a javadoc warning about empty paragraph

Change-Id: I13eb715e2e24c51bd7df8354cc0b5338aa76763c
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-6238: Remove char[]-based union instantiation path

Since we are iterating over the constituent types,
there is no need to fall back to string-based instantiation.

Change-Id: Ief17f444816d78d4266e82be3e359a5918213e6d
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5947: additional tests for binding-dom-adapter

Change-Id: Iae78d6b0ba6c5e163fac964db0099235801e6cee
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5947: added some tests for osgi in dom-broker

Change-Id: I3d404e70bd34daa47a86f072420c5d06c7674425
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5947: refactored common-api tests

Change-Id: I3b138c524094fcd6c63c46493c8af42c5d0c0d5a
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

InMemoryDOMStoreThreePhaseCommitCohort: wrong trace parameter

One parameter for trace is missing.
Looks like copy-n-paste bug

Change-Id: I4ca4cd8c790dfaefa7ad8b7f8e2f4f71ae85242d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 5947: added tests for mdsal-binding-api

Change-Id: Id6f0434eac4982ae91136fe5e2a04d40443df9a0
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5947: additional test for binding-dom-adapter

Change-Id: I4cd34de1e706eb46f2f1ddef4a89a7cc560d20d3
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Use EnumTypeBuilder

EnumPairImpl is going away, just as all public model.util
implementation classes. Use EnumPairBuilder instead.

Change-Id: Ife86e3ddf432bbd8552d95a282589b1a52645320
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 6184: Workaround for namespaces with URL with trailing slash

Change-Id: I76712209a8d42825d9e8f6d8042877cec486c53f
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Bug 2332: BindingMapping to camel split also on forward slash

This is only a partial workaround, full fix for Bug 2332 needs binding v2.

Forward slash is a first character (not allowed in general yang identifiers)
that was encountered in enums from real world Yang models.

Possibly, other separators could get the same treatment,
acting the same way as dash and dot already do.

Change-Id: Ic62198a843747092113c1c7dffaff13d09e7f943
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

implemented missing equals for InstanceIdentifierBuilderImpl with tests

Change-Id: I540a3f44f964de4c3f44281fb51d9a1404313ff7
Signed-off-by: Juraj Veverka <Juraj.Veverka@pantheon.tech>

Use TypedSchemaNode

Now that the getType() method is available through a unified
interface use it to simplify type checks.

Change-Id: I9538c3677daf4ac4e3eac080220403bf2f75adb8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove an unneeded type specifier

Optional.of() can be correctly inferred with Java 8,
remove the type argument.

Change-Id: Ie0826c03c964bb1bdfd7a070fa1bf80cef2ac3f0
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove unneeded cast

Since we have corrected the getSchema() method, there is no need
to perform a cast.

Change-Id: Ib3c9b2d7dc3a15f2cb9e042055178106f6b33cae
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix incorrect null check

Eliminate an Eclipse-generated warning, which actually shows a bug.

Calls to childNonNull() did not pass an actual instance, but rather
a 'obj != null' expression. That expression got evaluated to
a boolean, which got boxed. Hence childNonNull() could not observe
a null no matter what and we'd get a NPE on next use -- exactly where
Eclipse put a warning.

childNonNull() returns a correctly annotatad @Nonnull reference,
which can be used as a guard against this kind of mistake: if the
original code used that reference, compilation would fail,
as the checked object is a Boolean and does not have a get() method.

This patch eliminates the expression and uses the returned reference,
eliminating the possiblity of a NPE.

Change-Id: I706f077f90ea38d3a48125beeaf4711182c8b8d5
Signed-off-by: Robert Varga <rovarga@cisco.com>

Use direct type checks

With the removal of old parser and ExtendedType each type
definition implements proper subtype, hence we do not have
to traverse the type tree up to root.

Change-Id: Ib7a6ffa5f221278547e27e37b19c14a1a3c26d8a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Reuse model.util.EnumPairImpl

Instead of brewing our own, use a well-known implementation.

Change-Id: I22769eb63ca7d7ac7e5f9ac22b201282b0f5283b
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-865: make EnumPair getQName/getSchemaPath unimplemented

A yangtools change was made to get rid of these functions using
JDK8's default statement:

https://git.opendaylight.org/gerrit/#/c/41994/

This cleans up the mdsal test implementation.

Change-Id: Ib30d15848402fbe2afe016540d39bea5d4c13112
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

import fix in binding v2

minor import fix of annotation.

Change-Id: I3043a9cbf1601516423de03be0531eff96c56bf8
Signed-off-by: Filip Gregor <fgregor@cisco.com>

Remove mdsal-singleton-dom-api

We are using only DOM implementation so extra DOM API is not needed.

* delete mdsal-singleton-dom-api module
* clean artifacts/pom.xml
* clean features/pom.xml
* clean features.xml
* clean singleton-service/pom.xml
* clean mdsal-singleton-dom-impl/pom.xml

inpact for controller patch:
https://git.opendaylight.org/gerrit/#/c/42093/2
fix is here:
depends on - https://git.opendaylight.org/gerrit/#/c/42311/
blocks - https://git.opendaylight.org/gerrit/#/c/42317/

Change-Id: I8ece69ec65c3ed574160ef8a1c8cd27476f8d1f2
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Add better messages to getTypeWithSchema()

This will aid debugging issues.

Change-Id: Ic1562e092a073ee2066172efbebd2ca9a64fa9b4
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix outstanding issuess after moving code base

Move code base from mdsal-singleton-common-spi needs
repackaging and fix some small issues.

* repackaging org.opendaylight.mdsal.singleton.common.spi
  to org.opendaylight.mdsal.singleton.dom.impl
* remove unecessary code

Change-Id: I89f45d17f198dbbc98a21464fb9c4bd3690a3255
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Fix NoSuchMethodError in Eclipse IDE by removing M2E lifecycle mapping

This is no longer required with
https://github.com/vorburger/opendaylight-eclipse-setup

This FIXES Execution check-license of goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: An
API incompatibility was encountered while executing
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check:
java.lang.NoSuchMethodError:
org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V

Change-Id: I6cbe65013a50e2178b7fda99701e02cd40880d62
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add blueprint XML for the binding EntityOwnershipService

Change-Id: I4349f0f87d9fcc436ddca59e3dc111d16428a6f8
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Bug 5947: Increasing code coverage - binding-generator

Change-Id: I7d89a0bb9950776712b57bf6aad0a3425d531c73
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Move and clean mdsal-singleton-common-spi

We don't need extra project for common-spi implemntation
for yet, because Binding implementation is not relevant
anymor. So common-spi content could be moved to dom-impl
project and mdsal-singleton-common-spi could be removed.

* move mdsal-singleton-common-spi content to mdsal-singleton-dom-impl project
* remove mdsal-singleton-common-spi
* clean feature.xml + feature/pom.xml
* clean artifacts pom.xml
* clean singleton-service/pom.xml
* clean mdsal-singleton-dom-impl/pom.xml

Change-Id: I979ecebe0bbbcd6dba5bec40aef0f287e7fe5fff
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Use lambda for Codec.loader()s

Removes a bit of boiler-plate code.

Change-Id: Id0c7c8d16d374133d9439cd72587382e31252b80
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix checkstyle errors

'if(' -> 'if ('

Change-Id: I4747befcf35724bc1f99346e0ae8ab3ee5b30254
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove ClusterSingletonBinding

We would like to use DOMClusterSingletonServiceProvider only,
so we have to remove Binding CSS instances.

* remove mdsal-singleton-binding-api project
* remove mdsal-singleton-binding-impl project
* clean features.xml + features/pom.xml
* clean artefacts pom.xml
* clean singleton-service/pom.xml

Change-Id: If4cdd968210d950dc66f4835e2ae14c25cfab7cc
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Checkstyle clean-up src/test/java

Required to be able to run (enforce) CS on src/test as well.

Change-Id: Ife78f9baf1fcb462d15ca59675e4116903048c6b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix compiler error due to removal of InMemoryDataTreeFactory.create

Change-Id: I047117f1a0c234eb6d2bc5cb9a553a8c0c2d742b
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

BUG-6022: retain order of constituent types

In order to safely iterate over the types, we need
to retain their order from the SchemaNode. Use
a LinkedHashSet to achieve that.

Change-Id: I850f823a0b67dc9bc3e6b75f9a1c671e4bbf73d9
Signed-off-by: Robert Varga <rovarga@cisco.com>

Edited the MD-SAL singleton common API adoc.

Change-Id: I9debe462a3f773fb12547357197f2c84243badbb
Signed-off-by: Jan Medved <jmedved@cisco.com>

Add blueprint XML for mdsal-singleton-dom-impl

Added a blueprint XML file to instantiate and advertise the
DOMClusterSingletonServiceProviderImpl instance.

Change-Id: I768aae041b5a33d37c21505c7debab77e7dd9c1a
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Add union deserialization debugs

We seem to be hitting the slow instantiation path for some
reason. Add more debugging in an effort to hunt them down.

Change-Id: I64c5630a819d46710f7957c3972a2ba305b21ac7
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-6022: fix for yangtools api changing

Structure of deviations has changed, adjust to it.

Change-Id: Ic64e489bc6cb6c11435c5b71cf590cb8a4518f66
Signed-off-by: Robert Varga <rovarga@cisco.com>

Export impl package from mdsal-singleton-dom-impl

We need to explictly export the org.opendaylight.mdsal.singleton.dom.impl
package via maven-bundle-plugin as packages with 'impl' are
automatically excluded.

Change-Id: I6cb644eee7dc68725adc97a3ea1665c7ef5d486c
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Bug 5421 - Single cluster-wide service instances implementation

 * add Abstract ClusterSingletonServiceProvider implementation
 * add DOM & biniding ClusterSingletonServiceProvider impl.
 * add junit test suite + import Mockito

Change-Id: If5bac3f61cc3164da1e09c2caf6713c1e3da658a
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Remove project local Xtend dependencyManagement and Maven plugin

Because we now have this available in odl-parent.  Note that the
configuration there is slightly different and uses
target/generated-source instead of src.  Therefore the clean is no
longer needed.  Also add-source does not seem to be required; I've found
that the Xtend Maven plugin and the Xtend IDE M2E support already cover
this correctly by themselves.

Change-Id: Ic878b7c3d63c06595e61c42f0b729bf3d50861cf
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

BUG-6028: iterate over component types to instantiate union

This reworks union instantiation to be on par with
https://tools.ietf.org/html/rfc6020#section-9.12. We iterate
over individual members and attempt to run deserialization.

If it succeeds instantiate the union using cached constructor
specifying that member. This side-steps the need to go through
serialization.

Change-Id: Ieec37da37a05c2b2a2f432778232e136c903f654
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 5421 - Single cluster-wide service instances grouping

ClusterSingletonService grouping means to run all registred service to same
Group on same ClusterNode. So we could say, service goup will always run on
same ClusterNode.

 * implement grouping functionality for ClusterSingletonService instancies
 * implement double candidate funct. for handling ClusterSingletonService
   service group instances
 * add junit test suite + import Mockito

Change-Id: If91a6f1bf786c42c32201899bc0bb826729f0585
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Add blueprint wiring for ShardedDOMDataTree

Change-Id: I03e5d82332dd8dddf5bf782ec1f965012ba305e1
Signed-off-by: Tomas Cere <tcere@cisco.com>

Expose executor related settings for InMemoryDOMDataTreeShard

Change-Id: I4e3673ccbfc6ce14914994ca52f3a97052b8a48a
Signed-off-by: Tomas Cere <tcere@cisco.com>

Bug 4202: Require that a producer has claimed a namespace on shard registration

Change-Id: Ia8f75b64e50cad876512e3818a919a6215b296b1
Signed-off-by: Tomas Cere <tcere@cisco.com>

Bug 6112 - UnionTypeCodec fails to non-identityref value

When Non-identityref value is deserialized, ClassCastException exception occurs.
catch the exception and move to the next codec.

> java.lang.ClassCastException: java.lang.Short cannot be cast to org.opendaylight.yangtools.yang.common.QName
>         at org.opendaylight.yangtools.binding.data.codec.impl.IdentityCodec.deserialize(IdentityCodec.java:17)
>         at org.opendaylight.yangtools.binding.data.codec.impl.UnionTypeCodec.deserialize(UnionTypeCodec.java:103)
>         at org.opendaylight.yangtools.binding.data.codec.impl.LeafNodeCodecContext.deserializeObject(LeafNodeCodecContext.java:199)
>         at org.opendaylight.yangtools.binding.data.codec.impl.DataObjectCodecContext.getBindingChildValue(DataObjectCodecContext.java:328)
>         at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.getBindingData(LazyDataObject.java:148)
>         at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.invoke(LazyDataObject.java:71)
>         at com.sun.proxy.$Proxy3.getValue(Unknown Source)
>         at org.opendaylight.yangtools.binding.data.codec.test.UnionTypeWithIdentityrefTest.bug6112Test(UnionTypeWithIdentityrefTest.java:78)

Change-Id: If6d9bffbc8cecaca2894f889940c814919da6a4b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Reference BindingNormalizedNodeSerializer in BindingDOMEntityOwnershipServiceAdapter

Changed the BindingDOMEntityOwnershipServiceAdapter to reference the
BindingNormalizedNodeSerializer interface instead of the concrete
mdsal BindingToNormalizedNodeCodec class. This allows us to wire in the
controller's1 BindingToNormalizedNodeCodec instance that is currently in
use (once https://git.opendaylight.org/gerrit/#/c/41811/ and
https://git.opendaylight.org/gerrit/#/c/41815/ are merged).

Change-Id: Ia2767857c111f1ca99efd18f993762f2a48958f3
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Bug 5947: Increasing code coverage - binding-dom-adapter

Change-Id: I9dd1322938bb528378dd224487caac2f6c21404c
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>

Bug 5421 - Single cluster-wide service API

ClusterSingletonServices provides a functionality which alowe to have only
one fully instantiated service instance in a cluster at one time.

* Cluster Singleton API contract definitions
* adoc for ClusterSingletonService implementation

Change-Id: I89180c0a6b6427d6cb1087457aaf2978b8544dda
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>