Vratko Polak [Mon, 1 Aug 2016 14:31:34 +0000 (16:31 +0200)]
Bug 6126: Use importedName for java.lang types in ClassTemplate
There may be a type definition in Yang, which generates class name
which are the same as a class name in java.lang.
This patch fixes the conflict at defaultInstance(),
there may be other places which need fixing.
Change-Id: I3a73b5bb284db031dbfd45468cbbb8dd2a354737
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Signed-off-by: Filip Gregor <fgregor@cisco.com>
Robert Varga [Sun, 31 Jul 2016 15:14:32 +0000 (17:14 +0200)]
Fix a javadoc warning about empty paragraph
Change-Id: I13eb715e2e24c51bd7df8354cc0b5338aa76763c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 19 Jul 2016 18:02:39 +0000 (20:02 +0200)]
BUG-6238: Remove char[]-based union instantiation path
Since we are iterating over the constituent types,
there is no need to fall back to string-based instantiation.
Change-Id: Ief17f444816d78d4266e82be3e359a5918213e6d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Peter Nosal [Tue, 26 Jul 2016 11:32:04 +0000 (13:32 +0200)]
Bug 5947: additional tests for binding-dom-adapter
Change-Id: Iae78d6b0ba6c5e163fac964db0099235801e6cee
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Peter Nosal [Tue, 26 Jul 2016 11:32:04 +0000 (13:32 +0200)]
Bug 5947: added some tests for osgi in dom-broker
Change-Id: I3d404e70bd34daa47a86f072420c5d06c7674425
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Peter Nosal [Mon, 25 Jul 2016 12:50:16 +0000 (14:50 +0200)]
Bug 5947: refactored common-api tests
Change-Id: I3b138c524094fcd6c63c46493c8af42c5d0c0d5a
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Isaku Yamahata [Thu, 28 Jul 2016 06:08:06 +0000 (23:08 -0700)]
InMemoryDOMStoreThreePhaseCommitCohort: wrong trace parameter
One parameter for trace is missing.
Looks like copy-n-paste bug
Change-Id: I4ca4cd8c790dfaefa7ad8b7f8e2f4f71ae85242d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Peter Nosal [Wed, 27 Jul 2016 07:39:42 +0000 (09:39 +0200)]
Bug 5947: added tests for mdsal-binding-api
Change-Id: Id6f0434eac4982ae91136fe5e2a04d40443df9a0
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Peter Nosal [Fri, 29 Jul 2016 07:49:16 +0000 (09:49 +0200)]
Bug 5947: additional test for binding-dom-adapter
Change-Id: I4cd34de1e706eb46f2f1ddef4a89a7cc560d20d3
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Robert Varga [Fri, 29 Jul 2016 12:00:32 +0000 (14:00 +0200)]
Use EnumTypeBuilder
EnumPairImpl is going away, just as all public model.util
implementation classes. Use EnumPairBuilder instead.
Change-Id: Ife86e3ddf432bbd8552d95a282589b1a52645320
Signed-off-by: Robert Varga <rovarga@cisco.com>
Vratko Polak [Mon, 11 Jul 2016 16:47:46 +0000 (18:47 +0200)]
Bug 6184: Workaround for namespaces with URL with trailing slash
Change-Id: I76712209a8d42825d9e8f6d8042877cec486c53f
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Vratko Polak [Mon, 4 Jul 2016 13:33:22 +0000 (15:33 +0200)]
Bug 2332: BindingMapping to camel split also on forward slash
This is only a partial workaround, full fix for Bug 2332 needs binding v2.
Forward slash is a first character (not allowed in general yang identifiers)
that was encountered in enums from real world Yang models.
Possibly, other separators could get the same treatment,
acting the same way as dash and dot already do.
Change-Id: Ic62198a843747092113c1c7dffaff13d09e7f943
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Juraj Veverka [Wed, 20 Jul 2016 12:22:38 +0000 (14:22 +0200)]
implemented missing equals for InstanceIdentifierBuilderImpl with tests
Change-Id: I540a3f44f964de4c3f44281fb51d9a1404313ff7
Signed-off-by: Juraj Veverka <Juraj.Veverka@pantheon.tech>
Robert Varga [Wed, 27 Jul 2016 22:26:10 +0000 (00:26 +0200)]
Use TypedSchemaNode
Now that the getType() method is available through a unified
interface use it to simplify type checks.
Change-Id: I9538c3677daf4ac4e3eac080220403bf2f75adb8
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 27 Jul 2016 20:40:23 +0000 (22:40 +0200)]
Remove an unneeded type specifier
Optional.of() can be correctly inferred with Java 8,
remove the type argument.
Change-Id: Ie0826c03c964bb1bdfd7a070fa1bf80cef2ac3f0
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 27 Jul 2016 20:26:34 +0000 (22:26 +0200)]
Remove unneeded cast
Since we have corrected the getSchema() method, there is no need
to perform a cast.
Change-Id: Ib3c9b2d7dc3a15f2cb9e042055178106f6b33cae
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 27 Jul 2016 20:29:18 +0000 (22:29 +0200)]
Fix incorrect null check
Eliminate an Eclipse-generated warning, which actually shows a bug.
Calls to childNonNull() did not pass an actual instance, but rather
a 'obj != null' expression. That expression got evaluated to
a boolean, which got boxed. Hence childNonNull() could not observe
a null no matter what and we'd get a NPE on next use -- exactly where
Eclipse put a warning.
childNonNull() returns a correctly annotatad @Nonnull reference,
which can be used as a guard against this kind of mistake: if the
original code used that reference, compilation would fail,
as the checked object is a Boolean and does not have a get() method.
This patch eliminates the expression and uses the returned reference,
eliminating the possiblity of a NPE.
Change-Id: I706f077f90ea38d3a48125beeaf4711182c8b8d5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 21 Jul 2016 09:11:42 +0000 (11:11 +0200)]
Use direct type checks
With the removal of old parser and ExtendedType each type
definition implements proper subtype, hence we do not have
to traverse the type tree up to root.
Change-Id: Ib7a6ffa5f221278547e27e37b19c14a1a3c26d8a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 27 Jul 2016 23:20:16 +0000 (01:20 +0200)]
Reuse model.util.EnumPairImpl
Instead of brewing our own, use a well-known implementation.
Change-Id: I22769eb63ca7d7ac7e5f9ac22b201282b0f5283b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ryan Goulding [Fri, 22 Jul 2016 11:11:39 +0000 (07:11 -0400)]
BUG-865: make EnumPair getQName/getSchemaPath unimplemented
A yangtools change was made to get rid of these functions using
JDK8's default statement:
https://git.opendaylight.org/gerrit/#/c/41994/
This cleans up the mdsal test implementation.
Change-Id: Ib30d15848402fbe2afe016540d39bea5d4c13112
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Filip Gregor [Tue, 26 Jul 2016 11:16:20 +0000 (13:16 +0200)]
import fix in binding v2
minor import fix of annotation.
Change-Id: I3043a9cbf1601516423de03be0531eff96c56bf8
Signed-off-by: Filip Gregor <fgregor@cisco.com>
Vaclav Demcak [Thu, 21 Jul 2016 11:49:47 +0000 (13:49 +0200)]
Remove mdsal-singleton-dom-api
We are using only DOM implementation so extra DOM API is not needed.
* delete mdsal-singleton-dom-api module
* clean artifacts/pom.xml
* clean features/pom.xml
* clean features.xml
* clean singleton-service/pom.xml
* clean mdsal-singleton-dom-impl/pom.xml
inpact for controller patch:
https://git.opendaylight.org/gerrit/#/c/42093/2
fix is here:
depends on - https://git.opendaylight.org/gerrit/#/c/42311/
blocks - https://git.opendaylight.org/gerrit/#/c/42317/
Change-Id: I8ece69ec65c3ed574160ef8a1c8cd27476f8d1f2
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Robert Varga [Fri, 22 Jul 2016 09:27:35 +0000 (11:27 +0200)]
Add better messages to getTypeWithSchema()
This will aid debugging issues.
Change-Id: Ic1562e092a073ee2066172efbebd2ca9a64fa9b4
Signed-off-by: Robert Varga <rovarga@cisco.com>
Vaclav Demcak [Wed, 20 Jul 2016 20:42:15 +0000 (22:42 +0200)]
Fix outstanding issuess after moving code base
Move code base from mdsal-singleton-common-spi needs
repackaging and fix some small issues.
* repackaging org.opendaylight.mdsal.singleton.common.spi
to org.opendaylight.mdsal.singleton.dom.impl
* remove unecessary code
Change-Id: I89f45d17f198dbbc98a21464fb9c4bd3690a3255
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Michael Vorburger [Thu, 21 Jul 2016 01:33:13 +0000 (03:33 +0200)]
Fix NoSuchMethodError in Eclipse IDE by removing M2E lifecycle mapping
This is no longer required with
https://github.com/vorburger/opendaylight-eclipse-setup
This FIXES Execution check-license of goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check failed: An
API incompatibility was encountered while executing
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check:
java.lang.NoSuchMethodError:
org.slf4j.spi.LocationAwareLogger.log(Lorg/slf4j/Marker;Ljava/lang/String;ILjava/lang/String;Ljava/lang/Throwable;)V
Change-Id: I6cbe65013a50e2178b7fda99701e02cd40880d62
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Tom Pantelis [Wed, 20 Jul 2016 06:53:48 +0000 (02:53 -0400)]
Add blueprint XML for the binding EntityOwnershipService
Change-Id: I4349f0f87d9fcc436ddca59e3dc111d16428a6f8
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Peter Nosal [Wed, 20 Jul 2016 12:22:52 +0000 (14:22 +0200)]
Bug 5947: Increasing code coverage - binding-generator
Change-Id: I7d89a0bb9950776712b57bf6aad0a3425d531c73
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Vaclav Demcak [Wed, 20 Jul 2016 20:12:53 +0000 (22:12 +0200)]
Move and clean mdsal-singleton-common-spi
We don't need extra project for common-spi implemntation
for yet, because Binding implementation is not relevant
anymor. So common-spi content could be moved to dom-impl
project and mdsal-singleton-common-spi could be removed.
* move mdsal-singleton-common-spi content to mdsal-singleton-dom-impl project
* remove mdsal-singleton-common-spi
* clean feature.xml + feature/pom.xml
* clean artifacts pom.xml
* clean singleton-service/pom.xml
* clean mdsal-singleton-dom-impl/pom.xml
Change-Id: I979ecebe0bbbcd6dba5bec40aef0f287e7fe5fff
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Robert Varga [Thu, 21 Jul 2016 09:08:41 +0000 (11:08 +0200)]
Use lambda for Codec.loader()s
Removes a bit of boiler-plate code.
Change-Id: Id0c7c8d16d374133d9439cd72587382e31252b80
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 21 Jul 2016 09:07:47 +0000 (11:07 +0200)]
Fix checkstyle errors
'if(' -> 'if ('
Change-Id: I4747befcf35724bc1f99346e0ae8ab3ee5b30254
Signed-off-by: Robert Varga <rovarga@cisco.com>
Vaclav Demcak [Wed, 20 Jul 2016 20:00:48 +0000 (22:00 +0200)]
Remove ClusterSingletonBinding
We would like to use DOMClusterSingletonServiceProvider only,
so we have to remove Binding CSS instances.
* remove mdsal-singleton-binding-api project
* remove mdsal-singleton-binding-impl project
* clean features.xml + features/pom.xml
* clean artefacts pom.xml
* clean singleton-service/pom.xml
Change-Id: If4cdd968210d950dc66f4835e2ae14c25cfab7cc
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Michael Vorburger [Thu, 21 Jul 2016 01:39:34 +0000 (03:39 +0200)]
Checkstyle clean-up src/test/java
Required to be able to run (enforce) CS on src/test as well.
Change-Id: Ife78f9baf1fcb462d15ca59675e4116903048c6b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Ryan Goulding [Tue, 19 Jul 2016 18:12:45 +0000 (14:12 -0400)]
Fix compiler error due to removal of InMemoryDataTreeFactory.create
Change-Id: I047117f1a0c234eb6d2bc5cb9a553a8c0c2d742b
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Robert Varga [Tue, 19 Jul 2016 17:08:01 +0000 (19:08 +0200)]
BUG-6022: retain order of constituent types
In order to safely iterate over the types, we need
to retain their order from the SchemaNode. Use
a LinkedHashSet to achieve that.
Change-Id: I850f823a0b67dc9bc3e6b75f9a1c671e4bbf73d9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Jan Medved [Wed, 20 Jul 2016 04:54:00 +0000 (21:54 -0700)]
Edited the MD-SAL singleton common API adoc.
Change-Id: I9debe462a3f773fb12547357197f2c84243badbb
Signed-off-by: Jan Medved <jmedved@cisco.com>
Tom Pantelis [Tue, 19 Jul 2016 01:28:05 +0000 (21:28 -0400)]
Add blueprint XML for mdsal-singleton-dom-impl
Added a blueprint XML file to instantiate and advertise the
DOMClusterSingletonServiceProviderImpl instance.
Change-Id: I768aae041b5a33d37c21505c7debab77e7dd9c1a
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Robert Varga [Tue, 19 Jul 2016 14:58:25 +0000 (16:58 +0200)]
Add union deserialization debugs
We seem to be hitting the slow instantiation path for some
reason. Add more debugging in an effort to hunt them down.
Change-Id: I64c5630a819d46710f7957c3972a2ba305b21ac7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 19 Jul 2016 15:27:26 +0000 (17:27 +0200)]
BUG-6022: fix for yangtools api changing
Structure of deviations has changed, adjust to it.
Change-Id: Ic64e489bc6cb6c11435c5b71cf590cb8a4518f66
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tom Pantelis [Mon, 18 Jul 2016 20:00:03 +0000 (16:00 -0400)]
Export impl package from mdsal-singleton-dom-impl
We need to explictly export the org.opendaylight.mdsal.singleton.dom.impl
package via maven-bundle-plugin as packages with 'impl' are
automatically excluded.
Change-Id: I6cb644eee7dc68725adc97a3ea1665c7ef5d486c
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Vaclav Demcak [Thu, 14 Apr 2016 09:32:29 +0000 (11:32 +0200)]
Bug 5421 - Single cluster-wide service instances implementation
* add Abstract ClusterSingletonServiceProvider implementation
* add DOM & biniding ClusterSingletonServiceProvider impl.
* add junit test suite + import Mockito
Change-Id: If5bac3f61cc3164da1e09c2caf6713c1e3da658a
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Michael Vorburger [Tue, 12 Jul 2016 23:45:08 +0000 (01:45 +0200)]
Remove project local Xtend dependencyManagement and Maven plugin
Because we now have this available in odl-parent. Note that the
configuration there is slightly different and uses
target/generated-source instead of src. Therefore the clean is no
longer needed. Also add-source does not seem to be required; I've found
that the Xtend Maven plugin and the Xtend IDE M2E support already cover
this correctly by themselves.
Change-Id: Ic878b7c3d63c06595e61c42f0b729bf3d50861cf
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Wed, 8 Jun 2016 16:31:40 +0000 (18:31 +0200)]
BUG-6028: iterate over component types to instantiate union
This reworks union instantiation to be on par with
https://tools.ietf.org/html/rfc6020#section-9.12. We iterate
over individual members and attempt to run deserialization.
If it succeeds instantiate the union using cached constructor
specifying that member. This side-steps the need to go through
serialization.
Change-Id: Ieec37da37a05c2b2a2f432778232e136c903f654
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Vaclav Demcak [Thu, 14 Apr 2016 09:32:29 +0000 (11:32 +0200)]
Bug 5421 - Single cluster-wide service instances grouping
ClusterSingletonService grouping means to run all registred service to same
Group on same ClusterNode. So we could say, service goup will always run on
same ClusterNode.
* implement grouping functionality for ClusterSingletonService instancies
* implement double candidate funct. for handling ClusterSingletonService
service group instances
* add junit test suite + import Mockito
Change-Id: If91a6f1bf786c42c32201899bc0bb826729f0585
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Tomas Cere [Wed, 29 Jun 2016 11:55:11 +0000 (13:55 +0200)]
Add blueprint wiring for ShardedDOMDataTree
Change-Id: I03e5d82332dd8dddf5bf782ec1f965012ba305e1
Signed-off-by: Tomas Cere <tcere@cisco.com>
Tomas Cere [Wed, 29 Jun 2016 11:54:32 +0000 (13:54 +0200)]
Expose executor related settings for InMemoryDOMDataTreeShard
Change-Id: I4e3673ccbfc6ce14914994ca52f3a97052b8a48a
Signed-off-by: Tomas Cere <tcere@cisco.com>
Tomas Cere [Wed, 22 Jun 2016 09:24:37 +0000 (11:24 +0200)]
Bug 4202: Require that a producer has claimed a namespace on shard registration
Change-Id: Ia8f75b64e50cad876512e3818a919a6215b296b1
Signed-off-by: Tomas Cere <tcere@cisco.com>
Isaku Yamahata [Wed, 13 Jul 2016 00:04:41 +0000 (17:04 -0700)]
Bug 6112 - UnionTypeCodec fails to non-identityref value
When Non-identityref value is deserialized, ClassCastException exception occurs.
catch the exception and move to the next codec.
> java.lang.ClassCastException: java.lang.Short cannot be cast to org.opendaylight.yangtools.yang.common.QName
> at org.opendaylight.yangtools.binding.data.codec.impl.IdentityCodec.deserialize(IdentityCodec.java:17)
> at org.opendaylight.yangtools.binding.data.codec.impl.UnionTypeCodec.deserialize(UnionTypeCodec.java:103)
> at org.opendaylight.yangtools.binding.data.codec.impl.LeafNodeCodecContext.deserializeObject(LeafNodeCodecContext.java:199)
> at org.opendaylight.yangtools.binding.data.codec.impl.DataObjectCodecContext.getBindingChildValue(DataObjectCodecContext.java:328)
> at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.getBindingData(LazyDataObject.java:148)
> at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.invoke(LazyDataObject.java:71)
> at com.sun.proxy.$Proxy3.getValue(Unknown Source)
> at org.opendaylight.yangtools.binding.data.codec.test.UnionTypeWithIdentityrefTest.bug6112Test(UnionTypeWithIdentityrefTest.java:78)
Change-Id: If6d9bffbc8cecaca2894f889940c814919da6a4b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Tom Pantelis [Wed, 6 Jul 2016 15:41:09 +0000 (11:41 -0400)]
Reference BindingNormalizedNodeSerializer in BindingDOMEntityOwnershipServiceAdapter
Changed the BindingDOMEntityOwnershipServiceAdapter to reference the
BindingNormalizedNodeSerializer interface instead of the concrete
mdsal BindingToNormalizedNodeCodec class. This allows us to wire in the
controller's1 BindingToNormalizedNodeCodec instance that is currently in
use (once https://git.opendaylight.org/gerrit/#/c/41811/ and
https://git.opendaylight.org/gerrit/#/c/41815/ are merged).
Change-Id: Ia2767857c111f1ca99efd18f993762f2a48958f3
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>
Peter Nosal [Wed, 13 Jul 2016 10:32:49 +0000 (12:32 +0200)]
Bug 5947: Increasing code coverage - binding-dom-adapter
Change-Id: I9dd1322938bb528378dd224487caac2f6c21404c
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Vaclav Demcak [Thu, 14 Apr 2016 09:32:29 +0000 (11:32 +0200)]
Bug 5421 - Single cluster-wide service API
ClusterSingletonServices provides a functionality which alowe to have only
one fully instantiated service instance in a cluster at one time.
* Cluster Singleton API contract definitions
* adoc for ClusterSingletonService implementation
Change-Id: I89180c0a6b6427d6cb1087457aaf2978b8544dda
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Lorand Jakab [Fri, 24 Jun 2016 01:41:50 +0000 (04:41 +0300)]
Bug 6102: Upgrade ietf-{inet,yang}-types to 2013-07-15
Change-Id: I696d1c394c423814dce500b3d698383c1813c06a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
Peter Nosal [Wed, 6 Jul 2016 13:08:57 +0000 (15:08 +0200)]
Bug 5947: Increasing code coverage - yang util
Change-Id: I7e2cc7590952e3de444e50f172fb4c68a84041dd
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Ryan Goulding [Wed, 6 Jul 2016 19:26:19 +0000 (15:26 -0400)]
Bug 5151 Java binding missing @return
Adds @return functionality to interface accessors. The idea is to generate a
meaningful return label so that we don't get warnings during compilation for
missing return statements. A test is added to verify that the return statement
is formatted appropriately.
Change-Id: I01875b788622cab002653a03ea2d844d2c954b77
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Vaclav Demcak [Fri, 8 Jul 2016 12:35:09 +0000 (14:35 +0200)]
Rename Binding Eos DOM Adapter package name
* rename package in mdsal-eos-binding-adapter from
org.opendaylight.mdsal.binding.dom.adapter.clustering to
org.opendaylight.mdsal.eos.binding.dom.adapter
Change-Id: Ic944f3cd42110095b72cce4ed1e3f4d072a62174
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Vaclav Demcak [Fri, 8 Jul 2016 12:33:35 +0000 (14:33 +0200)]
Renam Binding Eos API package name
* rename package in mdsal-eos-binding-api from
org.opendaylight.mdsal.binding.api.clustering to
org.opendaylight.mdsal.eos.binding.api
Change-Id: I7722187cd62b1d632cd4c07b1ac69d09ff34ad3f
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Vaclav Demcak [Fri, 8 Jul 2016 12:32:04 +0000 (14:32 +0200)]
Rename DOM Eos package name
* rename package in mdsal-eos-dom-api from org.opendaylight.mdsal.dom.api.clustering
to org.opendaylight.mdsal.eos.dom.api
Change-Id: I59a0fcfbb8b5aac0c28af596bf57e5778487b2f3
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Vaclav Demcak [Fri, 8 Jul 2016 12:30:38 +0000 (14:30 +0200)]
Rename EosCommonSpi package name
* rename package from org.opendaylight.mdsal.common.api.clustering
to org.opendaylight.mdsal.eos.common.spi
Change-Id: Ic5c67f9575265a56a7a04e6787ca0ba33aa37ba3
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Vaclav Demcak [Fri, 8 Jul 2016 12:28:55 +0000 (14:28 +0200)]
Rename package in EosCommonApi
* rename package from org.opendaylight.mdsal.common.api.clustering
to org.opendaylight.mdsal.eos.common.api
Change-Id: Ic97ceb1c81881dc23e29cca4c32b7c69d095b363
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Vaclav Demcak [Fri, 8 Jul 2016 10:40:18 +0000 (12:40 +0200)]
Move Adapter for Binding EntityOwnershipService
Adapter for Binding EntityOwnershipService API is moved to spearate module.
* split mdsal-binding-adapter for MD-SAL Binding core API and EOS
* add new module
* clean mdsal-binding-adapter pom
Change-Id: Id417c30b3667d2a8d0c0a80c9120a152ecadf397
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Vaclav Demcak [Fri, 8 Jul 2016 10:26:05 +0000 (12:26 +0200)]
Move Binding EntityOwnershipService
Binding EntityOwnershipService API is moved to spearate module.
* split mdsal-binding-api for MD-SAL Binding core API and EOS
* clean mdsal-binding-api pom
Change-Id: I30eb448932630bdc28f9230eb05b1a3aa7642c8d
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Vaclav Demcak [Fri, 8 Jul 2016 09:59:08 +0000 (11:59 +0200)]
Move DOM EntityOwnershipService
DOM EntityOwnershipService API is moved to spearate module.
* split mdsal-dom-api for MD-SAL DOM core API and EOS
* clean mdsal-dom-api pom file
Change-Id: I1ff7d6704b8f9f5fb7a9f2973e63f59eb54e02b6
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Vaclav Demcak [Fri, 8 Jul 2016 08:19:19 +0000 (10:19 +0200)]
Move and split EntityOwnershipService common-api
Common EOS API contracts describle Generic API parents for
DOM and Binding implementations. Core APIs have to contain
Generic definitions. EOS SPI contains Abstract implementations
a common logic for DOM/Binding functionality.
* split mdsal-common-api for MD-SAL core API and EOS
* split EOS to API and SPI projects
* add new artifacts definitions
* remove ExceptionTest
Change-Id: Iebad27cd651bfb19e2194128d0393055adacfe5f
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Vaclav Demcak [Fri, 8 Jul 2016 06:57:16 +0000 (08:57 +0200)]
EntityOwnershipService new module infrastructure
EntityOwnershipService is not a core part of MD-SAL API,
so we have to split core API and EOS API/SPI.
New EOS structure is:
- mdsal-eos-common-api
- mdsal-eos-common-spi
- mdsal-eos-dom-api
- mdsal-eos-binding-api
- mdsal-eos-binding-adapter
* create EntityOwnershipService module infra with relevant
dependencies
Change-Id: I8509765de87a2e924ccbc988f400173152f772b9
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Martin Ciglan [Fri, 13 May 2016 08:21:19 +0000 (10:21 +0200)]
Bug 1411-2: MDSAL Binding2 Generator API
- generator API
- model API
- review comments implemented/typos fixed
Change-Id: I38da58355bb76637c9e7e3abb8e70b405535af25
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
Tomas Cere [Thu, 2 Jun 2016 15:19:49 +0000 (17:19 +0200)]
BUG 6057: Rewrite ShardedDOMProducer to use new cursor api
Change ShardedDOMProducer, ShardedDOMDataTreeWriteTransaction to use
cursor api's.
Make the user facing cursor implementation enforce claimed subtrees.
Add binding adapters for the DOM cursor api's.
Change-Id: I21fa6533b8ce7da0e5cc864569f6f143a273ae86
Signed-off-by: Tomas Cere <tcere@cisco.com>
Robert Varga [Mon, 6 Jun 2016 17:29:59 +0000 (19:29 +0200)]
BUG-865: eliminate references to ExtendedType and base types
These are no longer emitted from YANG parser, eliminate references
obvious references to them.
Change-Id: Ia89278098108da2356252dfc5bf47fddbe732198
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ryan Goulding [Wed, 6 Jul 2016 15:56:11 +0000 (11:56 -0400)]
Fix a typo in the ClassTemplate API
Just fixes a typo in the ClassTemplate xtend template.
Change-Id: Ia9c888c29a7a929cfcb574d0d7fa9ac75f34926a
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Peter Nosal [Mon, 27 Jun 2016 08:20:50 +0000 (10:20 +0200)]
Bug 5947: Increasing code coverage - ietf-type-util
Change-Id: I37f82d3a2dd0bde934ad49a1f13c526828f103cb
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Peter Nosal [Sat, 25 Jun 2016 16:45:54 +0000 (18:45 +0200)]
Bug 5947: Increasing code coverage - mdsal-dom-spi
Change-Id: Idcc5ba3ea102576d593a824fffbb32567177fdba
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Peter Nosal [Sat, 25 Jun 2016 20:14:05 +0000 (22:14 +0200)]
Bug 5947: Increasing code coverage - mdsal-common-api
Change-Id: I3dd94a2d2ff0e28daff7a6efc7d01074d26939e5
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Robert Varga [Wed, 22 Jun 2016 13:22:36 +0000 (15:22 +0200)]
BUG-865: remove use of Uint16, Int16 and StringType
These have been accumulated into BaseTypes, use them from there.
Change-Id: I92c65780165e2966249cc28a71903b4493e71bf8
Signed-off-by: Robert Varga <rovarga@cisco.com>
Peter Nosal [Mon, 27 Jun 2016 08:50:59 +0000 (10:50 +0200)]
fixed assertion error in ShardedDOMDataWriteTransactionTest
getIdentifier() method returns String (as a name) and counter in form
of incremented Atomic long in every new instantiation. Before this
change test exactly expected to have an 0 and then 1 at counter side,
but if some other test create an instance of
ShardedDOMDataWriteTransaction before this test, counter will alredy be
greater than 0 so presumably that is what happend and test is order
dependant. I removed this dependency and now test is checking for
non-equality of two differend object identifiers, so does not matter
what is at counter side at beggining of this test.
Change-Id: I65401ea99bc7d8d94e4ef1fc9b52a1b9909f63fe
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Peter Nosal [Tue, 21 Jun 2016 09:50:00 +0000 (11:50 +0200)]
Bug 5947: Increasing code coverage - mdsal-dom-spi
Change-Id: Iac268bc99a5e48c083f6a67e7287a506d9431fb0
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Vaclav Demcak [Mon, 20 Jun 2016 13:09:18 +0000 (15:09 +0200)]
Bug 5421 - Add new Eos instancies classes
- implementation missing components for start MD-SAL DOMEos
OSGi services in controller
Change-Id: I90823003be5556bab6acd326ee40004cff30e1fe
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Robert Varga [Wed, 22 Jun 2016 12:47:42 +0000 (14:47 +0200)]
Remove reference to URLSchemaContextResolver
YangTextSchemaContextResolver is the replacement, use that.
Change-Id: I4a07f3be33306028f50176792d2f5ad979ec7756
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ryan Goulding [Thu, 2 Jun 2016 18:01:19 +0000 (14:01 -0400)]
Bug 2872: Generated Java Enumerations should contain mapping to the string counter part
Changes the Enumeration API to expose the "getMappedName()" accessor, which exposes
the name that is used for the Java mapped enum name. The EnumTemplate.xtend template
was modified in the following way:
1) A field was added to track the "raw" enum name, the one parsed from the YANG file.
2) The constructor was modified to accept the raw enum name as a parameter, and store
the parameter value in the name instance variable.
3) An accessor was added called "getName()", which exposes the name instance variable.
A corresponding change in yangtools changes the EnumEffectiveStatementImpl.getName()
definition to expose the "raw" name attribute parsed from the yang file:
https://git.opendaylight.org/gerrit/#/c/39733/
Change-Id: If248039a2b10958ff563ee0799d7b13284570b3c
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Filip Gregor [Thu, 16 Jun 2016 12:02:19 +0000 (14:02 +0200)]
LazyDataObject bindingEquals fix
added check for byte arrays
Change-Id: I238d92bc7a23ac0157ff66046e5d137d6e10582e
Signed-off-by: Filip Gregor <fgregor@cisco.com>
Peter Nosal [Tue, 14 Jun 2016 12:20:15 +0000 (14:20 +0200)]
Bug 5947: Increasing code coverage - mdsal-dom-inmemory-datastore
Change-Id: Iff715d9114e8e746d9b53302e8446b3dc9102434
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Robert Varga [Tue, 14 Jun 2016 23:01:23 +0000 (01:01 +0200)]
BUG-865: Use QName.intern()
cachedReference() does the same thing, less efficiently.
Change-Id: I0a9732323769f2efcf3ae5e0e44e8b0dba76831a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 8 Jun 2016 12:21:42 +0000 (14:21 +0200)]
Optimize BitsCodec
The codec was not using methodhandles and performed reflective
invocation. Fix that, amortizing invocation cost.
Change-Id: Ibe7b41b81ab248bfe0221083feb4c0bcd24cee4d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 8 Jun 2016 11:59:17 +0000 (13:59 +0200)]
Optimize UnionTypeCodec
For some reason this codec was not using MethodHandle#invokeExact()
for instantiation. Fix this and remove static fields holding public
lookups.
Change-Id: I8b170ec850aa8182cbe8bf81a0fbbef796aad741
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 8 Jun 2016 17:05:56 +0000 (19:05 +0200)]
Enforce non-null class
Also hide the field and expose a getter.
Change-Id: Ic998b2726be93bf173525bdb6a394e438e3e330c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 6 Jun 2016 22:34:55 +0000 (00:34 +0200)]
Remove reference to UnionType
Since the old parser has been removed, this codepath will never
trigger. Remove reference to UnionType, so it can be removed, too.
Change-Id: I10a779d3bea717dbf33043eb2880240ab18bb1c0
Signed-off-by: Robert Varga <rovarga@cisco.com>
Peter Nosal [Fri, 10 Jun 2016 12:44:50 +0000 (14:44 +0200)]
Bug 5947: Increasing code coverage - mdsal-dom-inmemory-datastore
Change-Id: Ib308df2b14a14b53f77fbe839556f426ab77109f
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Filip Gregor [Mon, 13 Jun 2016 11:09:55 +0000 (13:09 +0200)]
MDSAL clean-up
Follow usual naming conventions and
refactor utility class RetestUtils.
Change-Id: I655af10d6a90196ee16c9fe060279ea8cf57782c
Signed-off-by: Filip Gregor <fgregor@cisco.com>
Robert Varga [Thu, 9 Jun 2016 08:49:19 +0000 (10:49 +0200)]
BUG-865: remove reference to SchemaAwareNormalizedNodeStreamWriter
All functionality has been integrated ito NormalizedNodeStreamWriter, hence
the two subclasses are no longer needed. Remove reference to the old type
so it can be removed.
Change-Id: I0e0ef84279b5504bb18bcf164ae3a5091fa04582
Signed-off-by: Robert Varga <rovarga@cisco.com>
Peter Nosal [Tue, 14 Jun 2016 05:56:55 +0000 (07:56 +0200)]
Removed LeafSchemaNodeBuilder from TypeProviderImplTest
Change-Id: I49a2dded44fabb8704652f111ea301e6db8607dc
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Robert Varga [Fri, 10 Jun 2016 11:30:22 +0000 (13:30 +0200)]
BUG-865: do not use ModuleBuilder
ModuleBuilder is going away, use mockito instead.
Change-Id: Ifb6cf12126f51f176acb0ca4024567e9e49c3d07
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Peter Nosal [Mon, 13 Jun 2016 08:45:15 +0000 (10:45 +0200)]
mdsal-dom-broker test fix
Change-Id: I3e8b37b6c19b20182dd4e2f67994795217c532b5
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Peter Nosal [Thu, 9 Jun 2016 13:45:33 +0000 (15:45 +0200)]
Bug 5947: Increasing code coverage - mdsal-dom-inmemory-datastore
Change-Id: I7e764751b95d79fd538ea421f5ba24c7155ee312
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Robert Varga [Mon, 6 Jun 2016 22:33:09 +0000 (00:33 +0200)]
Remove use of old yang parser's Comparators
Comparators has been deprecated. Move the single comparator here
and remove the import.
Change-Id: Ida7c12ef5bc81e418144c75c595b5291b395a16d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Martin Ciglan [Thu, 9 Jun 2016 08:48:49 +0000 (10:48 +0200)]
Basic DOCS infrastructure for documentation:
- analysis - various analysis docs, useful for better understanding
- design - mostly new functionalities documented
- model - provide YANG if necesary for better description
- prototype - functional skeletons to decribe/code features, relations
- docs - finished docs like manuals or guides
Change-Id: I41666d8ffe4282c7f5d7f60f53e21956a9d14e53
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
Isaku Yamahata [Thu, 2 Jun 2016 00:40:34 +0000 (17:40 -0700)]
Bug 6006 - UnionTypeCodec fails to handle indentityref
UnionTypeCodec doesn't know that identityref requires special handling
because the actual derived identityref classes are determined at runtime.
Change-Id: I817190a380f0325b0bb8ee6f13a7d94cffc29113
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Aswin Suryanarayanan [Wed, 25 May 2016 15:45:55 +0000 (21:15 +0530)]
Ietf yang for access control list and the dependent yang are added.
Change-Id: Ibaf4d71da09da1c854df7a32409f7f47a67e5fe9
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Peter Nosal [Fri, 20 May 2016 10:14:57 +0000 (12:14 +0200)]
Bug 5947: Increasing code coverage - mdsal-dom-broker
Change-Id: I83683f9a7ac835d118e7e4a3e8446f5f593221e4
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Robert Varga [Wed, 1 Jun 2016 14:47:47 +0000 (16:47 +0200)]
Cleanup code
Unused imports, static methods, missing generics.
Change-Id: I11ec7de37c5f57a5e0c5f28ae7a51b060012df59
Signed-off-by: Robert Varga <rovarga@cisco.com>
Peter Nosal [Fri, 20 May 2016 10:14:57 +0000 (12:14 +0200)]
Bug 5947: Increasing code coverage for mdsal project
- increasing coverage for module mdsal-dom
Change-Id: I768341d7a9eded8fb080de3b0d40e2b9e9f44b35
Signed-off-by: Peter Nosal <peter.nosal@pantheon.tech>
Tomas Cere [Thu, 2 Jun 2016 09:11:45 +0000 (11:11 +0200)]
BUG 5979 - enforce cursors are closed on transaction submit
Properly close foreign transactions on close().
Add checks that prevent creation of new cursor's while there is another one open.
Change-Id: I21ad7ce809b1fbbf21ad1e72337267155330e9ad
Signed-off-by: Tomas Cere <tcere@cisco.com>
Robert Varga [Sat, 28 May 2016 10:17:22 +0000 (12:17 +0200)]
BUG-5970: do not add value to union hashCode/equals/toString
The value of a union is derived from its members and should not
be part of general Object methods, as the members are already
part of these methods.
Also override definition for getValue() and generate alternate
code to lazily fill _value. The output could use some visual
improvement, but that is something for another day.
It also fixes the copy constructor so it does not clone the
_value field unnecessarily.
Change-Id: Ibbbce99e1e84a0dfa55f70872fedad78e57e8f1e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Martin Ciglan [Tue, 31 May 2016 07:32:57 +0000 (09:32 +0200)]
Get rid of old Yang Parser
1. Make sure there is no YangParserImpl occurence in MD-SAL
2. Bit of clean-up
Change-Id: Id86e2017d28693887faa90b62b183c9407a2c05c
Signed-off-by: Martin Ciglan <mciglan@cisco.com>