*/
package ntfbenchmark.impl;
+import static com.google.common.base.Verify.verifyNotNull;
+
import com.google.common.util.concurrent.ListenableFuture;
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
import java.util.concurrent.TimeUnit;
-import org.opendaylight.controller.md.sal.binding.api.NotificationPublishService;
-import org.opendaylight.controller.md.sal.binding.api.NotificationService;
+import org.opendaylight.mdsal.binding.api.NotificationPublishService;
+import org.opendaylight.mdsal.binding.api.NotificationService;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ntfbenchmark.rev150105.NtfbenchmarkService;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ntfbenchmark.rev150105.StartTestInput;
import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ntfbenchmark.rev150105.StartTestInput.ProducerType;
import org.slf4j.LoggerFactory;
public class NtfbenchmarkProvider implements AutoCloseable, NtfbenchmarkService {
-
private static final Logger LOG = LoggerFactory.getLogger(NtfbenchmarkProvider.class);
+ private static final int TEST_TIMEOUT = 5;
+
private final NotificationService listenService;
private final NotificationPublishService publishService;
- private static final int testTimeout = 5;
public NtfbenchmarkProvider(final NotificationService listenServiceDependency,
final NotificationPublishService publishServiceDependency) {
final long startTime = System.nanoTime();
for (int i = 0; i < input.getProducers().intValue(); i++) {
- executor.submit(producers.get(i));
+ // FIXME: fools RV_RETURN_VALUE_IGNORED_BAD_PRACTICE for now, but we should check some more
+ verifyNotNull(executor.submit(producers.get(i)));
}
executor.shutdown();
try {
- executor.awaitTermination(testTimeout, TimeUnit.MINUTES);
+ executor.awaitTermination(TEST_TIMEOUT, TimeUnit.MINUTES);
for (ListenerRegistration<NtfbenchTestListener> listenerRegistration : listeners) {
listenerRegistration.getInstance().getAllDone().get();
}
} catch (final InterruptedException | ExecutionException e) {
- LOG.error("Out of time: test did not finish within the {} min deadline ", testTimeout);
+ LOG.error("Out of time: test did not finish within the {} min deadline ", TEST_TIMEOUT);
}
final long producerEndTime = System.nanoTime();
allListeners += listenerRegistration.getInstance().getReceived();
}
- final long listenerEndTime = System.nanoTime();
final long listenerElapsedTime = producerEndTime - startTime;
LOG.info("Test Done");