Fix CS warnings in blueprint and enable enforcement

[controller.git] / opendaylight / blueprint / src / main / java / org / opendaylight / controller / blueprint / ext / RpcImplementationBean.java

diff --git a/opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/RpcImplementationBean.java b/opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/RpcImplementationBean.java
index 1ab78db9cd5e862b8b99384af0a61d02b7677312..3144328c99566fa1da6fe158d841a8aef0f060a7 100644 (file)
--- a/opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/RpcImplementationBean.java
+++ b/opendaylight/blueprint/src/main/java/org/opendaylight/controller/blueprint/ext/RpcImplementationBean.java
@@ -51,6 +51,7 @@ public class RpcImplementationBean {
         this.implementation = implementation;
     }
 
+    @SuppressWarnings("checkstyle:IllegalCatch")
     public void init() {
         try {
             List<Class<RpcService>> rpcInterfaces = getImplementedRpcServiceInterfaces(interfaceName,
@@ -59,19 +60,19 @@ public class RpcImplementationBean {
             LOG.debug("{}: init - adding implementation {} for RpcService interface(s) {}", bundle.getSymbolicName(),
                     implementation, rpcInterfaces);
 
-            for(Class<RpcService> rpcInterface: rpcInterfaces) {
+            for (Class<RpcService> rpcInterface : rpcInterfaces) {
                 rpcRegistrations.add(rpcRegistry.addRpcImplementation(rpcInterface, implementation));
             }
-        } catch(ComponentDefinitionException e) {
+        } catch (ComponentDefinitionException e) {
             throw e;
-        } catch(Exception e) {
+        } catch (Exception e) {
             throw new ComponentDefinitionException(String.format(
                     "Error processing \"%s\" for %s", RPC_IMPLEMENTATION, implementation.getClass()), e);
         }
     }
 
     public void destroy() {
-        for(RpcRegistration<RpcService> reg: rpcRegistrations) {
+        for (RpcRegistration<RpcService> reg: rpcRegistrations) {
             reg.close();
         }
     }
@@ -79,10 +80,10 @@ public class RpcImplementationBean {
     @SuppressWarnings("unchecked")
     static List<Class<RpcService>> getImplementedRpcServiceInterfaces(String interfaceName,
             Class<?> implementationClass, Bundle bundle, String logName) throws ClassNotFoundException {
-        if(!Strings.isNullOrEmpty(interfaceName)) {
+        if (!Strings.isNullOrEmpty(interfaceName)) {
             Class<?> rpcInterface = bundle.loadClass(interfaceName);
 
-            if(!rpcInterface.isAssignableFrom(implementationClass)) {
+            if (!rpcInterface.isAssignableFrom(implementationClass)) {
                 throw new ComponentDefinitionException(String.format(
                         "The specified \"interface\" %s for \"%s\" is not implemented by RpcService \"ref\" %s",
                         interfaceName, logName, implementationClass));
@@ -92,13 +93,13 @@ public class RpcImplementationBean {
         }
 
         List<Class<RpcService>> rpcInterfaces = new ArrayList<>();
-        for(Class<?> intface: implementationClass.getInterfaces()) {
-            if(RpcService.class.isAssignableFrom(intface)) {
+        for (Class<?> intface : implementationClass.getInterfaces()) {
+            if (RpcService.class.isAssignableFrom(intface)) {
                 rpcInterfaces.add((Class<RpcService>) intface);
             }
         }
 
-        if(rpcInterfaces.isEmpty()) {
+        if (rpcInterfaces.isEmpty()) {
             throw new ComponentDefinitionException(String.format(
                     "The \"ref\" instance %s for \"%s\" does not implemented any RpcService interfaces",
                     implementationClass, logName));