Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Remove unnecessary casts
[controller.git]
/
opendaylight
/
commons
/
liblldp
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
liblldp
/
BitBufferHelper.java
diff --git
a/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/BitBufferHelper.java
b/opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/BitBufferHelper.java
index fc515e109d1abebf95168f081ef289612648dda8..c1d2beff3e4ba84a6d0f2d4ddf730511e2483235 100644
(file)
--- a/
opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/BitBufferHelper.java
+++ b/
opendaylight/commons/liblldp/src/main/java/org/opendaylight/controller/liblldp/BitBufferHelper.java
@@
-103,7
+103,7
@@
public abstract class BitBufferHelper {
logger.error("", e);
}
}
logger.error("", e);
}
}
- return
(long)
toNumber(data);
+ return toNumber(data);
}
/**
}
/**
@@
-189,7
+189,7
@@
public abstract class BitBufferHelper {
} catch (BufferException e) {
logger.error("", e);
}
} catch (BufferException e) {
logger.error("", e);
}
- return
(long)
toNumber(bits, numBits);
+ return toNumber(bits, numBits);
}
/**
}
/**
@@
-238,7
+238,7
@@
public abstract class BitBufferHelper {
return bytes;
} else {
System.arraycopy(data, startByteOffset, bytes, 0, numBytes - 1);
return bytes;
} else {
System.arraycopy(data, startByteOffset, bytes, 0, numBytes - 1);
- bytes[numBytes - 1] = (byte) (
(int)
data[startByteOffset
+ bytes[numBytes - 1] = (byte) (data[startByteOffset
+ numBytes - 1] & getMSBMask(extranumBits));
}
} else {
+ numBytes - 1] & getMSBMask(extranumBits));
}
} else {
@@
-363,7
+363,7
@@
public abstract class BitBufferHelper {
value += 256;
}
ret = ret
value += 256;
}
ret = ret
- | (long)
((long) value << ((length - i - 1) * NetUtils.NumBitsInAByte)
);
+ | (long)
value << ((length - i - 1) * NetUtils.NumBitsInAByte
);
}
return ret;
}
}
return ret;
}
@@
-395,7
+395,7
@@
public abstract class BitBufferHelper {
value += 256;
}
ret = ret
value += 256;
}
ret = ret
- | (long)
((long) value << ((array.length - i - 1) * NetUtils.NumBitsInAByte)
);
+ | (long)
value << ((array.length - i - 1) * NetUtils.NumBitsInAByte
);
}
return ret;
}
return ret;