Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Cleanup equals() template
[controller.git]
/
opendaylight
/
config
/
yang-jmx-generator-plugin
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
config
/
yangjmxgenerator
/
plugin
/
ftl
/
TemplateFactory.java
diff --git
a/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/TemplateFactory.java
b/opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/TemplateFactory.java
index 4c67a67f42487d337c9ec8de0b42aa0562a93e2a..294520b36389992edb75af3e0121c7232728496d 100644
(file)
--- a/
opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/TemplateFactory.java
+++ b/
opendaylight/config/yang-jmx-generator-plugin/src/main/java/org/opendaylight/controller/config/yangjmxgenerator/plugin/ftl/TemplateFactory.java
@@
-83,7
+83,7
@@
public class TemplateFactory {
// convert JavaAttribute parameters into fields
List<Field> fields = new ArrayList<>();
for (JavaAttribute ja : rpc.getParameters()) {
// convert JavaAttribute parameters into fields
List<Field> fields = new ArrayList<>();
for (JavaAttribute ja : rpc.getParameters()) {
- Field field = new Field(Collections.
<String>
emptyList(),
+ Field field = new Field(Collections.emptyList(),
ja.getType().getFullyQualifiedName(),
ja.getLowerCaseCammelCase(), ja.getNullableDefaultWrappedForCode());
fields.add(field);
ja.getType().getFullyQualifiedName(),
ja.getLowerCaseCammelCase(), ja.getNullableDefaultWrappedForCode());
fields.add(field);
@@
-439,7
+439,7
@@
public class TemplateFactory {
" final %s that = (%s) o;\n", name, name));
for (AttributeIfc s : attrs.values()) {
equalsBodyBuilder.append(String.format(
" final %s that = (%s) o;\n", name, name));
for (AttributeIfc s : attrs.values()) {
equalsBodyBuilder.append(String.format(
- " if
(java.util.Objects.equals(%1$s, that.%1$s) == false
) {\n" +
+ " if
(!java.util.Objects.equals(%1$s, that.%1$s)
) {\n" +
" return false;\n" +
" }\n\n", s.getLowerCaseCammelCase()));
}
" return false;\n" +
" }\n\n", s.getLowerCaseCammelCase()));
}