Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Merge "Remove public from interface methods. Cleans sonar warnings."
[controller.git]
/
opendaylight
/
forwarding
/
staticrouting
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
forwarding
/
staticrouting
/
IForwardingStaticRouting.java
diff --git
a/opendaylight/forwarding/staticrouting/src/main/java/org/opendaylight/controller/forwarding/staticrouting/IForwardingStaticRouting.java
b/opendaylight/forwarding/staticrouting/src/main/java/org/opendaylight/controller/forwarding/staticrouting/IForwardingStaticRouting.java
index 9b9c0b0d812fa943a39e200a69c79eb72cb8d7a7..03d9453126d89c8c5d9074bc7ec7b643c089d9a3 100644
(file)
--- a/
opendaylight/forwarding/staticrouting/src/main/java/org/opendaylight/controller/forwarding/staticrouting/IForwardingStaticRouting.java
+++ b/
opendaylight/forwarding/staticrouting/src/main/java/org/opendaylight/controller/forwarding/staticrouting/IForwardingStaticRouting.java
@@
-12,12
+12,17
@@
package org.opendaylight.controller.forwarding.staticrouting;
import java.net.InetAddress;
import java.util.concurrent.ConcurrentMap;
/**
import java.net.InetAddress;
import java.util.concurrent.ConcurrentMap;
/**
- *
+ *
* This interface provides APIs to configure and manage static routes.
*
*/
import org.opendaylight.controller.sal.utils.Status;
* This interface provides APIs to configure and manage static routes.
*
*/
import org.opendaylight.controller.sal.utils.Status;
+/**
+ *
+ * This Interface provides APIs to manage and query the static routes
+ *
+ */
public interface IForwardingStaticRouting {
/**
public interface IForwardingStaticRouting {
/**
@@
-25,13
+30,13
@@
public interface IForwardingStaticRouting {
* @param ipAddress (InetAddress) the IP address
* @return StaticRoute
*/
* @param ipAddress (InetAddress) the IP address
* @return StaticRoute
*/
-
public
StaticRoute getBestMatchStaticRoute(InetAddress ipAddress);
+ StaticRoute getBestMatchStaticRoute(InetAddress ipAddress);
/**
* Returns all the StaticRouteConfig
* @return all the StaticRouteConfig
*/
/**
* Returns all the StaticRouteConfig
* @return all the StaticRouteConfig
*/
-
public
ConcurrentMap<String, StaticRouteConfig> getStaticRouteConfigs();
+ ConcurrentMap<String, StaticRouteConfig> getStaticRouteConfigs();
/**
* Adds a StaticRouteConfig
/**
* Adds a StaticRouteConfig
@@
-39,7
+44,7
@@
public interface IForwardingStaticRouting {
* @return a text string indicating the result of the operation..
* If the operation is successful, the return string will be "SUCCESS"
*/
* @return a text string indicating the result of the operation..
* If the operation is successful, the return string will be "SUCCESS"
*/
-
public
Status addStaticRoute(StaticRouteConfig config);
+ Status addStaticRoute(StaticRouteConfig config);
/**
* Removes the named StaticRouteConfig
/**
* Removes the named StaticRouteConfig
@@
-47,12
+52,5
@@
public interface IForwardingStaticRouting {
* @return a text string indicating the result of the operation.
* If the operation is successful, the return string will be "SUCCESS"
*/
* @return a text string indicating the result of the operation.
* If the operation is successful, the return string will be "SUCCESS"
*/
- public Status removeStaticRoute(String name);
-
- /**
- * Saves the config
- * @return a text string indicating the result of the operation.
- * If the operation is successful, the return string will be "Success"
- */
- Status saveConfig();
+ Status removeStaticRoute(String name);
}
}