import java.util.Collection;
import java.util.List;
import java.util.Optional;
+import java.util.OptionalLong;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
import java.util.concurrent.locks.Lock;
private static final long MAX_DELAY_NANOS = TimeUnit.SECONDS.toNanos(MAX_DELAY_SECONDS);
private final Lock lock = new ReentrantLock();
- private final ClientActorContext context;
- @GuardedBy("lock")
- private final TransmitQueue queue;
+ private final @NonNull ClientActorContext context;
private final @NonNull Long cookie;
private final String backendName;
+ @GuardedBy("lock")
+ private final TransmitQueue queue;
@GuardedBy("lock")
private boolean haveTimer;
// Private constructor to avoid code duplication.
private AbstractClientConnection(final AbstractClientConnection<T> oldConn, final TransmitQueue newQueue,
final String backendName) {
- this.context = requireNonNull(oldConn.context);
- this.cookie = requireNonNull(oldConn.cookie);
+ context = oldConn.context;
+ cookie = oldConn.cookie;
this.backendName = requireNonNull(backendName);
- this.queue = requireNonNull(newQueue);
+ queue = requireNonNull(newQueue);
// Will be updated in finishReplay if needed.
- this.lastReceivedTicks = oldConn.lastReceivedTicks;
+ lastReceivedTicks = oldConn.lastReceivedTicks;
}
// This constructor is only to be called by ConnectingClientConnection constructor.
this.context = requireNonNull(context);
this.cookie = requireNonNull(cookie);
this.backendName = requireNonNull(backendName);
- this.queue = new TransmitQueue.Halted(queueDepth);
- this.lastReceivedTicks = currentTime();
+ queue = new TransmitQueue.Halted(queueDepth);
+ lastReceivedTicks = currentTime();
}
// This constructor is only to be called (indirectly) by ReconnectingClientConnection constructor.
requireNonNull(oldConn.context).messageSlicer()), newBackend.getName());
}
- public final ClientActorContext context() {
+ public final @NonNull ClientActorContext context() {
return context;
}
return cookie;
}
- public final ActorRef localActor() {
+ public final @NonNull ActorRef localActor() {
return context.self();
}
*
* <p>
* Note that unlike {@link #sendRequest(Request, Consumer)}, this method does not exert backpressure, hence it
- * should never be called from an application thread.
+ * should never be called from an application thread and serves mostly for moving requests between queues.
*
* @param request Request to send
* @param callback Callback to invoke
// Requests are always scheduled in sequence, hence checking for timeout is relatively straightforward.
// Note we use also inquire about the delay, so we can re-schedule if needed, hence the unusual
// tri-state return convention.
- final Optional<Long> delay = lockedCheckTimeout(now);
+ final OptionalLong delay = lockedCheckTimeout(now);
if (delay == null) {
// We have timed out. There is no point in scheduling a timer
LOG.debug("{}: connection {} timed out", context.persistenceId(), this);
if (delay.isPresent()) {
// If there is new delay, schedule a timer
- scheduleTimer(delay.get());
+ scheduleTimer(delay.orElseThrow());
} else {
LOG.debug("{}: not scheduling timeout on {}", context.persistenceId(), this);
}
}
@VisibleForTesting
- final Optional<Long> checkTimeout(final long now) {
+ final OptionalLong checkTimeout(final long now) {
lock.lock();
try {
return lockedCheckTimeout(now);
@SuppressFBWarnings(value = "NP_OPTIONAL_RETURN_NULL",
justification = "Returning null Optional is documented in the API contract.")
@GuardedBy("lock")
- private Optional<Long> lockedCheckTimeout(final long now) {
+ private OptionalLong lockedCheckTimeout(final long now) {
if (queue.isEmpty()) {
LOG.debug("{}: connection {} is empty", context.persistenceId(), this);
- return Optional.empty();
+ return OptionalLong.empty();
}
final long backendSilentTicks = backendSilentTicks(now);
final long beenOpen = now - head.getEnqueuedTicks();
final long requestTimeout = context.config().getRequestTimeout();
if (beenOpen < requestTimeout) {
- return Optional.of(requestTimeout - beenOpen);
+ return OptionalLong.of(requestTimeout - beenOpen);
}
tasksTimedOut++;
queue.tryTransmit(now);
}
- return Optional.empty();
+ return OptionalLong.empty();
}
private void timeoutEntry(final ConnectionEntry entry, final long beenOpen) {
}
if (maybeEntry.isPresent()) {
- final TransmittedConnectionEntry entry = maybeEntry.get();
+ final TransmittedConnectionEntry entry = maybeEntry.orElseThrow();
LOG.debug("Completing {} with {}", entry, envelope);
entry.complete(envelope.getMessage());
}
Code Review / controller.git / blobdiff