import akka.persistence.SnapshotSelectionCriteria;
import com.google.common.annotations.VisibleForTesting;
import java.util.List;
+import org.opendaylight.controller.cluster.raft.base.messages.ApplySnapshot;
import org.opendaylight.controller.cluster.raft.base.messages.CaptureSnapshot;
import org.opendaylight.controller.cluster.raft.base.messages.SendInstallSnapshot;
+import org.opendaylight.controller.cluster.raft.base.messages.SnapshotComplete;
import org.opendaylight.controller.cluster.raft.behaviors.RaftActorBehavior;
import org.slf4j.Logger;
private Procedure<Void> createSnapshotProcedure;
- private Snapshot applySnapshot;
+ private ApplySnapshot applySnapshot;
private Procedure<byte[]> applySnapshotProcedure;
public SnapshotManager(RaftActorContext context, Logger logger) {
this.LOG = logger;
}
+ public boolean isApplying() {
+ return applySnapshot != null;
+ }
+
@Override
public boolean isCapturing() {
return currentState.isCapturing();
}
@Override
- public void apply(Snapshot snapshot) {
+ public void apply(ApplySnapshot snapshot) {
currentState.apply(snapshot);
}
}
private boolean hasFollowers(){
- return context.getPeerAddresses().keySet().size() > 0;
+ return context.hasFollowers();
}
private String persistenceId(){
return context.getId();
}
+ public CaptureSnapshot newCaptureSnapshot(ReplicatedLogEntry lastLogEntry, long replicatedToAllIndex,
+ boolean installSnapshotInitiated) {
+ TermInformationReader lastAppliedTermInfoReader =
+ lastAppliedTermInformationReader.init(context.getReplicatedLog(), context.getLastApplied(),
+ lastLogEntry, hasFollowers());
+
+ long lastAppliedIndex = lastAppliedTermInfoReader.getIndex();
+ long lastAppliedTerm = lastAppliedTermInfoReader.getTerm();
+
+ TermInformationReader replicatedToAllTermInfoReader =
+ replicatedToAllTermInformationReader.init(context.getReplicatedLog(), replicatedToAllIndex);
+
+ long newReplicatedToAllIndex = replicatedToAllTermInfoReader.getIndex();
+ long newReplicatedToAllTerm = replicatedToAllTermInfoReader.getTerm();
+
+ List<ReplicatedLogEntry> unAppliedEntries = context.getReplicatedLog().getFrom(lastAppliedIndex + 1);
+
+ long lastLogEntryIndex = lastAppliedIndex;
+ long lastLogEntryTerm = lastAppliedTerm;
+ if(lastLogEntry != null) {
+ lastLogEntryIndex = lastLogEntry.getIndex();
+ lastLogEntryTerm = lastLogEntry.getTerm();
+ } else {
+ LOG.debug("Capturing Snapshot : lastLogEntry is null. Using lastAppliedIndex {} and lastAppliedTerm {} instead.",
+ lastAppliedIndex, lastAppliedTerm);
+ }
+
+ return new CaptureSnapshot(lastLogEntryIndex, lastLogEntryTerm, lastAppliedIndex, lastAppliedTerm,
+ newReplicatedToAllIndex, newReplicatedToAllTerm, unAppliedEntries, installSnapshotInitiated);
+ }
+
private class AbstractSnapshotState implements SnapshotState {
@Override
public boolean isCapturing() {
- return false;
+ return true;
}
@Override
}
@Override
- public void apply(Snapshot snapshot) {
+ public void apply(ApplySnapshot snapshot) {
LOG.debug("apply should not be called in state {}", this);
}
private class Idle extends AbstractSnapshotState {
- private boolean capture(ReplicatedLogEntry lastLogEntry, long replicatedToAllIndex, String targetFollower) {
- TermInformationReader lastAppliedTermInfoReader =
- lastAppliedTermInformationReader.init(context.getReplicatedLog(), context.getLastApplied(),
- lastLogEntry, hasFollowers());
-
- long lastAppliedIndex = lastAppliedTermInfoReader.getIndex();
- long lastAppliedTerm = lastAppliedTermInfoReader.getTerm();
-
- TermInformationReader replicatedToAllTermInfoReader =
- replicatedToAllTermInformationReader.init(context.getReplicatedLog(), replicatedToAllIndex);
-
- long newReplicatedToAllIndex = replicatedToAllTermInfoReader.getIndex();
- long newReplicatedToAllTerm = replicatedToAllTermInfoReader.getTerm();
-
- // send a CaptureSnapshot to self to make the expensive operation async.
-
- List<ReplicatedLogEntry> unAppliedEntries = context.getReplicatedLog().getFrom(lastAppliedIndex + 1);
+ @Override
+ public boolean isCapturing() {
+ return false;
+ }
- captureSnapshot = new CaptureSnapshot(lastLogEntry.getIndex(),
- lastLogEntry.getTerm(), lastAppliedIndex, lastAppliedTerm,
- newReplicatedToAllIndex, newReplicatedToAllTerm, unAppliedEntries, targetFollower != null);
+ private boolean capture(ReplicatedLogEntry lastLogEntry, long replicatedToAllIndex, String targetFollower) {
+ captureSnapshot = newCaptureSnapshot(lastLogEntry, replicatedToAllIndex, targetFollower != null);
if(captureSnapshot.isInstallSnapshotInitiated()) {
LOG.info("{}: Initiating snapshot capture {} to install on {}",
}
@Override
- public void apply(Snapshot snapshot) {
- applySnapshot = snapshot;
+ public void apply(ApplySnapshot applySnapshot) {
+ SnapshotManager.this.applySnapshot = applySnapshot;
lastSequenceNumber = context.getPersistenceProvider().getLastSequenceNumber();
LOG.debug("lastSequenceNumber prior to persisting applied snapshot: {}", lastSequenceNumber);
- context.getPersistenceProvider().saveSnapshot(snapshot);
+ context.getPersistenceProvider().saveSnapshot(applySnapshot.getSnapshot());
SnapshotManager.this.currentState = PERSISTING;
}
private class Creating extends AbstractSnapshotState {
- @Override
- public boolean isCapturing() {
- return true;
- }
-
@Override
public void persist(byte[] snapshotBytes, RaftActorBehavior currentBehavior, long totalMemory) {
// create a snapshot object from the state provided and save it
Snapshot snapshot = Snapshot.create(snapshotBytes,
captureSnapshot.getUnAppliedEntries(),
captureSnapshot.getLastIndex(), captureSnapshot.getLastTerm(),
- captureSnapshot.getLastAppliedIndex(), captureSnapshot.getLastAppliedTerm());
+ captureSnapshot.getLastAppliedIndex(), captureSnapshot.getLastAppliedTerm(),
+ context.getTermInformation().getCurrentTerm(),
+ context.getTermInformation().getVotedFor(), context.getPeerServerInfo());
context.getPersistenceProvider().saveSnapshot(snapshot);
- LOG.info("{}: Persisting of snapshot done:{}", persistenceId(), snapshot.getLogMessage());
+ LOG.info("{}: Persisting of snapshot done: {}", persistenceId(), snapshot);
long dataThreshold = totalMemory *
context.getConfigParams().getSnapshotDataThresholdPercentage() / 100;
- if (context.getReplicatedLog().dataSize() > dataThreshold) {
+ boolean dataSizeThresholdExceeded = context.getReplicatedLog().dataSize() > dataThreshold;
+ boolean logSizeExceededSnapshotBatchCount =
+ context.getReplicatedLog().size() >= context.getConfigParams().getSnapshotBatchCount();
+
+ if (dataSizeThresholdExceeded || logSizeExceededSnapshotBatchCount) {
if(LOG.isDebugEnabled()) {
- LOG.debug("{}: dataSize {} exceeds dataThreshold {} - doing snapshotPreCommit with index {}",
- persistenceId(), context.getReplicatedLog().dataSize(), dataThreshold,
- captureSnapshot.getLastAppliedIndex());
+ if(dataSizeThresholdExceeded) {
+ LOG.debug("{}: log data size {} exceeds the memory threshold {} - doing snapshotPreCommit with index {}",
+ context.getId(), context.getReplicatedLog().dataSize(), dataThreshold,
+ captureSnapshot.getLastAppliedIndex());
+ } else {
+ LOG.debug("{}: log size {} exceeds the snapshot batch count {} - doing snapshotPreCommit with index {}",
+ context.getId(), context.getReplicatedLog().size(),
+ context.getConfigParams().getSnapshotBatchCount(), captureSnapshot.getLastAppliedIndex());
+ }
}
- // if memory is less, clear the log based on lastApplied.
- // this could/should only happen if one of the followers is down
- // as normally we keep removing from the log when its replicated to all.
+ // We either exceeded the memory threshold or the log size exceeded the snapshot batch
+ // count so, to keep the log memory footprint in check, clear the log based on lastApplied.
+ // This could/should only happen if one of the followers is down as normally we keep
+ // removing from the log as entries are replicated to all.
context.getReplicatedLog().snapshotPreCommit(captureSnapshot.getLastAppliedIndex(),
captureSnapshot.getLastAppliedTerm());
context.getReplicatedLog().getSnapshotTerm());
}
- LOG.info("{}: Removed in-memory snapshotted entries, adjusted snaphsotIndex:{} " +
- "and term:{}", persistenceId(), captureSnapshot.getLastAppliedIndex(),
- captureSnapshot.getLastAppliedTerm());
+ LOG.info("{}: Removed in-memory snapshotted entries, adjusted snaphsotIndex: {} " +
+ "and term: {}", context.getId(), context.getReplicatedLog().getSnapshotIndex(),
+ context.getReplicatedLog().getSnapshotTerm());
if (context.getId().equals(currentBehavior.getLeaderId())
&& captureSnapshot.isInstallSnapshotInitiated()) {
@Override
public void commit(long sequenceNumber, RaftActorBehavior currentBehavior) {
- LOG.debug("Snapshot success sequence number:", sequenceNumber);
+ LOG.debug("Snapshot success sequence number: {}", sequenceNumber);
if(applySnapshot != null) {
try {
- applySnapshotProcedure.apply(applySnapshot.getState());
+ Snapshot snapshot = applySnapshot.getSnapshot();
//clears the followers log, sets the snapshot index to ensure adjusted-index works
- context.setReplicatedLog(ReplicatedLogImpl.newInstance(applySnapshot, context, currentBehavior));
- context.setLastApplied(applySnapshot.getLastAppliedIndex());
- context.setCommitIndex(applySnapshot.getLastAppliedIndex());
+ context.setReplicatedLog(ReplicatedLogImpl.newInstance(snapshot, context, currentBehavior));
+ context.setLastApplied(snapshot.getLastAppliedIndex());
+ context.setCommitIndex(snapshot.getLastAppliedIndex());
+ context.getTermInformation().update(snapshot.getElectionTerm(), snapshot.getElectionVotedFor());
+
+ if(snapshot.getState().length > 0 ) {
+ applySnapshotProcedure.apply(snapshot.getState());
+ }
+
+ applySnapshot.getCallback().onSuccess();
} catch (Exception e) {
LOG.error("Error applying snapshot", e);
}
context.getPersistenceProvider().deleteMessages(lastSequenceNumber);
- lastSequenceNumber = -1;
- applySnapshot = null;
- SnapshotManager.this.currentState = IDLE;
+ snapshotComplete();
}
@Override
context.getReplicatedLog().getSnapshotIndex(),
context.getReplicatedLog().getSnapshotTerm(),
context.getReplicatedLog().size());
+ } else {
+ applySnapshot.getCallback().onFailure();
}
+ snapshotComplete();
+ }
+
+ private void snapshotComplete() {
lastSequenceNumber = -1;
applySnapshot = null;
SnapshotManager.this.currentState = IDLE;
+
+ context.getActor().tell(SnapshotComplete.INSTANCE, context.getActor());
}
@Override
Code Review / controller.git / blobdiff