import org.opendaylight.controller.cluster.raft.RaftActorContext;
import org.opendaylight.controller.cluster.raft.RaftState;
import org.opendaylight.controller.cluster.raft.ReplicatedLogEntry;
-import org.opendaylight.controller.cluster.raft.internal.messages.ApplyState;
-import org.opendaylight.controller.cluster.raft.internal.messages.ElectionTimeout;
+import org.opendaylight.controller.cluster.raft.SerializationUtils;
+import org.opendaylight.controller.cluster.raft.base.messages.ApplyState;
+import org.opendaylight.controller.cluster.raft.base.messages.ElectionTimeout;
import org.opendaylight.controller.cluster.raft.messages.AppendEntries;
import org.opendaylight.controller.cluster.raft.messages.AppendEntriesReply;
-import org.opendaylight.controller.cluster.raft.messages.RaftRPC;
import org.opendaylight.controller.cluster.raft.messages.RequestVote;
import org.opendaylight.controller.cluster.raft.messages.RequestVoteReply;
import scala.concurrent.duration.FiniteDuration;
*/
protected final RaftActorContext context;
- /**
- * The maximum election time variance
- */
- private static final int ELECTION_TIME_MAX_VARIANCE = 100;
-
- /**
- * The interval at which a heart beat message will be sent to the remote
- * RaftActor
- * <p/>
- * Since this is set to 100 milliseconds the Election timeout should be
- * at least 200 milliseconds
- */
- protected static final FiniteDuration HEART_BEAT_INTERVAL =
- new FiniteDuration(100, TimeUnit.MILLISECONDS);
-
- /**
- * The interval in which a new election would get triggered if no leader is found
- */
- private static final long ELECTION_TIME_INTERVAL =
- HEART_BEAT_INTERVAL.toMillis() * 2;
-
/**
*
*/
*
* @param sender The actor that sent this message
* @param appendEntries The AppendEntries message
- * @param suggestedState The state that the RaftActor should be in based
- * on the base class's processing of the AppendEntries
- * message
* @return
*/
protected abstract RaftState handleAppendEntries(ActorRef sender,
- AppendEntries appendEntries, RaftState suggestedState);
+ AppendEntries appendEntries);
/**
*
* @param sender
* @param appendEntries
- * @param raftState
* @return
*/
protected RaftState appendEntries(ActorRef sender,
- AppendEntries appendEntries, RaftState raftState) {
-
- if (raftState != state()) {
- context.getLogger().debug("Suggested state is " + raftState
- + " current behavior state is " + state());
- }
+ AppendEntries appendEntries) {
// 1. Reply false if term < currentTerm (§5.1)
if (appendEntries.getTerm() < currentTerm()) {
}
- return handleAppendEntries(sender, appendEntries, raftState);
+ return handleAppendEntries(sender, appendEntries);
}
/**
*
* @param sender The actor that sent this message
* @param appendEntriesReply The AppendEntriesReply message
- * @param suggestedState The state that the RaftActor should be in based
- * on the base class's processing of the
- * AppendEntriesReply message
* @return
*/
protected abstract RaftState handleAppendEntriesReply(ActorRef sender,
- AppendEntriesReply appendEntriesReply, RaftState suggestedState);
+ AppendEntriesReply appendEntriesReply);
/**
* requestVote handles the RequestVote message. This logic is common
*
* @param sender
* @param requestVote
- * @param suggestedState
* @return
*/
protected RaftState requestVote(ActorRef sender,
- RequestVote requestVote, RaftState suggestedState) {
+ RequestVote requestVote) {
+
+
+ context.getLogger().debug(requestVote.toString());
boolean grantVote = false;
if (candidateLatest) {
grantVote = true;
- context.getTermInformation().update(requestVote.getTerm(),
+ context.getTermInformation().updateAndPersist(requestVote.getTerm(),
requestVote.getCandidateId());
}
}
sender.tell(new RequestVoteReply(currentTerm(), grantVote), actor());
- return suggestedState;
+ return state();
}
/**
*
* @param sender The actor that sent this message
* @param requestVoteReply The RequestVoteReply message
- * @param suggestedState The state that the RaftActor should be in based
- * on the base class's processing of the RequestVote
- * message
* @return
*/
protected abstract RaftState handleRequestVoteReply(ActorRef sender,
- RequestVoteReply requestVoteReply, RaftState suggestedState);
+ RequestVoteReply requestVoteReply);
/**
* Creates a random election duration
* @return
*/
protected FiniteDuration electionDuration() {
- long variance = new Random().nextInt(ELECTION_TIME_MAX_VARIANCE);
- return new FiniteDuration(ELECTION_TIME_INTERVAL + variance,
- TimeUnit.MILLISECONDS);
+ long variance = new Random().nextInt(context.getConfigParams().getElectionTimeVariance());
+ return context.getConfigParams().getElectionTimeOutInterval().$plus(
+ new FiniteDuration(variance, TimeUnit.MILLISECONDS));
}
/**
*
* @param index a log index that is known to be committed
*/
- protected void applyLogToStateMachine(long index) {
+ protected void applyLogToStateMachine(final long index) {
// Now maybe we apply to the state machine
for (long i = context.getLastApplied() + 1;
i < index + 1; i++) {
}
// Send a local message to the local RaftActor (it's derived class to be
// specific to apply the log to it's index)
+ context.getLogger().debug("Setting last applied to {}", index);
context.setLastApplied(index);
}
+ protected Object fromSerializableMessage(Object serializable){
+ return SerializationUtils.fromSerializable(serializable);
+ }
+
@Override
public RaftState handleMessage(ActorRef sender, Object message) {
- RaftState raftState = state();
- if (message instanceof RaftRPC) {
- raftState = applyTerm((RaftRPC) message);
- }
if (message instanceof AppendEntries) {
- raftState = appendEntries(sender, (AppendEntries) message,
- raftState);
+ return appendEntries(sender, (AppendEntries) message);
} else if (message instanceof AppendEntriesReply) {
- raftState =
- handleAppendEntriesReply(sender, (AppendEntriesReply) message,
- raftState);
+ return handleAppendEntriesReply(sender, (AppendEntriesReply) message);
} else if (message instanceof RequestVote) {
- raftState =
- requestVote(sender, (RequestVote) message, raftState);
+ return requestVote(sender, (RequestVote) message);
} else if (message instanceof RequestVoteReply) {
- raftState =
- handleRequestVoteReply(sender, (RequestVoteReply) message,
- raftState);
+ return handleRequestVoteReply(sender, (RequestVoteReply) message);
}
- return raftState;
+ return state();
}
@Override public String getLeaderId() {
return leaderId;
}
-
- private RaftState applyTerm(RaftRPC rpc) {
- // If RPC request or response contains term T > currentTerm:
- // set currentTerm = T, convert to follower (§5.1)
- // This applies to all RPC messages and responses
- if (rpc.getTerm() > context.getTermInformation().getCurrentTerm()) {
- context.getTermInformation().update(rpc.getTerm(), null);
- return RaftState.Follower;
- }
- return state();
- }
-
}
Code Review / controller.git / blobdiff