*/
package org.opendaylight.controller.cluster.raft.behaviors;
+import static java.util.Objects.requireNonNull;
+
import akka.actor.ActorRef;
import akka.actor.ActorSelection;
import com.google.common.annotations.VisibleForTesting;
-import com.google.common.base.Preconditions;
import com.google.common.base.Stopwatch;
+import java.util.Optional;
import java.util.concurrent.TimeUnit;
-import javax.annotation.Nonnull;
-import javax.annotation.Nullable;
+import org.eclipse.jdt.annotation.NonNull;
+import org.eclipse.jdt.annotation.Nullable;
import org.opendaylight.controller.cluster.raft.FollowerLogInformation;
import org.opendaylight.controller.cluster.raft.RaftActorContext;
import org.opendaylight.controller.cluster.raft.RaftActorLeadershipTransferCohort;
/**
* The behavior of a RaftActor when it is in the Leader state.
- * <p/>
+ *
+ * <p>
* Leaders:
* <ul>
* <li> Upon election: send initial empty AppendEntries RPCs
* follower (§5.3)
* <li> If AppendEntries fails because of log inconsistency:
* decrement nextIndex and retry (§5.3)
- * <li> If there exists an N such that N > commitIndex, a majority
+ * <li> If there exists an N such that N > commitIndex, a majority
* of matchIndex[i] ≥ N, and log[N].term == currentTerm:
* set commitIndex = N (§5.3, §5.4).
* </ul>
static final Object ISOLATED_LEADER_CHECK = new Object();
private final Stopwatch isolatedLeaderCheck = Stopwatch.createStarted();
- @Nullable private LeadershipTransferContext leadershipTransferContext;
+ private @Nullable LeadershipTransferContext leadershipTransferContext;
- Leader(RaftActorContext context, @Nullable AbstractLeader initializeFromLeader) {
+ Leader(final RaftActorContext context, @Nullable final AbstractLeader initializeFromLeader) {
super(context, RaftState.Leader, initializeFromLeader);
}
- public Leader(RaftActorContext context) {
+ public Leader(final RaftActorContext context) {
this(context, null);
}
@Override
- public RaftActorBehavior handleMessage(ActorRef sender, Object originalMessage) {
- Preconditions.checkNotNull(sender, "sender should not be null");
+ public RaftActorBehavior handleMessage(final ActorRef sender, final Object originalMessage) {
+ requireNonNull(sender, "sender should not be null");
if (ISOLATED_LEADER_CHECK.equals(originalMessage)) {
if (isLeaderIsolated()) {
}
@Override
- protected RaftActorBehavior handleAppendEntriesReply(ActorRef sender, AppendEntriesReply appendEntriesReply) {
+ protected RaftActorBehavior handleAppendEntriesReply(final ActorRef sender,
+ final AppendEntriesReply appendEntriesReply) {
RaftActorBehavior returnBehavior = super.handleAppendEntriesReply(sender, appendEntriesReply);
tryToCompleteLeadershipTransfer(appendEntriesReply.getFollowerId());
return returnBehavior;
* <li>Start a timer (Stopwatch).</li>
* <li>Send an initial AppendEntries heartbeat to all followers.</li>
* <li>On AppendEntriesReply, check if the follower's new match Index matches the leader's last index</li>
- * <li>If it matches, </li>
+ * <li>If it matches,
* <ul>
* <li>Send an additional AppendEntries to ensure the follower has applied all its log entries to its state.</li>
* <li>Send an ElectionTimeout to the follower to immediately start an election.</li>
* <li>Notify {@link RaftActorLeadershipTransferCohort#transferComplete}.</li>
- * </ul>
+ * </ul></li>
* <li>Otherwise if the election time out period elapses, notify
- * {@link RaftActorLeadershipTransferCohort#abortTtransfer}.</li>
+ * {@link RaftActorLeadershipTransferCohort#abortTransfer}.</li>
* </ul>
*
* @param leadershipTransferCohort the cohort participating in the leadership transfer
*/
- public void transferLeadership(@Nonnull RaftActorLeadershipTransferCohort leadershipTransferCohort) {
+ public void transferLeadership(@NonNull final RaftActorLeadershipTransferCohort leadershipTransferCohort) {
log.debug("{}: Attempting to transfer leadership", logName());
leadershipTransferContext = new LeadershipTransferContext(leadershipTransferCohort);
sendAppendEntries(0, false);
}
- private void tryToCompleteLeadershipTransfer(String followerId) {
+ private void tryToCompleteLeadershipTransfer(final String followerId) {
if (leadershipTransferContext == null) {
return;
}
+ final Optional<String> requestedFollowerIdOptional
+ = leadershipTransferContext.transferCohort.getRequestedFollowerId();
+ if (requestedFollowerIdOptional.isPresent() && !requestedFollowerIdOptional.get().equals(followerId)) {
+ // we want to transfer leadership to specific follower
+ return;
+ }
+
FollowerLogInformation followerInfo = getFollower(followerId);
if (followerInfo == null) {
return;
}
@VisibleForTesting
- void markFollowerActive(String followerId) {
+ void markFollowerActive(final String followerId) {
getFollower(followerId).markFollowerActive();
}
@VisibleForTesting
- void markFollowerInActive(String followerId) {
+ void markFollowerInActive(final String followerId) {
getFollower(followerId).markFollowerInActive();
}
RaftActorLeadershipTransferCohort transferCohort;
Stopwatch timer = Stopwatch.createStarted();
- LeadershipTransferContext(RaftActorLeadershipTransferCohort transferCohort) {
+ LeadershipTransferContext(final RaftActorLeadershipTransferCohort transferCohort) {
this.transferCohort = transferCohort;
}
- boolean isExpired(long timeout) {
+ boolean isExpired(final long timeout) {
if (timer.elapsed(TimeUnit.MILLISECONDS) >= timeout) {
transferCohort.abortTransfer();
return true;