String performance and maintenability

[controller.git] / opendaylight / md-sal / sal-akka-raft / src / main / java / org / opendaylight / controller / cluster / raft / messages / InstallSnapshotReply.java

diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshotReply.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshotReply.java
index 41d2ae68c90e8e2f3846d6c3806693843f2b091c..bbee5c4175e800d71f689db9310b77b03b4cdf9c 100644 (file)
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshotReply.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshotReply.java
@@ -43,10 +43,10 @@ public class InstallSnapshotReply extends AbstractRaftRPC {
 
     @Override
     public String toString() {
-        StringBuilder builder = new StringBuilder();
-        builder.append("InstallSnapshotReply [term=").append(getTerm()).append(", followerId=").append(followerId)
-                .append(", chunkIndex=").append(chunkIndex).append(", success=").append(success).append("]");
-        return builder.toString();
+        return "InstallSnapshotReply [term=" + getTerm()
+                + ", followerId=" + followerId
+                + ", chunkIndex=" + chunkIndex
+                + ", success=" + success + "]";
     }
 
     private Object writeReplace() {
@@ -58,6 +58,9 @@ public class InstallSnapshotReply extends AbstractRaftRPC {
 
         private InstallSnapshotReply installSnapshotReply;
 
+        // checkstyle flags the public modifier as redundant which really doesn't make sense since it clearly isn't
+        // redundant. It is explicitly needed for Java serialization to be able to create instances via reflection.
+        @SuppressWarnings("checkstyle:RedundantModifier")
         public Proxy() {
         }