String performance and maintenability

[controller.git] / opendaylight / md-sal / sal-akka-raft / src / main / java / org / opendaylight / controller / cluster / raft / messages / InstallSnapshotReply.java

diff --git a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshotReply.java b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshotReply.java
index 77efa53dfd9c627ff3b585e67471f21a47cce123..bbee5c4175e800d71f689db9310b77b03b4cdf9c 100644 (file)
--- a/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshotReply.java
+++ b/opendaylight/md-sal/sal-akka-raft/src/main/java/org/opendaylight/controller/cluster/raft/messages/InstallSnapshotReply.java
@@ -8,6 +8,11 @@
 
 package org.opendaylight.controller.cluster.raft.messages;
 
+import java.io.Externalizable;
+import java.io.IOException;
+import java.io.ObjectInput;
+import java.io.ObjectOutput;
+
 public class InstallSnapshotReply extends AbstractRaftRPC {
     private static final long serialVersionUID = 642227896390779503L;
 
@@ -17,8 +22,7 @@ public class InstallSnapshotReply extends AbstractRaftRPC {
     private final int chunkIndex;
     private final boolean success;
 
-    public InstallSnapshotReply(long term, String followerId, int chunkIndex,
-        boolean success) {
+    public InstallSnapshotReply(long term, String followerId, int chunkIndex, boolean success) {
         super(term);
         this.followerId = followerId;
         this.chunkIndex = chunkIndex;
@@ -39,9 +43,51 @@ public class InstallSnapshotReply extends AbstractRaftRPC {
 
     @Override
     public String toString() {
-        StringBuilder builder = new StringBuilder();
-        builder.append("InstallSnapshotReply [term=").append(term).append(", followerId=").append(followerId)
-                .append(", chunkIndex=").append(chunkIndex).append(", success=").append(success).append("]");
-        return builder.toString();
+        return "InstallSnapshotReply [term=" + getTerm()
+                + ", followerId=" + followerId
+                + ", chunkIndex=" + chunkIndex
+                + ", success=" + success + "]";
+    }
+
+    private Object writeReplace() {
+        return new Proxy(this);
+    }
+
+    private static class Proxy implements Externalizable {
+        private static final long serialVersionUID = 1L;
+
+        private InstallSnapshotReply installSnapshotReply;
+
+        // checkstyle flags the public modifier as redundant which really doesn't make sense since it clearly isn't
+        // redundant. It is explicitly needed for Java serialization to be able to create instances via reflection.
+        @SuppressWarnings("checkstyle:RedundantModifier")
+        public Proxy() {
+        }
+
+        Proxy(InstallSnapshotReply installSnapshotReply) {
+            this.installSnapshotReply = installSnapshotReply;
+        }
+
+        @Override
+        public void writeExternal(ObjectOutput out) throws IOException {
+            out.writeLong(installSnapshotReply.getTerm());
+            out.writeObject(installSnapshotReply.followerId);
+            out.writeInt(installSnapshotReply.chunkIndex);
+            out.writeBoolean(installSnapshotReply.success);
+        }
+
+        @Override
+        public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
+            long term = in.readLong();
+            String followerId = (String) in.readObject();
+            int chunkIndex = in.readInt();
+            boolean success = in.readBoolean();
+
+            installSnapshotReply = new InstallSnapshotReply(term, followerId, chunkIndex, success);
+        }
+
+        private Object readResolve() {
+            return installSnapshotReply;
+        }
     }
 }