package org.opendaylight.controller.cluster.raft;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
import static org.mockito.Matchers.any;
import static org.mockito.Matchers.anyInt;
import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import akka.japi.Procedure;
import akka.persistence.SnapshotMetadata;
import akka.persistence.SnapshotOffer;
import akka.persistence.SnapshotSelectionCriteria;
+import com.google.common.collect.Sets;
import java.util.Arrays;
import java.util.Collections;
-import java.util.HashMap;
-import java.util.Map;
import org.hamcrest.Description;
import org.junit.Before;
import org.junit.Test;
import org.mockito.MockitoAnnotations;
import org.opendaylight.controller.cluster.DataPersistenceProvider;
import org.opendaylight.controller.cluster.PersistentDataProvider;
+import org.opendaylight.controller.cluster.raft.ServerConfigurationPayload.ServerInfo;
import org.opendaylight.controller.cluster.raft.base.messages.ApplyJournalEntries;
import org.opendaylight.controller.cluster.raft.base.messages.ApplyLogEntries;
import org.opendaylight.controller.cluster.raft.base.messages.DeleteEntries;
import org.opendaylight.controller.cluster.raft.base.messages.UpdateElectionTerm;
import org.opendaylight.controller.cluster.raft.behaviors.RaftActorBehavior;
-import org.opendaylight.controller.cluster.raft.ServerConfigurationPayload.ServerInfo;
+import org.opendaylight.controller.cluster.raft.protobuff.client.messages.Payload;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
private RaftActorContext context;
private final DefaultConfigParamsImpl configParams = new DefaultConfigParamsImpl();
+ private final String localId = "leader";
@Before
public void setup() {
MockitoAnnotations.initMocks(this);
- context = new RaftActorContextImpl(null, null, "test", new ElectionTermImpl(mockPersistentProvider, "test", LOG),
+ context = new RaftActorContextImpl(null, null, localId, new ElectionTermImpl(mockPersistentProvider, "test", LOG),
-1, -1, Collections.<String,String>emptyMap(), configParams, mockPersistence, LOG);
support = new RaftActorRecoverySupport(context, mockBehavior , mockCohort);
assertEquals("Snapshot index", lastAppliedDuringSnapshotCapture, context.getReplicatedLog().getSnapshotIndex());
assertEquals("Election term", electionTerm, context.getTermInformation().getCurrentTerm());
assertEquals("Election votedFor", electionVotedFor, context.getTermInformation().getVotedFor());
+ assertFalse("Dynamic server configuration", context.isDynamicServerConfigurationInUse());
verify(mockCohort).applyRecoverySnapshot(snapshotBytes);
}
}
inOrder.verify(mockCohort).applyCurrentLogRecoveryBatch();
-
+ inOrder.verify(mockCohort).getRestoreFromSnapshot();
inOrder.verifyNoMoreInteractions();
}
public void testOnRecoveryCompletedWithNoRemainingBatch() {
sendMessageToSupport(RecoveryCompleted.getInstance(), true);
+ verify(mockCohort).getRestoreFromSnapshot();
verifyNoMoreInteractions(mockCohort);
}
sendMessageToSupport(RecoveryCompleted.getInstance(), true);
+ verify(mockCohort).getRestoreFromSnapshot();
verifyNoMoreInteractions(mockCohort);
verify(mockPersistentProvider).deleteMessages(10L);
sendMessageToSupport(RecoveryCompleted.getInstance(), true);
+ verify(mockCohort).getRestoreFromSnapshot();
verifyNoMoreInteractions(mockCohort, mockPersistentProvider);
}
@Test
- public void testUpdatePeerIds() {
-
- String leader = "Leader";
- String follower1 = "follower1";
- String follower2 = "follower2";
- String follower3 = "follower3";
-
- Map<String, String> peerAddresses = new HashMap<>();
+ public void testServerConfigurationPayloadApplied() {
+ String follower1 = "follower1";
+ String follower2 = "follower2";
+ String follower3 = "follower3";
+
+ context.addToPeers(follower1, null, VotingState.VOTING);
+ context.addToPeers(follower2, null, VotingState.VOTING);
+
+ //add new Server
+ ServerConfigurationPayload obj = new ServerConfigurationPayload(Arrays.asList(
+ new ServerInfo(localId, true),
+ new ServerInfo(follower1, true),
+ new ServerInfo(follower2, false),
+ new ServerInfo(follower3, true)));
+
+ sendMessageToSupport(new MockRaftActorContext.MockReplicatedLogEntry(1, 0, obj));
+
+ //verify new peers
+ assertTrue("Dynamic server configuration", context.isDynamicServerConfigurationInUse());
+ assertEquals("New peer Ids", Sets.newHashSet(follower1, follower2, follower3),
+ Sets.newHashSet(context.getPeerIds()));
+ assertEquals("follower1 isVoting", true, context.getPeerInfo(follower1).isVoting());
+ assertEquals("follower2 isVoting", false, context.getPeerInfo(follower2).isVoting());
+ assertEquals("follower3 isVoting", true, context.getPeerInfo(follower3).isVoting());
+
+ sendMessageToSupport(new ApplyJournalEntries(0));
+
+ verify(mockCohort, never()).startLogRecoveryBatch(anyInt());
+ verify(mockCohort, never()).appendRecoveredLogEntry(any(Payload.class));
+
+ //remove existing follower1
+ obj = new ServerConfigurationPayload(Arrays.asList(
+ new ServerInfo(localId, true),
+ new ServerInfo("follower2", true),
+ new ServerInfo("follower3", true)));
+
+ sendMessageToSupport(new MockRaftActorContext.MockReplicatedLogEntry(1, 1, obj));
+
+ //verify new peers
+ assertTrue("Dynamic server configuration", context.isDynamicServerConfigurationInUse());
+ assertEquals("New peer Ids", Sets.newHashSet(follower2, follower3), Sets.newHashSet(context.getPeerIds()));
+ }
- peerAddresses.put(leader, null);
- peerAddresses.put(follower1, null);
- peerAddresses.put(follower2, null);
+ @Test
+ public void testServerConfigurationPayloadAppliedWithPersistenceDisabled() {
+ doReturn(false).when(mockPersistence).isRecoveryApplicable();
- context.addToPeers(leader,null,VotingState.VOTING);
- context.addToPeers(follower1,null,VotingState.VOTING);
- context.addToPeers(follower2,null,VotingState.VOTING);
+ String follower = "follower";
+ ServerConfigurationPayload obj = new ServerConfigurationPayload(Arrays.asList(
+ new ServerInfo(localId, true), new ServerInfo(follower, true)));
- assertEquals("Size", 3, context.getPeers().size());
+ sendMessageToSupport(new MockRaftActorContext.MockReplicatedLogEntry(1, 0, obj));
- //add new Server
- ServerConfigurationPayload obj = new ServerConfigurationPayload(Arrays.asList(
- new ServerInfo(leader, true),
- new ServerInfo(follower1, true),
- new ServerInfo(follower2, true),
- new ServerInfo(follower3, true)));
+ //verify new peers
+ assertEquals("New peer Ids", Sets.newHashSet(follower), Sets.newHashSet(context.getPeerIds()));
+ }
- MockRaftActorContext.MockReplicatedLogEntry logEntry = new MockRaftActorContext.MockReplicatedLogEntry(1,
- 1, obj);
+ @Test
+ public void testOnSnapshotOfferWithServerConfiguration() {
+ long electionTerm = 2;
+ String electionVotedFor = "member-2";
+ ServerConfigurationPayload serverPayload = new ServerConfigurationPayload(Arrays.asList(
+ new ServerInfo(localId, true),
+ new ServerInfo("follower1", true),
+ new ServerInfo("follower2", true)));
- sendMessageToSupport(logEntry);
- //verify size and names
- assertEquals("Size", 4, context.getPeers().size());
- assertEquals("New follower matched", true , context.getPeerIds().contains(follower3));
+ Snapshot snapshot = Snapshot.create(new byte[]{1}, Collections.<ReplicatedLogEntry>emptyList(),
+ -1, -1, -1, -1, electionTerm, electionVotedFor, serverPayload);
- //remove existing follower1
- obj = new ServerConfigurationPayload(Arrays.asList(
- new ServerInfo("Leader", true),
- new ServerInfo("follower2", true),
- new ServerInfo("follower3", true)));
+ SnapshotMetadata metadata = new SnapshotMetadata("test", 6, 12345);
+ SnapshotOffer snapshotOffer = new SnapshotOffer(metadata , snapshot);
- logEntry = new MockRaftActorContext.MockReplicatedLogEntry(1, 1, obj);
+ sendMessageToSupport(snapshotOffer);
- sendMessageToSupport(logEntry);
- //verify size and names
- assertEquals("Size", 3, context.getPeers().size());
- assertEquals("Removed follower matched", false, context.getPeerIds().contains(follower1));
+ assertEquals("Journal log size", 0, context.getReplicatedLog().size());
+ assertEquals("Election term", electionTerm, context.getTermInformation().getCurrentTerm());
+ assertEquals("Election votedFor", electionVotedFor, context.getTermInformation().getVotedFor());
+ assertTrue("Dynamic server configuration", context.isDynamicServerConfigurationInUse());
+ assertEquals("Peer List", Sets.newHashSet("follower1", "follower2"),
+ Sets.newHashSet(context.getPeerIds()));
}
}
Code Review / controller.git / blobdiff