Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
BUG-614: degrade NotifyTask to Runnable
[controller.git]
/
opendaylight
/
md-sal
/
sal-binding-broker
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
sal
/
binding
/
impl
/
NotifyTask.java
diff --git
a/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/NotifyTask.java
b/opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/NotifyTask.java
index b0dd2a90f7b8d53a1a4c4432d0d7074a1438ff4e..5f0de6bc16c8a18ba1fc925b3a84693c85d06536 100644
(file)
--- a/
opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/NotifyTask.java
+++ b/
opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/impl/NotifyTask.java
@@
-7,8
+7,6
@@
*/
package org.opendaylight.controller.sal.binding.impl;
*/
package org.opendaylight.controller.sal.binding.impl;
-import java.util.concurrent.Callable;
-
import org.opendaylight.controller.sal.binding.api.NotificationListener;
import org.opendaylight.yangtools.yang.binding.Notification;
import org.slf4j.Logger;
import org.opendaylight.controller.sal.binding.api.NotificationListener;
import org.opendaylight.yangtools.yang.binding.Notification;
import org.slf4j.Logger;
@@
-17,7
+15,7
@@
import org.slf4j.LoggerFactory;
import com.google.common.base.Objects;
import com.google.common.base.Preconditions;
import com.google.common.base.Objects;
import com.google.common.base.Preconditions;
-class NotifyTask implements
Callable<Object>
{
+class NotifyTask implements
Runnable
{
private static final Logger LOG = LoggerFactory.getLogger(NotifyTask.class);
private final NotificationListener<?> listener;
private static final Logger LOG = LoggerFactory.getLogger(NotifyTask.class);
private final NotificationListener<?> listener;
@@
-34,7
+32,7
@@
class NotifyTask implements Callable<Object> {
}
@Override
}
@Override
- public
Object call
() {
+ public
void run
() {
if (LOG.isDebugEnabled()) {
LOG.debug("Delivering notification {} to {}", notification, listener);
} else {
if (LOG.isDebugEnabled()) {
LOG.debug("Delivering notification {} to {}", notification, listener);
} else {
@@
-52,8
+50,6
@@
class NotifyTask implements Callable<Object> {
} else {
LOG.trace("Notification delivered {} to {}", notification.getClass().getName(), listener);
}
} else {
LOG.trace("Notification delivered {} to {}", notification.getClass().getName(), listener);
}
-
- return null;
}
@Override
}
@Override