Code Review
/
controller.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Use URLEncoder.encode(String, Charset)
[controller.git]
/
opendaylight
/
md-sal
/
sal-clustering-commons
/
src
/
main
/
java
/
org
/
opendaylight
/
controller
/
cluster
/
persistence
/
LocalSnapshotStore.java
diff --git
a/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/persistence/LocalSnapshotStore.java
b/opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/persistence/LocalSnapshotStore.java
index 695f34ecee5fe7647fc310ee6f6572512c6ae57f..b63b732f5bc99f5b97c552ee71af15c4ef700490 100644
(file)
--- a/
opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/persistence/LocalSnapshotStore.java
+++ b/
opendaylight/md-sal/sal-clustering-commons/src/main/java/org/opendaylight/controller/cluster/persistence/LocalSnapshotStore.java
@@
-28,7
+28,6
@@
import java.io.IOException;
import java.io.InputStream;
import java.io.ObjectInputStream;
import java.io.ObjectOutputStream;
import java.io.InputStream;
import java.io.ObjectInputStream;
import java.io.ObjectOutputStream;
-import java.io.UnsupportedEncodingException;
import java.net.URLDecoder;
import java.net.URLEncoder;
import java.nio.charset.StandardCharsets;
import java.net.URLDecoder;
import java.net.URLEncoder;
import java.nio.charset.StandardCharsets;
@@
-70,7
+69,7
@@
public class LocalSnapshotStore extends SnapshotStore {
private final File snapshotDir;
public LocalSnapshotStore(final Config config) {
private final File snapshotDir;
public LocalSnapshotStore(final Config config) {
-
this.
executionContext = context().system().dispatchers().lookup(config.getString("stream-dispatcher"));
+ executionContext = context().system().dispatchers().lookup(config.getString("stream-dispatcher"));
snapshotDir = new File(config.getString("dir"));
final int localMaxLoadAttempts = config.getInt("max-load-attempts");
snapshotDir = new File(config.getString("dir"));
final int localMaxLoadAttempts = config.getInt("max-load-attempts");
@@
-331,23
+330,11
@@
public class LocalSnapshotStore extends SnapshotStore {
}
private static String encode(final String str) {
}
private static String encode(final String str) {
- try {
- return URLEncoder.encode(str, StandardCharsets.UTF_8.name());
- } catch (UnsupportedEncodingException e) {
- // Shouldn't happen
- LOG.warn("Error encoding {}", str, e);
- return str;
- }
+ return URLEncoder.encode(str, StandardCharsets.UTF_8);
}
private static String decode(final String str) {
}
private static String decode(final String str) {
- try {
- return URLDecoder.decode(str, StandardCharsets.UTF_8.name());
- } catch (final UnsupportedEncodingException e) {
- // Shouldn't happen
- LOG.warn("Error decoding {}", str, e);
- return str;
- }
+ return URLDecoder.decode(str, StandardCharsets.UTF_8);
}
@VisibleForTesting
}
@VisibleForTesting