Fix findbugs violations in md-sal - part 1

[controller.git] / opendaylight / md-sal / sal-common-util / src / main / java / org / opendaylight / controller / sal / common / util / Rpcs.java

diff --git a/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/Rpcs.java b/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/Rpcs.java
index 9ffe8ab0644036ed210e0151514312374c2d08a1..3278cef19844ae4e62c9a9e02c7b18a472757614 100644 (file)
--- a/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/Rpcs.java
+++ b/opendaylight/md-sal/sal-common-util/src/main/java/org/opendaylight/controller/sal/common/util/Rpcs.java
@@ -7,20 +7,21 @@
  */
 package org.opendaylight.controller.sal.common.util;
 
-import java.io.Serializable;
+import com.google.common.collect.ImmutableList;
 import java.util.Collection;
-
 import org.opendaylight.yangtools.concepts.Immutable;
 import org.opendaylight.yangtools.yang.common.RpcError;
 import org.opendaylight.yangtools.yang.common.RpcResult;
 
-import com.google.common.collect.ImmutableList;
-
 /**
+ * Deprecated.
+ *
  * @deprecated Use {@link org.opendaylight.yangtools.yang.common.RpcResultBuilder}
  */
 @Deprecated
-public class Rpcs {
+public final class Rpcs {
+    private Rpcs() {
+    }
 
     public static <T> RpcResult<T> getRpcResult(boolean successful) {
         return new RpcResultTO<>(successful, null, ImmutableList.of());
@@ -35,14 +36,12 @@ public class Rpcs {
         return new RpcResultTO<>(successful, null, errors);
     }
 
-    private static class RpcResultTO<T> implements RpcResult<T>, Serializable, Immutable {
-        private static final long serialVersionUID = 1L;
+    private static class RpcResultTO<T> implements RpcResult<T>, Immutable {
         private final Collection<RpcError> errors;
         private final T result;
         private final boolean successful;
 
-        public RpcResultTO(boolean successful, T result,
-                Collection<RpcError> errors) {
+        RpcResultTO(boolean successful, T result, Collection<RpcError> errors) {
             this.successful = successful;
             this.result = result;
             this.errors = ImmutableList.copyOf(errors);
@@ -62,6 +61,5 @@ public class Rpcs {
         public Collection<RpcError> getErrors() {
             return errors;
         }
-
     }
 }