* terms of the Eclipse Public License v1.0 which accompanies this distribution,
* and is available at http://www.eclipse.org/legal/epl-v10.html
*/
-
package org.opendaylight.controller.cluster.databroker;
import static com.google.common.base.Preconditions.checkState;
-import com.google.common.collect.ImmutableMap;
-import com.google.common.collect.ImmutableMap.Builder;
+import com.google.common.collect.ClassToInstanceMap;
+import com.google.common.collect.ImmutableClassToInstanceMap;
+import com.google.common.collect.ImmutableClassToInstanceMap.Builder;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import java.util.EnumMap;
import java.util.Map;
import java.util.concurrent.atomic.AtomicLong;
import org.opendaylight.mdsal.common.api.LogicalDatastoreType;
-import org.opendaylight.mdsal.common.api.TransactionChainListener;
-import org.opendaylight.mdsal.dom.api.DOMDataBroker;
import org.opendaylight.mdsal.dom.api.DOMDataBrokerExtension;
import org.opendaylight.mdsal.dom.api.DOMDataTreeChangeListener;
import org.opendaylight.mdsal.dom.api.DOMDataTreeChangeService;
import org.opendaylight.mdsal.dom.api.DOMDataTreeCommitCohortRegistry;
import org.opendaylight.mdsal.dom.api.DOMDataTreeIdentifier;
import org.opendaylight.mdsal.dom.api.DOMTransactionChain;
+import org.opendaylight.mdsal.dom.api.DOMTransactionChainListener;
+import org.opendaylight.mdsal.dom.spi.PingPongMergingDOMDataBroker;
import org.opendaylight.mdsal.dom.spi.store.DOMStore;
import org.opendaylight.mdsal.dom.spi.store.DOMStoreTransactionChain;
import org.opendaylight.mdsal.dom.spi.store.DOMStoreTreeChangePublisher;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public abstract class AbstractDOMBroker extends AbstractDOMTransactionFactory<DOMStore> implements DOMDataBroker {
+public abstract class AbstractDOMBroker extends AbstractDOMTransactionFactory<DOMStore>
+ implements PingPongMergingDOMDataBroker {
private static final Logger LOG = LoggerFactory.getLogger(AbstractDOMBroker.class);
private final AtomicLong txNum = new AtomicLong();
private final AtomicLong chainNum = new AtomicLong();
- private final Map<Class<? extends DOMDataBrokerExtension>, DOMDataBrokerExtension> extensions;
+ private final ClassToInstanceMap<DOMDataBrokerExtension> extensions;
+
private volatile AutoCloseable closeable;
protected AbstractDOMBroker(final Map<LogicalDatastoreType, DOMStore> datastores) {
super(datastores);
- Builder<Class<? extends DOMDataBrokerExtension>, DOMDataBrokerExtension> extBuilder = ImmutableMap.builder();
+ Builder<DOMDataBrokerExtension> extBuilder = ImmutableClassToInstanceMap.builder();
if (isSupported(datastores, DOMStoreTreeChangePublisher.class)) {
extBuilder.put(DOMDataTreeChangeService.class, new DOMDataTreeChangeService() {
@Override
extBuilder.put(DOMDataTreeCommitCohortRegistry.class, new DOMDataTreeCommitCohortRegistry() {
@Override
public <T extends DOMDataTreeCommitCohort> DOMDataTreeCommitCohortRegistration<T> registerCommitCohort(
- DOMDataTreeIdentifier path, T cohort) {
+ final DOMDataTreeIdentifier path, final T cohort) {
DOMStore store = getDOMStore(path.getDatastoreType());
return ((DOMDataTreeCommitCohortRegistry) store).registerCommitCohort(path, cohort);
}
extensions = extBuilder.build();
}
- private static boolean isSupported(Map<LogicalDatastoreType, DOMStore> datastores,
- Class<?> expDOMStoreInterface) {
- for (DOMStore ds : datastores.values()) {
- if (!expDOMStoreInterface.isAssignableFrom(ds.getClass())) {
- return false;
- }
- }
-
- return true;
+ private static boolean isSupported(final Map<LogicalDatastoreType, DOMStore> datastores,
+ final Class<?> expDOMStoreInterface) {
+ return datastores.values().stream().allMatch(expDOMStoreInterface::isInstance);
}
public void setCloseable(final AutoCloseable closeable) {
}
@Override
- public Map<Class<? extends DOMDataBrokerExtension>, DOMDataBrokerExtension> getSupportedExtensions() {
+ public ClassToInstanceMap<DOMDataBrokerExtension> getExtensions() {
return extensions;
}
@Override
- public DOMTransactionChain createTransactionChain(final TransactionChainListener listener) {
+ public DOMTransactionChain createTransactionChain(final DOMTransactionChainListener listener) {
checkNotClosed();
final Map<LogicalDatastoreType, DOMStoreTransactionChain> backingChains =
return new DOMBrokerTransactionChain(chainId, backingChains, this, listener);
}
+ @SuppressFBWarnings(value = "UPM_UNCALLED_PRIVATE_METHOD",
+ justification = "https://github.com/spotbugs/spotbugs/issues/811")
private DOMStore getDOMStore(final LogicalDatastoreType type) {
DOMStore store = getTxFactories().get(type);
checkState(store != null, "Requested logical data store is not available.");