*/
package org.opendaylight.controller.cluster.datastore;
+import static com.google.common.base.Preconditions.checkState;
+import static java.util.Objects.requireNonNull;
+
import com.google.common.base.MoreObjects;
-import com.google.common.base.Preconditions;
-import com.google.common.util.concurrent.FutureCallback;
-import com.google.common.util.concurrent.Futures;
-import com.google.common.util.concurrent.ListenableFuture;
-import javax.annotation.concurrent.NotThreadSafe;
-import org.opendaylight.controller.sal.core.spi.data.DOMStoreThreePhaseCommitCohort;
-import org.opendaylight.controller.sal.core.spi.data.ForwardingDOMStoreThreePhaseCommitCohort;
-import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeSnapshot;
+import java.util.Optional;
+import java.util.SortedSet;
+import org.opendaylight.controller.cluster.access.concepts.LocalHistoryIdentifier;
+import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
+import org.opendaylight.yangtools.concepts.Identifiable;
+import org.opendaylight.yangtools.yang.data.tree.api.DataTreeModification;
+import org.opendaylight.yangtools.yang.data.tree.api.DataTreeSnapshot;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
/**
- * A transaction chain attached to a Shard.
+ * A transaction chain attached to a Shard. This class is NOT thread-safe.
*/
-@NotThreadSafe
-final class ShardDataTreeTransactionChain extends ShardDataTreeTransactionParent {
+final class ShardDataTreeTransactionChain extends ShardDataTreeTransactionParent
+ implements Identifiable<LocalHistoryIdentifier> {
+
private static final Logger LOG = LoggerFactory.getLogger(ShardDataTreeTransactionChain.class);
+ private final LocalHistoryIdentifier chainId;
private final ShardDataTree dataTree;
- private final String chainId;
private ReadWriteShardDataTreeTransaction previousTx;
private ReadWriteShardDataTreeTransaction openTransaction;
private boolean closed;
- ShardDataTreeTransactionChain(final String chainId, final ShardDataTree dataTree) {
- this.dataTree = Preconditions.checkNotNull(dataTree);
- this.chainId = Preconditions.checkNotNull(chainId);
+ ShardDataTreeTransactionChain(final LocalHistoryIdentifier localHistoryIdentifier, final ShardDataTree dataTree) {
+ chainId = requireNonNull(localHistoryIdentifier);
+ this.dataTree = requireNonNull(dataTree);
}
private DataTreeSnapshot getSnapshot() {
- Preconditions.checkState(!closed, "TransactionChain %s has been closed", this);
- Preconditions.checkState(openTransaction == null, "Transaction %s is open", openTransaction);
+ checkState(!closed, "TransactionChain %s has been closed", this);
+ checkState(openTransaction == null, "Transaction %s is open", openTransaction);
if (previousTx == null) {
- return dataTree.getDataTree().takeSnapshot();
- } else {
- return previousTx.getSnapshot();
+ LOG.debug("Opening an unchained snapshot in {}", chainId);
+ return dataTree.takeSnapshot();
}
+
+ LOG.debug("Reusing a chained snapshot in {}", chainId);
+ return previousTx.getSnapshot();
}
- ReadOnlyShardDataTreeTransaction newReadOnlyTransaction(final String txId) {
+ ReadOnlyShardDataTreeTransaction newReadOnlyTransaction(final TransactionIdentifier txId) {
final DataTreeSnapshot snapshot = getSnapshot();
LOG.debug("Allocated read-only transaction {} snapshot {}", txId, snapshot);
- return new ReadOnlyShardDataTreeTransaction(txId, snapshot);
+ return new ReadOnlyShardDataTreeTransaction(this, txId, snapshot);
}
- ReadWriteShardDataTreeTransaction newReadWriteTransaction(final String txId) {
+ ReadWriteShardDataTreeTransaction newReadWriteTransaction(final TransactionIdentifier txId) {
final DataTreeSnapshot snapshot = getSnapshot();
LOG.debug("Allocated read-write transaction {} snapshot {}", txId, snapshot);
void close() {
closed = true;
+ LOG.debug("Closing chain {}", chainId);
}
@Override
- protected void abortTransaction(final AbstractShardDataTreeTransaction<?> transaction) {
+ void abortFromTransactionActor(final AbstractShardDataTreeTransaction<?> transaction) {
if (transaction instanceof ReadWriteShardDataTreeTransaction) {
- Preconditions.checkState(openTransaction != null, "Attempted to abort transaction %s while none is outstanding", transaction);
- LOG.debug("Aborted transaction {}", transaction);
+ checkState(openTransaction != null, "Attempted to abort transaction %s while none is outstanding",
+ transaction);
+ LOG.debug("Aborted open transaction {}", transaction);
openTransaction = null;
}
}
@Override
- protected DOMStoreThreePhaseCommitCohort finishTransaction(final ReadWriteShardDataTreeTransaction transaction) {
- Preconditions.checkState(openTransaction != null, "Attempted to finish transaction %s while none is outstanding", transaction);
+ void abortTransaction(final AbstractShardDataTreeTransaction<?> transaction, final Runnable callback) {
+ abortFromTransactionActor(transaction);
+ dataTree.abortTransaction(transaction, callback);
+ }
+
+ @Override
+ ShardDataTreeCohort finishTransaction(final ReadWriteShardDataTreeTransaction transaction,
+ final Optional<SortedSet<String>> participatingShardNames) {
+ checkState(openTransaction != null, "Attempted to finish transaction %s while none is outstanding",
+ transaction);
// dataTree is finalizing ready the transaction, we just record it for the next
// transaction in chain
- final DOMStoreThreePhaseCommitCohort delegate = dataTree.finishTransaction(transaction);
+ final ShardDataTreeCohort delegate = dataTree.finishTransaction(transaction, participatingShardNames);
openTransaction = null;
previousTx = transaction;
LOG.debug("Committing transaction {}", transaction);
- return new CommitCohort(transaction, delegate);
+ return new ChainedCommitCohort(this, transaction, delegate);
}
@Override
return MoreObjects.toStringHelper(this).add("id", chainId).toString();
}
- private final class CommitCohort extends ForwardingDOMStoreThreePhaseCommitCohort {
- private final ReadWriteShardDataTreeTransaction transaction;
- private final DOMStoreThreePhaseCommitCohort delegate;
-
- CommitCohort(final ReadWriteShardDataTreeTransaction transaction, final DOMStoreThreePhaseCommitCohort delegate) {
- this.transaction = Preconditions.checkNotNull(transaction);
- this.delegate = Preconditions.checkNotNull(delegate);
+ void clearTransaction(final ReadWriteShardDataTreeTransaction transaction) {
+ if (transaction.equals(previousTx)) {
+ previousTx = null;
}
+ }
- @Override
- protected DOMStoreThreePhaseCommitCohort delegate() {
- return delegate;
- }
+ @Override
+ public LocalHistoryIdentifier getIdentifier() {
+ return chainId;
+ }
- @Override
- public ListenableFuture<Void> commit() {
- final ListenableFuture<Void> ret = super.commit();
-
- Futures.addCallback(ret, new FutureCallback<Void>() {
- @Override
- public void onSuccess(Void result) {
- if (transaction.equals(previousTx)) {
- previousTx = null;
- }
- LOG.debug("Committed transaction {}", transaction);
- }
-
- @Override
- public void onFailure(Throwable t) {
- LOG.error("Transaction {} commit failed, cannot recover", transaction, t);
- }
- });
-
- return ret;
- }
+ @Override
+ ShardDataTreeCohort createFailedCohort(final TransactionIdentifier txId, final DataTreeModification mod,
+ final Exception failure) {
+ return dataTree.createFailedCohort(txId, mod, failure);
+ }
+
+ @Override
+ ShardDataTreeCohort createReadyCohort(final TransactionIdentifier txId, final DataTreeModification mod,
+ final Optional<SortedSet<String>> participatingShardNames) {
+ return dataTree.createReadyCohort(txId, mod, participatingShardNames);
}
}
Code Review / controller.git / blobdiff