Bug 7521: Convert DatastoreSnapshot.ShardSnapshot to store Snapshot

[controller.git] / opendaylight / md-sal / sal-distributed-datastore / src / main / java / org / opendaylight / controller / cluster / datastore / messages / CreateTransaction.java

diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/CreateTransaction.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/CreateTransaction.java
index cd9479543efca935cbb4640ef29db9af7c25ab10..52e8824343fe1cafcf9398e58a340787ce2ea1e2 100644 (file)
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/CreateTransaction.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/messages/CreateTransaction.java
@@ -12,27 +12,24 @@ import com.google.common.base.Preconditions;
 import java.io.IOException;
 import java.io.ObjectInput;
 import java.io.ObjectOutput;
-import org.opendaylight.controller.protobuff.messages.transaction.ShardTransactionMessages;
+import org.opendaylight.controller.cluster.access.concepts.TransactionIdentifier;
 
 public class CreateTransaction extends VersionedExternalizableMessage {
     private static final long serialVersionUID = 1L;
 
-    private String transactionId;
+    private TransactionIdentifier transactionId;
     private int transactionType;
-    private String transactionChainId;
 
     public CreateTransaction() {
     }
 
-    public CreateTransaction(String transactionId, int transactionType, String transactionChainId,
-            short version) {
+    public CreateTransaction(TransactionIdentifier transactionId, int transactionType, short version) {
         super(version);
         this.transactionId = Preconditions.checkNotNull(transactionId);
         this.transactionType = transactionType;
-        this.transactionChainId = transactionChainId != null ? transactionChainId : "";
     }
 
-    public String getTransactionId() {
+    public TransactionIdentifier getTransactionId() {
         return transactionId;
     }
 
@@ -40,52 +37,31 @@ public class CreateTransaction extends VersionedExternalizableMessage {
         return transactionType;
     }
 
-    public String getTransactionChainId() {
-        return transactionChainId;
-    }
-
     @Override
     public void readExternal(ObjectInput in) throws IOException, ClassNotFoundException {
         super.readExternal(in);
-        transactionId = in.readUTF();
+        transactionId = TransactionIdentifier.readFrom(in);
         transactionType = in.readInt();
-        transactionChainId = in.readUTF();
     }
 
     @Override
     public void writeExternal(ObjectOutput out) throws IOException {
         super.writeExternal(out);
-        out.writeUTF(transactionId);
+        transactionId.writeTo(out);
         out.writeInt(transactionType);
-        out.writeUTF(transactionChainId);
-    }
-
-    @Override
-    protected Object newLegacySerializedInstance() {
-        return ShardTransactionMessages.CreateTransaction.newBuilder().setTransactionId(transactionId)
-                .setTransactionType(transactionType).setTransactionChainId(transactionChainId)
-                .setMessageVersion(getVersion()).build();
     }
 
     @Override
     public String toString() {
-        return "CreateTransaction [transactionId=" + transactionId + ", transactionType=" + transactionType
-                + ", transactionChainId=" + transactionChainId + "]";
+        return "CreateTransaction [transactionId=" + transactionId + ", transactionType=" + transactionType + "]";
     }
 
     public static CreateTransaction fromSerializable(Object message) {
-        if(message instanceof CreateTransaction) {
-            return (CreateTransaction)message;
-        } else {
-            ShardTransactionMessages.CreateTransaction createTransaction =
-                    (ShardTransactionMessages.CreateTransaction) message;
-            return new CreateTransaction(createTransaction.getTransactionId(),
-                    createTransaction.getTransactionType(), createTransaction.getTransactionChainId(),
-                    (short)createTransaction.getMessageVersion());
-        }
+        Preconditions.checkArgument(message instanceof CreateTransaction);
+        return (CreateTransaction)message;
     }
 
     public static boolean isSerializedType(Object message) {
-        return message instanceof CreateTransaction || message instanceof ShardTransactionMessages.CreateTransaction;
+        return message instanceof CreateTransaction;
     }
 }