Cleanup warnings around methods being potentially static

[controller.git] / opendaylight / md-sal / sal-distributed-datastore / src / main / java / org / opendaylight / controller / cluster / datastore / persisted / ShardSnapshotState.java

diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/ShardSnapshotState.java b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/ShardSnapshotState.java
index d4556cd374b18ff5e105382805b0bb70cdcab3f6..f56d6ce01fb7804f597957758e8d7449209bcab8 100644 (file)
--- a/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/ShardSnapshotState.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/persisted/ShardSnapshotState.java
@@ -47,14 +47,14 @@ public class ShardSnapshotState implements Snapshot.State {
             snapshotState.snapshot.serialize(toOutputStream(out));
         }
 
             snapshotState.snapshot.serialize(toOutputStream(out));
         }
 

-        private OutputStream toOutputStream(final ObjectOutput out) {
+        private static OutputStream toOutputStream(final ObjectOutput out) {

             if (out instanceof OutputStream) {
                 return (OutputStream) out;
             }
 
             return new OutputStream() {
                 @Override
             if (out instanceof OutputStream) {
                 return (OutputStream) out;
             }
 
             return new OutputStream() {
                 @Override

-                public void write(int value) throws IOException {
+                public void write(final int value) throws IOException {

                     out.write(value);
                 }
             };
                     out.write(value);
                 }
             };


@@ -65,7 +65,7 @@ public class ShardSnapshotState implements Snapshot.State {
             snapshotState = new ShardSnapshotState(ShardDataTreeSnapshot.deserialize(toInputStream(in)));
         }
 
             snapshotState = new ShardSnapshotState(ShardDataTreeSnapshot.deserialize(toInputStream(in)));
         }
 

-        private InputStream toInputStream(final ObjectInput in) {
+        private static InputStream toInputStream(final ObjectInput in) {

             if (in instanceof InputStream) {
                 return (InputStream) in;
             }
             if (in instanceof InputStream) {
                 return (InputStream) in;
             }


@@ -88,7 +88,7 @@ public class ShardSnapshotState implements Snapshot.State {
             + "aren't serialized. FindBugs does not recognize this.")
     private final ShardDataTreeSnapshot snapshot;
 
             + "aren't serialized. FindBugs does not recognize this.")
     private final ShardDataTreeSnapshot snapshot;
 

-    public ShardSnapshotState(@Nonnull ShardDataTreeSnapshot snapshot) {
+    public ShardSnapshotState(@Nonnull final ShardDataTreeSnapshot snapshot) {

         this.snapshot = Preconditions.checkNotNull(snapshot);
     }
 
         this.snapshot = Preconditions.checkNotNull(snapshot);
     }
 


@@ -97,7 +97,6 @@ public class ShardSnapshotState implements Snapshot.State {
         return snapshot;
     }
 
         return snapshot;
     }
 

-    @SuppressWarnings("static-method")

     private Object writeReplace() {
         return new Proxy(this);
     }
     private Object writeReplace() {
         return new Proxy(this);
     }