import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
+import static org.opendaylight.yangtools.util.concurrent.FluentFutures.immediateFalseFluentFuture;
+import static org.opendaylight.yangtools.util.concurrent.FluentFutures.immediateNullFluentFuture;
+import static org.opendaylight.yangtools.util.concurrent.FluentFutures.immediateTrueFluentFuture;
import com.google.common.base.Throwables;
+import com.google.common.collect.ClassToInstanceMap;
import com.google.common.collect.ImmutableMap;
import com.google.common.util.concurrent.FluentFuture;
import com.google.common.util.concurrent.FutureCallback;
import java.util.Arrays;
import java.util.Collection;
import java.util.List;
-import java.util.Map;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.SynchronousQueue;
import org.opendaylight.mdsal.common.api.CommitInfo;
import org.opendaylight.mdsal.common.api.DataStoreUnavailableException;
import org.opendaylight.mdsal.common.api.LogicalDatastoreType;
-import org.opendaylight.mdsal.common.api.TransactionChainListener;
import org.opendaylight.mdsal.common.api.TransactionCommitFailedException;
import org.opendaylight.mdsal.dom.api.DOMDataBrokerExtension;
import org.opendaylight.mdsal.dom.api.DOMDataTreeChangeService;
import org.opendaylight.mdsal.dom.api.DOMDataTreeReadWriteTransaction;
import org.opendaylight.mdsal.dom.api.DOMDataTreeWriteTransaction;
import org.opendaylight.mdsal.dom.api.DOMTransactionChain;
+import org.opendaylight.mdsal.dom.api.DOMTransactionChainListener;
import org.opendaylight.mdsal.dom.broker.TransactionCommitFailedExceptionMapper;
import org.opendaylight.mdsal.dom.spi.store.DOMStore;
import org.opendaylight.mdsal.dom.spi.store.DOMStoreReadTransaction;
new Thread(() -> {
Uninterruptibles.awaitUninterruptibly(asyncCanCommitContinue,
10, TimeUnit.SECONDS);
- future.set(true);
+ future.set(Boolean.TRUE);
}).start();
} else {
- future.set(true);
+ future.set(Boolean.TRUE);
}
return future;
};
doAnswer(asyncCanCommit).when(mockCohort1).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort1).preCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort1).commit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort1).preCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort1).commit();
- doReturn(Futures.immediateFuture(true)).when(mockCohort2).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort2).preCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort2).commit();
+ doReturn(immediateTrueFluentFuture()).when(mockCohort2).canCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort2).preCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort2).commit();
ListenableFuture<? extends CommitInfo> future =
coordinator.commit(transaction, Arrays.asList(mockCohort1, mockCohort2));
asyncCanCommitContinue.countDown();
- assertEquals("Submit complete", true, doneLatch.await(5, TimeUnit.SECONDS));
+ assertTrue("Submit complete", doneLatch.await(5, TimeUnit.SECONDS));
if (caughtEx.get() != null) {
Throwables.throwIfUnchecked(caughtEx.get());
@Test
public void testSubmitWithNegativeCanCommitResponse() throws Exception {
- doReturn(Futures.immediateFuture(true)).when(mockCohort1).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort1).abort();
+ doReturn(immediateTrueFluentFuture()).when(mockCohort1).canCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort1).abort();
- doReturn(Futures.immediateFuture(false)).when(mockCohort2).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort2).abort();
+ doReturn(Futures.immediateFuture(Boolean.FALSE)).when(mockCohort2).canCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort2).abort();
DOMStoreThreePhaseCommitCohort mockCohort3 = mock(DOMStoreThreePhaseCommitCohort.class);
- doReturn(Futures.immediateFuture(false)).when(mockCohort3).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort3).abort();
+ doReturn(Futures.immediateFuture(Boolean.FALSE)).when(mockCohort3).canCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort3).abort();
ListenableFuture<? extends CommitInfo> future = coordinator.commit(
transaction, Arrays.asList(mockCohort1, mockCohort2, mockCohort3));
assertFailure(future, null, mockCohort1, mockCohort2, mockCohort3);
}
- private static void assertFailure(final ListenableFuture<?> future,
- final Exception expCause, final DOMStoreThreePhaseCommitCohort... mockCohorts)
- throws Exception {
+ private static void assertFailure(final ListenableFuture<?> future, final Exception expCause,
+ final DOMStoreThreePhaseCommitCohort... mockCohorts) throws Exception {
try {
future.get(5, TimeUnit.SECONDS);
fail("Expected TransactionCommitFailedException");
@Test
public void testSubmitWithCanCommitException() throws Exception {
- doReturn(Futures.immediateFuture(true)).when(mockCohort1).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort1).abort();
+ doReturn(immediateTrueFluentFuture()).when(mockCohort1).canCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort1).abort();
IllegalStateException cause = new IllegalStateException("mock");
doReturn(Futures.immediateFailedFuture(cause)).when(mockCohort2).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort2).abort();
+ doReturn(immediateNullFluentFuture()).when(mockCohort2).abort();
FluentFuture<? extends CommitInfo> future = coordinator.commit(
transaction, Arrays.asList(mockCohort1, mockCohort2));
@Test
public void testSubmitWithCanCommitDataStoreUnavailableException() throws Exception {
- doReturn(Futures.immediateFuture(true)).when(mockCohort1).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort1).abort();
+ doReturn(immediateTrueFluentFuture()).when(mockCohort1).canCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort1).abort();
NoShardLeaderException rootCause = new NoShardLeaderException("mock");
DataStoreUnavailableException cause = new DataStoreUnavailableException(rootCause.getMessage(), rootCause);
doReturn(Futures.immediateFailedFuture(rootCause)).when(mockCohort2).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort2).abort();
+ doReturn(immediateNullFluentFuture()).when(mockCohort2).abort();
FluentFuture<? extends CommitInfo> future = coordinator.commit(
transaction, Arrays.asList(mockCohort1, mockCohort2));
@Test
public void testSubmitWithPreCommitException() throws Exception {
- doReturn(Futures.immediateFuture(true)).when(mockCohort1).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort1).preCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort1).abort();
+ doReturn(immediateTrueFluentFuture()).when(mockCohort1).canCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort1).preCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort1).abort();
- doReturn(Futures.immediateFuture(true)).when(mockCohort2).canCommit();
+ doReturn(immediateTrueFluentFuture()).when(mockCohort2).canCommit();
IllegalStateException cause = new IllegalStateException("mock");
doReturn(Futures.immediateFailedFuture(cause)).when(mockCohort2).preCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort2).abort();
+ doReturn(immediateNullFluentFuture()).when(mockCohort2).abort();
DOMStoreThreePhaseCommitCohort mockCohort3 = mock(DOMStoreThreePhaseCommitCohort.class);
- doReturn(Futures.immediateFuture(true)).when(mockCohort3).canCommit();
+ doReturn(immediateTrueFluentFuture()).when(mockCohort3).canCommit();
doReturn(Futures.immediateFailedFuture(new IllegalStateException("mock2")))
.when(mockCohort3).preCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort3).abort();
+ doReturn(immediateNullFluentFuture()).when(mockCohort3).abort();
FluentFuture<? extends CommitInfo> future = coordinator.commit(
transaction, Arrays.asList(mockCohort1, mockCohort2, mockCohort3));
@Test
public void testSubmitWithCommitException() throws Exception {
- doReturn(Futures.immediateFuture(true)).when(mockCohort1).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort1).preCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort1).commit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort1).abort();
+ doReturn(immediateTrueFluentFuture()).when(mockCohort1).canCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort1).preCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort1).commit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort1).abort();
- doReturn(Futures.immediateFuture(true)).when(mockCohort2).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort2).preCommit();
+ doReturn(immediateTrueFluentFuture()).when(mockCohort2).canCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort2).preCommit();
IllegalStateException cause = new IllegalStateException("mock");
doReturn(Futures.immediateFailedFuture(cause)).when(mockCohort2).commit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort2).abort();
+ doReturn(immediateNullFluentFuture()).when(mockCohort2).abort();
DOMStoreThreePhaseCommitCohort mockCohort3 = mock(DOMStoreThreePhaseCommitCohort.class);
- doReturn(Futures.immediateFuture(true)).when(mockCohort3).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort3).preCommit();
+ doReturn(immediateTrueFluentFuture()).when(mockCohort3).canCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort3).preCommit();
doReturn(Futures.immediateFailedFuture(new IllegalStateException("mock2")))
.when(mockCohort3).commit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort3).abort();
+ doReturn(immediateNullFluentFuture()).when(mockCohort3).abort();
FluentFuture<? extends CommitInfo> future = coordinator.commit(
transaction, Arrays.asList(mockCohort1, mockCohort2, mockCohort3));
@Test
public void testSubmitWithAbortException() throws Exception {
- doReturn(Futures.immediateFuture(true)).when(mockCohort1).canCommit();
+ doReturn(immediateTrueFluentFuture()).when(mockCohort1).canCommit();
doReturn(Futures.immediateFailedFuture(new IllegalStateException("mock abort error")))
.when(mockCohort1).abort();
IllegalStateException cause = new IllegalStateException("mock canCommit error");
doReturn(Futures.immediateFailedFuture(cause)).when(mockCohort2).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort2).abort();
+ doReturn(immediateNullFluentFuture()).when(mockCohort2).abort();
FluentFuture<? extends CommitInfo> future = coordinator.commit(
transaction, Arrays.asList(mockCohort1, mockCohort2));
doReturn(mockStoreReadWriteTransaction).when(operationalDomStore).newReadWriteTransaction();
doReturn(mockCohort).when(mockStoreReadWriteTransaction).ready();
- doReturn(Futures.immediateFuture(false)).when(mockCohort).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohort).abort();
+ doReturn(immediateFalseFluentFuture()).when(mockCohort).canCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohort).abort();
final CountDownLatch latch = new CountDownLatch(1);
final List<DOMStoreThreePhaseCommitCohort> commitCohorts = new ArrayList<>();
doReturn(configTransaction).when(configDomStore).newReadWriteTransaction();
doReturn(mockCohortOperational).when(operationalTransaction).ready();
- doReturn(Futures.immediateFuture(false)).when(mockCohortOperational).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohortOperational).abort();
+ doReturn(immediateFalseFluentFuture()).when(mockCohortOperational).canCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohortOperational).abort();
doReturn(mockCohortConfig).when(configTransaction).ready();
- doReturn(Futures.immediateFuture(false)).when(mockCohortConfig).canCommit();
- doReturn(Futures.immediateFuture(null)).when(mockCohortConfig).abort();
+ doReturn(immediateFalseFluentFuture()).when(mockCohortConfig).canCommit();
+ doReturn(immediateNullFluentFuture()).when(mockCohortConfig).abort();
final CountDownLatch latch = new CountDownLatch(1);
final List<DOMStoreThreePhaseCommitCohort> commitCohorts = new ArrayList<>();
LogicalDatastoreType.OPERATIONAL, domStore, LogicalDatastoreType.CONFIGURATION, domStore),
futureExecutor)) {
- dataBroker.createTransactionChain(mock(TransactionChainListener.class));
+ dataBroker.createTransactionChain(mock(DOMTransactionChainListener.class));
verify(domStore, times(2)).createTransactionChain();
}
doReturn(operationalTransaction).when(mockChain).newWriteOnlyTransaction();
DOMTransactionChain transactionChain = dataBroker.createTransactionChain(
- mock(TransactionChainListener.class));
+ mock(DOMTransactionChainListener.class));
DOMDataTreeWriteTransaction domDataWriteTransaction = transactionChain.newWriteOnlyTransaction();
LogicalDatastoreType.OPERATIONAL, mockOperStore,
LogicalDatastoreType.CONFIGURATION, mockConfigStore), futureExecutor)) {
- Map<Class<? extends DOMDataBrokerExtension>, DOMDataBrokerExtension> supportedExtensions =
- dataBroker.getSupportedExtensions();
- assertNotNull(supportedExtensions.get(DOMDataTreeChangeService.class));
+ ClassToInstanceMap<DOMDataBrokerExtension> supportedExtensions = dataBroker.getExtensions();
+ assertNotNull(supportedExtensions.getInstance(DOMDataTreeChangeService.class));
- DOMDataTreeCommitCohortRegistry cohortRegistry =
- (DOMDataTreeCommitCohortRegistry) supportedExtensions.get(DOMDataTreeCommitCohortRegistry.class);
+ DOMDataTreeCommitCohortRegistry cohortRegistry = supportedExtensions.getInstance(
+ DOMDataTreeCommitCohortRegistry.class);
assertNotNull(cohortRegistry);
DOMDataTreeCommitCohort mockCohort = mock(DOMDataTreeCommitCohort.class);