package org.opendaylight.controller.cluster.datastore;
import static org.junit.Assert.assertEquals;
+import static org.mockito.Mockito.doReturn;
+import static org.mockito.Mockito.mock;
import static org.opendaylight.controller.cluster.datastore.DatastoreContext.DEFAULT_HEARTBEAT_INTERVAL_IN_MILLIS;
import static org.opendaylight.controller.cluster.datastore.DatastoreContext.DEFAULT_OPERATION_TIMEOUT_IN_MS;
import static org.opendaylight.controller.cluster.datastore.DatastoreContext.DEFAULT_SHARD_INITIALIZATION_TIMEOUT;
import static org.opendaylight.controller.cluster.datastore.DatastoreContext.DEFAULT_SHARD_SNAPSHOT_DATA_THRESHOLD_PERCENTAGE;
import static org.opendaylight.controller.cluster.datastore.DatastoreContext.DEFAULT_SHARD_TRANSACTION_IDLE_TIMEOUT;
import static org.opendaylight.controller.cluster.datastore.DatastoreContext.DEFAULT_SHARD_TX_COMMIT_TIMEOUT_IN_SECONDS;
-import java.util.Dictionary;
+import static org.opendaylight.mdsal.common.api.LogicalDatastoreType.CONFIGURATION;
+import static org.opendaylight.mdsal.common.api.LogicalDatastoreType.OPERATIONAL;
+
+import java.util.Arrays;
+import java.util.HashMap;
import java.util.Hashtable;
+import java.util.Map;
import org.junit.Test;
-import org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType;
-import org.opendaylight.controller.md.sal.dom.store.impl.InMemoryDOMDataStoreConfigProperties;
+import org.opendaylight.mdsal.binding.generator.impl.GeneratedClassLoadingStrategy;
+import org.opendaylight.mdsal.binding.generator.impl.ModuleInfoBackedContext;
+import org.opendaylight.mdsal.binding.spec.reflect.BindingReflections;
+import org.opendaylight.mdsal.dom.api.DOMSchemaService;
+import org.opendaylight.mdsal.dom.store.inmemory.InMemoryDOMDataStoreConfigProperties;
+import org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.distributed.datastore.provider.rev140612.DataStorePropertiesContainer;
+import org.opendaylight.yangtools.yang.model.api.SchemaContext;
/**
* Unit tests for DatastoreContextIntrospector.
*
* @author Thomas Pantelis
*/
+@SuppressWarnings("checkstyle:IllegalCatch")
public class DatastoreContextIntrospectorTest {
+ static SchemaContext SCHEMA_CONTEXT;
+ static DatastoreContextIntrospectorFactory INTROSPECTOR_FACTORY;
+
+ static {
+ final ModuleInfoBackedContext moduleContext = ModuleInfoBackedContext.create();
+ try {
+ moduleContext.addModuleInfos(Arrays.asList(
+ BindingReflections.getModuleInfo(DataStorePropertiesContainer.class)));
+ } catch (Exception e) {
+ throw new RuntimeException(e);
+ }
+ SCHEMA_CONTEXT = moduleContext.tryToCreateSchemaContext().get();
+
+ DOMSchemaService mockSchemaService = mock(DOMSchemaService.class);
+ doReturn(SCHEMA_CONTEXT).when(mockSchemaService).getGlobalContext();
+ INTROSPECTOR_FACTORY = new DatastoreContextIntrospectorFactory(mockSchemaService,
+ GeneratedClassLoadingStrategy.getTCCLClassLoadingStrategy());
+ }
+
+ @Test
+ public void testYangDefaults() {
+ final DatastoreContextIntrospector introspector = INTROSPECTOR_FACTORY.newInstance(
+ DatastoreContext.newBuilder().shardBatchedModificationCount(2)
+ .transactionDebugContextEnabled(true).build());
+ DatastoreContext context = introspector.getContext();
+
+ assertEquals(1000, context.getShardBatchedModificationCount());
+ assertEquals(false, context.isTransactionDebugContextEnabled());
+ }
+
@Test
public void testUpdate() {
- DatastoreContext context = DatastoreContext.newBuilder().
- logicalStoreType(LogicalDatastoreType.OPERATIONAL).build();
- DatastoreContextIntrospector introspector = new DatastoreContextIntrospector(context );
+ final DatastoreContextIntrospector introspector = INTROSPECTOR_FACTORY.newInstance(OPERATIONAL);
- Dictionary<String, Object> properties = new Hashtable<>();
+ final Map<String, Object> properties = new HashMap<>();
properties.put("shard-transaction-idle-timeout-in-minutes", "31");
properties.put("operation-timeout-in-seconds", "26");
properties.put("shard-transaction-commit-timeout-in-seconds", "100");
boolean updated = introspector.update(properties);
assertEquals("updated", true, updated);
- context = introspector.getContext();
+ DatastoreContext context = introspector.getContext();
assertEquals(31, context.getShardTransactionIdleTimeout().toMinutes());
assertEquals(26000, context.getOperationTimeoutInMillis());
updated = introspector.update(null);
assertEquals("updated", false, updated);
- updated = introspector.update(new Hashtable<String, Object>());
+ updated = introspector.update(new Hashtable<>());
assertEquals("updated", false, updated);
}
@Test
public void testUpdateWithInvalidValues() {
- DatastoreContext context = DatastoreContext.newBuilder().
- logicalStoreType(LogicalDatastoreType.OPERATIONAL).build();
- DatastoreContextIntrospector introspector = new DatastoreContextIntrospector(context );
+ final DatastoreContextIntrospector introspector = INTROSPECTOR_FACTORY.newInstance(OPERATIONAL);
- Dictionary<String, Object> properties = new Hashtable<>();
+ final Map<String, Object> properties = new HashMap<>();
properties.put("shard-transaction-idle-timeout-in-minutes", "0"); // bad - must be > 0
properties.put("shard-journal-recovery-log-batch-size", "199");
properties.put("shard-transaction-commit-timeout-in-seconds", "bogus"); // bad - NaN
properties.put("max-shard-data-change-executor-pool-size", "bogus"); // bad - NaN
properties.put("unknownProperty", "1"); // bad - invalid property name
- boolean updated = introspector.update(properties);
+ final boolean updated = introspector.update(properties);
assertEquals("updated", true, updated);
- context = introspector.getContext();
+ DatastoreContext context = introspector.getContext();
assertEquals(DEFAULT_SHARD_TRANSACTION_IDLE_TIMEOUT, context.getShardTransactionIdleTimeout());
assertEquals(199, context.getShardRaftConfig().getJournalRecoveryLogBatchSize());
assertEquals(DEFAULT_SHARD_TX_COMMIT_TIMEOUT_IN_SECONDS, context.getShardTransactionCommitTimeoutInSeconds());
assertEquals(212, context.getShardRaftConfig().getSnapshotBatchCount());
assertEquals(DEFAULT_OPERATION_TIMEOUT_IN_MS, context.getOperationTimeoutInMillis());
- assertEquals(DEFAULT_HEARTBEAT_INTERVAL_IN_MILLIS, context.getShardRaftConfig().getHeartBeatInterval().length());
+ assertEquals(DEFAULT_HEARTBEAT_INTERVAL_IN_MILLIS,
+ context.getShardRaftConfig().getHeartBeatInterval().length());
assertEquals(567, context.getShardTransactionCommitQueueCapacity());
assertEquals(DEFAULT_SHARD_SNAPSHOT_DATA_THRESHOLD_PERCENTAGE,
context.getShardRaftConfig().getSnapshotDataThresholdPercentage());
@Test
public void testUpdateWithDatastoreTypeSpecificProperties() {
- Dictionary<String, Object> properties = new Hashtable<>();
+ final Map<String, Object> properties = new HashMap<>();
properties.put("shard-transaction-idle-timeout-in-minutes", "22"); // global setting
properties.put("operational.shard-transaction-idle-timeout-in-minutes", "33"); // operational override
properties.put("config.shard-transaction-idle-timeout-in-minutes", "44"); // config override
properties.put("persistent", "false"); // global setting
properties.put("operational.Persistent", "true"); // operational override
- DatastoreContext operContext = DatastoreContext.newBuilder().
- logicalStoreType(LogicalDatastoreType.OPERATIONAL).build();
- DatastoreContextIntrospector operIntrospector = new DatastoreContextIntrospector(operContext);
+ final DatastoreContextIntrospector operIntrospector = INTROSPECTOR_FACTORY.newInstance(OPERATIONAL);
boolean updated = operIntrospector.update(properties);
assertEquals("updated", true, updated);
- operContext = operIntrospector.getContext();
+ DatastoreContext operContext = operIntrospector.getContext();
assertEquals(33, operContext.getShardTransactionIdleTimeout().toMinutes());
assertEquals(true, operContext.isPersistent());
assertEquals(333, operContext.getDataStoreProperties().getMaxDataChangeExecutorPoolSize());
- DatastoreContext configContext = DatastoreContext.newBuilder()
- .logicalStoreType(LogicalDatastoreType.CONFIGURATION).build();
- DatastoreContextIntrospector configIntrospector = new DatastoreContextIntrospector(configContext);
+ final DatastoreContextIntrospector configIntrospector = INTROSPECTOR_FACTORY.newInstance(CONFIGURATION);
updated = configIntrospector.update(properties);
assertEquals("updated", true, updated);
- configContext = configIntrospector.getContext();
+ DatastoreContext configContext = configIntrospector.getContext();
assertEquals(44, configContext.getShardTransactionIdleTimeout().toMinutes());
assertEquals(false, configContext.isPersistent());
@Test
public void testGetDatastoreContextForShard() {
- Dictionary<String, Object> properties = new Hashtable<>();
+ final Map<String, Object> properties = new HashMap<>();
properties.put("shard-transaction-idle-timeout-in-minutes", "22"); // global setting
properties.put("operational.shard-transaction-idle-timeout-in-minutes", "33"); // operational override
properties.put("config.shard-transaction-idle-timeout-in-minutes", "44"); // config override
properties.put("topology.shard-transaction-idle-timeout-in-minutes", "55"); // global shard override
- DatastoreContext operContext = DatastoreContext.newBuilder().
- logicalStoreType(LogicalDatastoreType.OPERATIONAL).build();
- DatastoreContextIntrospector operIntrospector = new DatastoreContextIntrospector(operContext);
+ final DatastoreContextIntrospector operIntrospector = INTROSPECTOR_FACTORY.newInstance(OPERATIONAL);
DatastoreContext shardContext = operIntrospector.newContextFactory().getShardDatastoreContext("topology");
assertEquals(10, shardContext.getShardTransactionIdleTimeout().toMinutes());
operIntrospector.update(properties);
- operContext = operIntrospector.getContext();
+ DatastoreContext operContext = operIntrospector.getContext();
assertEquals(33, operContext.getShardTransactionIdleTimeout().toMinutes());
shardContext = operIntrospector.newContextFactory().getShardDatastoreContext("topology");
assertEquals(55, shardContext.getShardTransactionIdleTimeout().toMinutes());
- DatastoreContext configContext = DatastoreContext.newBuilder().
- logicalStoreType(LogicalDatastoreType.CONFIGURATION).build();
- DatastoreContextIntrospector configIntrospector = new DatastoreContextIntrospector(configContext);
+ final DatastoreContextIntrospector configIntrospector = INTROSPECTOR_FACTORY.newInstance(CONFIGURATION);
configIntrospector.update(properties);
- configContext = configIntrospector.getContext();
+ DatastoreContext configContext = configIntrospector.getContext();
assertEquals(44, configContext.getShardTransactionIdleTimeout().toMinutes());
shardContext = configIntrospector.newContextFactory().getShardDatastoreContext("topology");
assertEquals(55, shardContext.getShardTransactionIdleTimeout().toMinutes());
- properties.put("operational.topology.shard-transaction-idle-timeout-in-minutes", "66"); // operational shard override
- properties.put("config.topology.shard-transaction-idle-timeout-in-minutes", "77"); // config shard override
+ // operational shard override
+ properties.put("operational.topology.shard-transaction-idle-timeout-in-minutes", "66");
+ // config shard override
+ properties.put("config.topology.shard-transaction-idle-timeout-in-minutes", "77");
operIntrospector.update(properties);
shardContext = operIntrospector.newContextFactory().getShardDatastoreContext("topology");
Code Review / controller.git / blobdiff