+/*
+ * Copyright (c) 2015 Cisco Systems, Inc. and others. All rights reserved.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v1.0 which accompanies this distribution,
+ * and is available at http://www.eclipse.org/legal/epl-v10.html
+ */
+
package org.opendaylight.controller.cluster.datastore;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertTrue;
import com.google.common.base.Optional;
+import java.math.BigInteger;
+import java.util.ArrayList;
+import java.util.List;
import java.util.concurrent.ExecutionException;
+import org.junit.Before;
import org.junit.Test;
import org.opendaylight.controller.md.cluster.datastore.model.CarsModel;
import org.opendaylight.controller.md.cluster.datastore.model.PeopleModel;
import org.opendaylight.controller.md.cluster.datastore.model.SchemaContextHelper;
import org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode;
+import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeCandidateTip;
+import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeCandidates;
import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeModification;
import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeSnapshot;
+import org.opendaylight.yangtools.yang.data.api.schema.tree.TreeType;
import org.opendaylight.yangtools.yang.model.api.SchemaContext;
public class ShardDataTreeTest {
- @Test
- public void testWrite() throws ExecutionException, InterruptedException {
-
- SchemaContext schemaContext = SchemaContextHelper.full();
+ SchemaContext fullSchema;
- modify(new ShardDataTree(schemaContext), false, true, true);
+ @Before
+ public void setUp(){
+ fullSchema = SchemaContextHelper.full();
}
@Test
- public void testWriteWithMissingSchema() throws ExecutionException, InterruptedException {
-
- SchemaContext schemaContext = SchemaContextHelper.select(SchemaContextHelper.ODL_DATASTORE_TEST_YANG, SchemaContextHelper.PEOPLE_YANG);
-
- modify(new ShardDataTree(schemaContext), false, false, true);
+ public void testWrite() throws ExecutionException, InterruptedException {
+ modify(new ShardDataTree(fullSchema, TreeType.OPERATIONAL), false, true, true);
}
@Test
public void testMerge() throws ExecutionException, InterruptedException {
-
- SchemaContext schemaContext = SchemaContextHelper.full();
-
- modify(new ShardDataTree(schemaContext), true, true, true);
+ modify(new ShardDataTree(fullSchema, TreeType.OPERATIONAL), true, true, true);
}
- @Test
- public void testMergeWithMissingSchema() throws ExecutionException, InterruptedException {
- SchemaContext schemaContext = SchemaContextHelper.select(SchemaContextHelper.ODL_DATASTORE_TEST_YANG, SchemaContextHelper.PEOPLE_YANG);
+ private void modify(ShardDataTree shardDataTree, boolean merge, boolean expectedCarsPresent, boolean expectedPeoplePresent) throws ExecutionException, InterruptedException {
- modify(new ShardDataTree(schemaContext), true, false, true);
- }
+ assertEquals(fullSchema, shardDataTree.getSchemaContext());
- private void modify(ShardDataTree shardDataTree, boolean merge, boolean expectedCarsPresent, boolean expectedPeoplePresent) throws ExecutionException, InterruptedException {
ReadWriteShardDataTreeTransaction transaction = shardDataTree.newReadWriteTransaction("txn-1", null);
DataTreeModification snapshot = transaction.getSnapshot();
}
- @Test(expected = IllegalArgumentException.class)
- public void testAfterRecoveryDone() throws ExecutionException, InterruptedException {
- SchemaContext schemaContext = SchemaContextHelper.select(SchemaContextHelper.ODL_DATASTORE_TEST_YANG, SchemaContextHelper.PEOPLE_YANG);
- ShardDataTree shardDataTree = new ShardDataTree(schemaContext);
- assertTrue("transaction factory must be the recovery transaction factory",
- shardDataTree.getTransactionFactory() instanceof ShardDataTree.RecoveryShardDataTreeTransactionFactory);
- shardDataTree.recoveryDone();
- assertTrue("transaction factory must be the regular transaction factory",
- shardDataTree.getTransactionFactory() instanceof ShardDataTree.RegularShardDataTreeTransactionFactory);
+ @Test
+ public void bug4359AddRemoveCarOnce() throws ExecutionException, InterruptedException {
+ ShardDataTree shardDataTree = new ShardDataTree(fullSchema, TreeType.OPERATIONAL);
+
+ List<DataTreeCandidateTip> candidates = new ArrayList<>();
+ candidates.add(addCar(shardDataTree));
+ candidates.add(removeCar(shardDataTree));
+
+ NormalizedNode<?, ?> expected = getCars(shardDataTree);
+
+ applyCandidates(shardDataTree, candidates);
+
+ NormalizedNode<?, ?> actual = getCars(shardDataTree);
+
+ assertEquals(expected, actual);
+ }
+
+ @Test
+ public void bug4359AddRemoveCarTwice() throws ExecutionException, InterruptedException {
+ ShardDataTree shardDataTree = new ShardDataTree(fullSchema, TreeType.OPERATIONAL);
+
+ List<DataTreeCandidateTip> candidates = new ArrayList<>();
+ candidates.add(addCar(shardDataTree));
+ candidates.add(removeCar(shardDataTree));
+ candidates.add(addCar(shardDataTree));
+ candidates.add(removeCar(shardDataTree));
- modify(shardDataTree, true, false, true);
+ NormalizedNode<?, ?> expected = getCars(shardDataTree);
+
+ applyCandidates(shardDataTree, candidates);
+
+ NormalizedNode<?, ?> actual = getCars(shardDataTree);
+
+ assertEquals(expected, actual);
+ }
+
+ private static NormalizedNode<?, ?> getCars(ShardDataTree shardDataTree) {
+ ReadOnlyShardDataTreeTransaction readOnlyShardDataTreeTransaction = shardDataTree.newReadOnlyTransaction("txn-2", null);
+ DataTreeSnapshot snapshot1 = readOnlyShardDataTreeTransaction.getSnapshot();
+
+ Optional<NormalizedNode<?, ?>> optional = snapshot1.readNode(CarsModel.BASE_PATH);
+
+ assertEquals(true, optional.isPresent());
+
+ System.out.println(optional.get());
+
+ return optional.get();
+ }
+
+ private static DataTreeCandidateTip addCar(ShardDataTree shardDataTree) throws ExecutionException, InterruptedException {
+ return doTransaction(shardDataTree, new DataTreeOperation() {
+ @Override
+ public void execute(DataTreeModification snapshot) {
+ snapshot.merge(CarsModel.BASE_PATH, CarsModel.emptyContainer());
+ snapshot.merge(CarsModel.CAR_LIST_PATH, CarsModel.newCarMapNode());
+ snapshot.write(CarsModel.newCarPath("altima"), CarsModel.newCarEntry("altima", new BigInteger("100")));
+ }
+ });
+ }
+
+ private static DataTreeCandidateTip removeCar(ShardDataTree shardDataTree) throws ExecutionException, InterruptedException {
+ return doTransaction(shardDataTree, new DataTreeOperation() {
+ @Override
+ public void execute(DataTreeModification snapshot) {
+ snapshot.delete(CarsModel.newCarPath("altima"));
+ }
+ });
+ }
+
+ private abstract static class DataTreeOperation {
+ public abstract void execute(DataTreeModification snapshot);
+ }
+
+ private static DataTreeCandidateTip doTransaction(ShardDataTree shardDataTree, DataTreeOperation operation)
+ throws ExecutionException, InterruptedException {
+ ReadWriteShardDataTreeTransaction transaction = shardDataTree.newReadWriteTransaction("txn-1", null);
+ DataTreeModification snapshot = transaction.getSnapshot();
+ operation.execute(snapshot);
+ ShardDataTreeCohort cohort = shardDataTree.finishTransaction(transaction);
+
+ cohort.canCommit().get();
+ cohort.preCommit().get();
+ DataTreeCandidateTip candidate = cohort.getCandidate();
+ cohort.commit().get();
+
+ return candidate;
+ }
+
+ private static DataTreeCandidateTip applyCandidates(ShardDataTree shardDataTree, List<DataTreeCandidateTip> candidates)
+ throws ExecutionException, InterruptedException {
+ ReadWriteShardDataTreeTransaction transaction = shardDataTree.newReadWriteTransaction("txn-1", null);
+ DataTreeModification snapshot = transaction.getSnapshot();
+ for(DataTreeCandidateTip candidateTip : candidates){
+ DataTreeCandidates.applyToModification(snapshot, candidateTip);
+ }
+ ShardDataTreeCohort cohort = shardDataTree.finishTransaction(transaction);
+
+ cohort.canCommit().get();
+ cohort.preCommit().get();
+ DataTreeCandidateTip candidate = cohort.getCandidate();
+ cohort.commit().get();
+ return candidate;
}
}
\ No newline at end of file
Code Review / controller.git / blobdiff