import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import akka.actor.Status;
import akka.actor.Status.Failure;
import akka.actor.Status.Success;
-import akka.actor.Terminated;
import akka.cluster.Cluster;
import akka.cluster.ClusterEvent;
import akka.dispatch.Dispatchers;
import akka.util.Timeout;
import com.google.common.base.Function;
import com.google.common.base.Optional;
+import com.google.common.base.Stopwatch;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Lists;
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException;
+import org.apache.commons.lang3.SerializationUtils;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.opendaylight.controller.cluster.datastore.messages.ShardLeaderStateChanged;
import org.opendaylight.controller.cluster.datastore.messages.SwitchShardBehavior;
import org.opendaylight.controller.cluster.datastore.messages.UpdateSchemaContext;
+import org.opendaylight.controller.cluster.datastore.utils.ForwardingActor;
import org.opendaylight.controller.cluster.datastore.utils.MockClusterWrapper;
import org.opendaylight.controller.cluster.datastore.utils.MockConfiguration;
import org.opendaylight.controller.cluster.datastore.utils.PrimaryShardInfoFutureCache;
import org.opendaylight.controller.cluster.raft.base.messages.FollowerInitialSyncUpStatus;
import org.opendaylight.controller.cluster.raft.base.messages.SwitchBehavior;
import org.opendaylight.controller.cluster.raft.client.messages.GetSnapshot;
+import org.opendaylight.controller.cluster.raft.client.messages.Shutdown;
import org.opendaylight.controller.cluster.raft.messages.AddServer;
import org.opendaylight.controller.cluster.raft.messages.AddServerReply;
+import org.opendaylight.controller.cluster.raft.messages.RemoveServer;
+import org.opendaylight.controller.cluster.raft.messages.RemoveServerReply;
import org.opendaylight.controller.cluster.raft.messages.ServerChangeStatus;
import org.opendaylight.controller.cluster.raft.messages.ServerRemoved;
import org.opendaylight.controller.cluster.raft.policy.DisableElectionsRaftPolicy;
import org.opendaylight.controller.md.cluster.datastore.model.TestModel;
import org.opendaylight.yangtools.yang.data.api.schema.tree.DataTree;
import org.opendaylight.yangtools.yang.model.api.SchemaContext;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import scala.concurrent.Await;
import scala.concurrent.Future;
import scala.concurrent.duration.FiniteDuration;
public class ShardManagerTest extends AbstractActorTest {
+ private static final Logger LOG = LoggerFactory.getLogger(ShardManagerTest.class);
+
private static int ID_COUNTER = 1;
private final String shardMrgIDSuffix = "config" + ID_COUNTER++;
private static String mockShardName;
private final DatastoreContext.Builder datastoreContextBuilder = DatastoreContext.newBuilder().
- dataStoreType(shardMrgIDSuffix).shardInitializationTimeout(600, TimeUnit.MILLISECONDS)
+ dataStoreName(shardMrgIDSuffix).shardInitializationTimeout(600, TimeUnit.MILLISECONDS)
.shardHeartbeatIntervalInMillis(100).shardElectionTimeoutFactor(6);
private final Collection<ActorSystem> actorSystems = new ArrayList<>();
}
private TestShardManager.Builder newTestShardMgrBuilderWithMockShardActor() {
- return TestShardManager.builder(datastoreContextBuilder).shardActor(mockShardActor);
+ return newTestShardMgrBuilderWithMockShardActor(mockShardActor);
+ }
+
+ private TestShardManager.Builder newTestShardMgrBuilderWithMockShardActor(ActorRef shardActor) {
+ return TestShardManager.builder(datastoreContextBuilder).shardActor(shardActor);
}
+
private Props newPropsShardMgrWithMockShardActor() {
return newTestShardMgrBuilderWithMockShardActor().props();
}
+ private Props newPropsShardMgrWithMockShardActor(ActorRef shardActor) {
+ return newTestShardMgrBuilderWithMockShardActor(shardActor).props();
+ }
+
+
private TestShardManager newTestShardManager() {
return newTestShardManager(newShardMgrProps());
}
return shardManager;
}
+ private void waitForShardInitialized(ActorRef shardManager, String shardName, JavaTestKit kit) {
+ AssertionError last = null;
+ Stopwatch sw = Stopwatch.createStarted();
+ while(sw.elapsed(TimeUnit.SECONDS) <= 5) {
+ try {
+ shardManager.tell(new FindLocalShard(shardName, true), kit.getRef());
+ kit.expectMsgClass(LocalShardFound.class);
+ return;
+ } catch(AssertionError e) {
+ last = e;
+ }
+
+ Uninterruptibles.sleepUninterruptibly(50, TimeUnit.MILLISECONDS);
+ }
+
+ throw last;
+ }
+
+ private <T> T expectMsgClassOrFailure(Class<T> msgClass, JavaTestKit kit, String msg) {
+ Object reply = kit.expectMsgAnyClassOf(JavaTestKit.duration("5 sec"), msgClass, Failure.class);
+ if(reply instanceof Failure) {
+ throw new AssertionError(msg + " failed", ((Failure)reply).cause());
+ }
+
+ return (T)reply;
+ }
+
@Test
public void testPerShardDatastoreContext() throws Exception {
+ LOG.info("testPerShardDatastoreContext starting");
final DatastoreContextFactory mockFactory = newDatastoreContextFactory(
datastoreContextBuilder.shardElectionTimeoutFactor(5).build());
newContext = MessageCollectorActor.expectFirstMatching(topologyShardActor, DatastoreContext.class);
assertEquals("getShardElectionTimeoutFactor", 77, newContext.getShardElectionTimeoutFactor());
+
+ LOG.info("testPerShardDatastoreContext ending");
}
@Test
@Test
public void testOnReceiveFindPrimaryForLocalLeaderShard() throws Exception {
+ LOG.info("testOnReceiveFindPrimaryForLocalLeaderShard starting");
new JavaTestKit(getSystem()) {{
String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
primaryFound.getPrimaryPath().contains("member-1-shard-default"));
assertSame("getLocalShardDataTree", mockDataTree, primaryFound.getLocalShardDataTree());
}};
+
+ LOG.info("testOnReceiveFindPrimaryForLocalLeaderShard ending");
}
@Test
public void testOnReceiveFindPrimaryForNonLocalLeaderShardBeforeMemberUp() throws Exception {
+ LOG.info("testOnReceiveFindPrimaryForNonLocalLeaderShardBeforeMemberUp starting");
new JavaTestKit(getSystem()) {{
final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
expectMsgClass(duration("5 seconds"), NoShardLeaderException.class);
}};
+
+ LOG.info("testOnReceiveFindPrimaryForNonLocalLeaderShardBeforeMemberUp ending");
}
@Test
public void testOnReceiveFindPrimaryForNonLocalLeaderShard() throws Exception {
+ LOG.info("testOnReceiveFindPrimaryForNonLocalLeaderShard starting");
new JavaTestKit(getSystem()) {{
final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
primaryFound.getPrimaryPath().contains("member-2-shard-default"));
assertEquals("getPrimaryVersion", leaderVersion, primaryFound.getPrimaryVersion());
}};
+
+ LOG.info("testOnReceiveFindPrimaryForNonLocalLeaderShard ending");
}
@Test
@Test
public void testOnReceiveFindPrimaryForFollowerShardWithNoInitialLeaderId() throws Exception {
+ LOG.info("testOnReceiveFindPrimaryForFollowerShardWithNoInitialLeaderId starting");
new JavaTestKit(getSystem()) {{
final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
primaryFound.getPrimaryPath().contains("member-1-shard-default"));
assertSame("getLocalShardDataTree", mockDataTree, primaryFound.getLocalShardDataTree());
}};
+
+ LOG.info("testOnReceiveFindPrimaryForFollowerShardWithNoInitialLeaderId starting");
}
@Test
public void testOnReceiveFindPrimaryWaitForShardLeader() throws Exception {
+ LOG.info("testOnReceiveFindPrimaryWaitForShardLeader starting");
new JavaTestKit(getSystem()) {{
final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
expectNoMsg(FiniteDuration.create(200, TimeUnit.MILLISECONDS));
}};
+
+ LOG.info("testOnReceiveFindPrimaryWaitForShardLeader ending");
}
@Test
public void testOnReceiveFindPrimaryWaitForReadyWithUninitializedShard() throws Exception {
+ LOG.info("testOnReceiveFindPrimaryWaitForReadyWithUninitializedShard starting");
new JavaTestKit(getSystem()) {{
final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
expectNoMsg(FiniteDuration.create(200, TimeUnit.MILLISECONDS));
}};
+
+ LOG.info("testOnReceiveFindPrimaryWaitForReadyWithUninitializedShard ending");
}
@Test
public void testOnReceiveFindPrimaryWaitForReadyWithCandidateShard() throws Exception {
+ LOG.info("testOnReceiveFindPrimaryWaitForReadyWithCandidateShard starting");
new JavaTestKit(getSystem()) {{
final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
expectMsgClass(duration("2 seconds"), NoShardLeaderException.class);
}};
+
+ LOG.info("testOnReceiveFindPrimaryWaitForReadyWithCandidateShard ending");
}
@Test
public void testOnReceiveFindPrimaryWaitForReadyWithIsolatedLeaderShard() throws Exception {
+ LOG.info("testOnReceiveFindPrimaryWaitForReadyWithIsolatedLeaderShard starting");
new JavaTestKit(getSystem()) {{
final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
expectMsgClass(duration("2 seconds"), NoShardLeaderException.class);
}};
+
+ LOG.info("testOnReceiveFindPrimaryWaitForReadyWithIsolatedLeaderShard ending");
}
@Test
public void testOnReceiveFindPrimaryWaitForReadyWithNoRoleShard() throws Exception {
+ LOG.info("testOnReceiveFindPrimaryWaitForReadyWithNoRoleShard starting");
new JavaTestKit(getSystem()) {{
final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
expectMsgClass(duration("2 seconds"), NoShardLeaderException.class);
}};
+
+ LOG.info("testOnReceiveFindPrimaryWaitForReadyWithNoRoleShard ending");
}
@Test
public void testOnReceiveFindPrimaryForRemoteShard() throws Exception {
+ LOG.info("testOnReceiveFindPrimaryForRemoteShard starting");
String shardManagerID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
// Create an ActorSystem ShardManager actor for member-1.
expectMsgClass(duration("5 seconds"), PrimaryNotFoundException.class);
}};
+
+ LOG.info("testOnReceiveFindPrimaryForRemoteShard ending");
}
@Test
public void testShardAvailabilityOnChangeOfMemberReachability() throws Exception {
+ LOG.info("testShardAvailabilityOnChangeOfMemberReachability starting");
String shardManagerID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
// Create an ActorSystem ShardManager actor for member-1.
MessageCollectorActor.expectFirstMatching(mockShardActor1, PeerUp.class);
+ // Test FindPrimary wait succeeds after reachable member event.
+
+ shardManager1.underlyingActor().onReceiveCommand(MockClusterWrapper.
+ createUnreachableMember("member-2", "akka.tcp://cluster-test@127.0.0.1:2558"));
+ shardManager1.underlyingActor().waitForUnreachableMember();
+
+ shardManager1.tell(new FindPrimary("default", true), getRef());
+
+ shardManager1.underlyingActor().onReceiveCommand(MockClusterWrapper.
+ createReachableMember("member-2", "akka.tcp://cluster-test@127.0.0.1:2558"));
+
+ RemotePrimaryShardFound found2 = expectMsgClass(duration("5 seconds"), RemotePrimaryShardFound.class);
+ String path2 = found2.getPrimaryPath();
+ assertTrue("Unexpected primary path " + path2, path2.contains("member-2-shard-default-config"));
}};
+
+ LOG.info("testShardAvailabilityOnChangeOfMemberReachability ending");
}
@Test
public void testShardAvailabilityChangeOnMemberUnreachableAndLeadershipChange() throws Exception {
+ LOG.info("testShardAvailabilityChangeOnMemberUnreachableAndLeadershipChange starting");
String shardManagerID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
// Create an ActorSystem ShardManager actor for member-1.
assertTrue("Unexpected primary path " + path1, path1.contains("member-1-shard-default-config"));
}};
+
+ LOG.info("testShardAvailabilityChangeOnMemberUnreachableAndLeadershipChange ending");
}
@Test
public void testOnReceiveFindLocalShardWaitForShardInitialized() throws Exception {
+ LOG.info("testOnReceiveFindLocalShardWaitForShardInitialized starting");
new JavaTestKit(getSystem()) {{
final ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
Object resp = Await.result(future, duration("5 seconds"));
assertTrue("Expected: LocalShardFound, Actual: " + resp, resp instanceof LocalShardFound);
}};
+
+ LOG.info("testOnReceiveFindLocalShardWaitForShardInitialized starting");
}
@Test
@Test
public void testWhenMultipleShardsPresentSyncStatusMustBeTrueForAllShards() throws Exception{
+ LOG.info("testWhenMultipleShardsPresentSyncStatusMustBeTrueForAllShards starting");
TestShardManager shardManager = newTestShardManager(newShardMgrProps(new MockConfiguration() {
@Override
public List<String> getMemberShardNames(String memberName) {
// Sync status is now true
assertEquals(true, shardManager.getMBean().getSyncStatus());
+ LOG.info("testWhenMultipleShardsPresentSyncStatusMustBeTrueForAllShards ending");
}
@Test
@Test
public void testOnCreateShard() {
+ LOG.info("testOnCreateShard starting");
new JavaTestKit(getSystem()) {{
datastoreContextBuilder.shardInitializationTimeout(1, TimeUnit.MINUTES).persistent(true);
Success success = expectMsgClass(duration("5 seconds"), Success.class);
assertNotNull("Success status is null", success.status());
}};
+
+ LOG.info("testOnCreateShard ending");
}
@Test
public void testOnCreateShardWithLocalMemberNotInShardConfig() {
+ LOG.info("testOnCreateShardWithLocalMemberNotInShardConfig starting");
new JavaTestKit(getSystem()) {{
datastoreContextBuilder.shardInitializationTimeout(1, TimeUnit.MINUTES).persistent(true);
assertEquals("schemaContext", DisableElectionsRaftPolicy.class.getName(),
shardBuilder.getDatastoreContext().getShardRaftConfig().getCustomRaftPolicyImplementationClass());
}};
+
+ LOG.info("testOnCreateShardWithLocalMemberNotInShardConfig ending");
}
@Test
public void testOnCreateShardWithNoInitialSchemaContext() {
+ LOG.info("testOnCreateShardWithNoInitialSchemaContext starting");
new JavaTestKit(getSystem()) {{
ActorRef shardManager = actorFactory.createActor(newShardMgrProps(
new ConfigurationImpl(new EmptyModuleShardConfigProvider())));
assertSame("schemaContext", schemaContext, shardBuilder.getSchemaContext());
assertNotNull("schemaContext is null", shardBuilder.getDatastoreContext());
}};
+
+ LOG.info("testOnCreateShardWithNoInitialSchemaContext ending");
}
@Test
public void testGetSnapshot() throws Throwable {
+ LOG.info("testGetSnapshot starting");
JavaTestKit kit = new JavaTestKit(getSystem());
MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder().
put("shard1", Arrays.asList("member-1")).
- put("shard2", Arrays.asList("member-1")).build());
+ put("shard2", Arrays.asList("member-1")).
+ put("astronauts", Collections.<String>emptyList()).build());
- ActorRef shardManager = actorFactory.createActor(newShardMgrProps(mockConfig).withDispatcher(
- Dispatchers.DefaultDispatcherId()));
+ TestActorRef<TestShardManager> shardManager = actorFactory.createTestActor(newShardMgrProps(mockConfig).
+ withDispatcher(Dispatchers.DefaultDispatcherId()));
shardManager.tell(GetSnapshot.INSTANCE, kit.getRef());
Failure failure = kit.expectMsgClass(Failure.class);
assertEquals("Failure cause type", IllegalStateException.class, failure.cause().getClass());
- kit = new JavaTestKit(getSystem());
-
shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), ActorRef.noSender());
- shardManager.tell(new FindLocalShard("shard1", true), kit.getRef());
- kit.expectMsgClass(LocalShardFound.class);
- shardManager.tell(new FindLocalShard("shard2", true), kit.getRef());
- kit.expectMsgClass(LocalShardFound.class);
+ waitForShardInitialized(shardManager, "shard1", kit);
+ waitForShardInitialized(shardManager, "shard2", kit);
shardManager.tell(GetSnapshot.INSTANCE, kit.getRef());
- DatastoreSnapshot datastoreSnapshot = kit.expectMsgClass(DatastoreSnapshot.class);
+ DatastoreSnapshot datastoreSnapshot = expectMsgClassOrFailure(DatastoreSnapshot.class, kit, "GetSnapshot");
assertEquals("getType", shardMrgIDSuffix, datastoreSnapshot.getType());
assertNull("Expected null ShardManagerSnapshot", datastoreSnapshot.getShardManagerSnapshot());
assertEquals("Shard names", Sets.newHashSet("shard1", "shard2"), Sets.newHashSet(
Lists.transform(datastoreSnapshot.getShardSnapshots(), shardNameTransformer)));
+
+ // Add a new replica
+
+ JavaTestKit mockShardLeaderKit = new JavaTestKit(getSystem());
+
+ TestShardManager shardManagerInstance = shardManager.underlyingActor();
+ shardManagerInstance.setMessageInterceptor(newFindPrimaryInterceptor(mockShardLeaderKit.getRef()));
+
+ shardManager.tell(new AddShardReplica("astronauts"), kit.getRef());
+ mockShardLeaderKit.expectMsgClass(AddServer.class);
+ mockShardLeaderKit.reply(new AddServerReply(ServerChangeStatus.OK, ""));
+ kit.expectMsgClass(Status.Success.class);
+ waitForShardInitialized(shardManager, "astronauts", kit);
+
+ // Send another GetSnapshot and verify
+
+ shardManager.tell(GetSnapshot.INSTANCE, kit.getRef());
+ datastoreSnapshot = expectMsgClassOrFailure(DatastoreSnapshot.class, kit, "GetSnapshot");
+
+ assertEquals("Shard names", Sets.newHashSet("shard1", "shard2", "astronauts"), Sets.newHashSet(
+ Lists.transform(datastoreSnapshot.getShardSnapshots(), shardNameTransformer)));
+
+ byte[] snapshotBytes = datastoreSnapshot.getShardManagerSnapshot();
+ assertNotNull("Expected ShardManagerSnapshot", snapshotBytes);
+ ShardManagerSnapshot snapshot = SerializationUtils.deserialize(snapshotBytes);
+ assertEquals("Shard names", Sets.newHashSet("shard1", "shard2", "astronauts"),
+ Sets.newHashSet(snapshot.getShardList()));
+
+ LOG.info("testGetSnapshot ending");
+ }
+
+ @Test
+ public void testRestoreFromSnapshot() throws Throwable {
+ LOG.info("testRestoreFromSnapshot starting");
+
+ JavaTestKit kit = new JavaTestKit(getSystem());
+
+ MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder().
+ put("shard1", Collections.<String>emptyList()).
+ put("shard2", Collections.<String>emptyList()).
+ put("astronauts", Collections.<String>emptyList()).build());
+
+
+ ShardManagerSnapshot snapshot = new ShardManagerSnapshot(Arrays.asList("shard1", "shard2", "astronauts"));
+ DatastoreSnapshot restoreFromSnapshot = new DatastoreSnapshot(shardMrgIDSuffix,
+ SerializationUtils.serialize(snapshot), Collections.<ShardSnapshot>emptyList());
+ TestActorRef<TestShardManager> shardManager = actorFactory.createTestActor(newTestShardMgrBuilder(mockConfig).
+ restoreFromSnapshot(restoreFromSnapshot).props().withDispatcher(Dispatchers.DefaultDispatcherId()));
+
+ shardManager.underlyingActor().waitForRecoveryComplete();
+
+ shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), ActorRef.noSender());
+
+ waitForShardInitialized(shardManager, "shard1", kit);
+ waitForShardInitialized(shardManager, "shard2", kit);
+ waitForShardInitialized(shardManager, "astronauts", kit);
+
+ shardManager.tell(GetSnapshot.INSTANCE, kit.getRef());
+
+ DatastoreSnapshot datastoreSnapshot = expectMsgClassOrFailure(DatastoreSnapshot.class, kit, "GetSnapshot");
+
+ assertEquals("getType", shardMrgIDSuffix, datastoreSnapshot.getType());
+
+ byte[] snapshotBytes = datastoreSnapshot.getShardManagerSnapshot();
+ assertNotNull("Expected ShardManagerSnapshot", snapshotBytes);
+ snapshot = SerializationUtils.deserialize(snapshotBytes);
+ assertEquals("Shard names", Sets.newHashSet("shard1", "shard2", "astronauts"),
+ Sets.newHashSet(snapshot.getShardList()));
+
+ LOG.info("testRestoreFromSnapshot ending");
}
@Test
put("default", Arrays.asList("member-1", "member-2")).
put("astronauts", Arrays.asList("member-2")).build());
- String shardManagerID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
+ final String shardManagerID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
+ datastoreContextBuilder.shardManagerPersistenceId(shardManagerID);
// Create an ActorSystem ShardManager actor for member-1.
final ActorSystem system1 = newActorSystem("Member1");
newReplicaShardManager.underlyingActor().waitForMemberUp();
leaderShardManager.underlyingActor().waitForMemberUp();
+ //Have a dummy snapshot to be overwritten by the new data persisted.
+ String[] restoredShards = {"default", "people"};
+ ShardManagerSnapshot snapshot = new ShardManagerSnapshot(Arrays.asList(restoredShards));
+ InMemorySnapshotStore.addSnapshot(shardManagerID, snapshot);
+ Uninterruptibles.sleepUninterruptibly(2, TimeUnit.MILLISECONDS);
+
+ InMemorySnapshotStore.addSnapshotSavedLatch(shardManagerID);
+ InMemorySnapshotStore.addSnapshotDeletedLatch(shardManagerID);
+
//construct a mock response message
AddServerReply response = new AddServerReply(ServerChangeStatus.OK, memberId2);
mockShardLeaderActor.underlyingActor().updateResponse(response);
AddServer.class);
String addServerId = "member-1-shard-astronauts-" + shardMrgIDSuffix;
assertEquals("AddServer serverId", addServerId, addServerMsg.getNewServerId());
- newReplicaShardManager.underlyingActor()
- .verifySnapshotPersisted(Sets.newHashSet("default", "astronauts"));
expectMsgClass(duration("5 seconds"), Status.Success.class);
+
+ InMemorySnapshotStore.waitForSavedSnapshot(shardManagerID, ShardManagerSnapshot.class);
+ InMemorySnapshotStore.waitForDeletedSnapshot(shardManagerID);
+ List<ShardManagerSnapshot> persistedSnapshots =
+ InMemorySnapshotStore.getSnapshots(shardManagerID, ShardManagerSnapshot.class);
+ assertEquals("Number of snapshots persisted", 1, persistedSnapshots.size());
+ ShardManagerSnapshot shardManagerSnapshot = persistedSnapshots.get(0);
+ assertEquals("Persisted local shards", Sets.newHashSet("default", "astronauts"),
+ Sets.newHashSet(shardManagerSnapshot.getShardList()));
}};
+
+ LOG.info("testAddShardReplica ending");
}
@Test
public void testAddShardReplicaWithPreExistingReplicaInRemoteShardLeader() throws Exception {
+ LOG.info("testAddShardReplicaWithPreExistingReplicaInRemoteShardLeader starting");
new JavaTestKit(getSystem()) {{
TestActorRef<TestShardManager> shardManager = actorFactory.createTestActor(
newPropsShardMgrWithMockShardActor(), shardMgrID);
shardManager.tell(new FindLocalShard(Shard.DEFAULT_NAME, false), getRef());
expectMsgClass(duration("5 seconds"), LocalShardFound.class);
}};
+
+ LOG.info("testAddShardReplicaWithPreExistingReplicaInRemoteShardLeader ending");
}
@Test
public void testAddShardReplicaWithPreExistingLocalReplicaLeader() throws Exception {
+ LOG.info("testAddShardReplicaWithPreExistingLocalReplicaLeader starting");
new JavaTestKit(getSystem()) {{
String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
ActorRef shardManager = actorFactory.createActor(newPropsShardMgrWithMockShardActor());
shardManager.tell(new FindLocalShard(Shard.DEFAULT_NAME, false), getRef());
expectMsgClass(duration("5 seconds"), LocalShardFound.class);
}};
+
+ LOG.info("testAddShardReplicaWithPreExistingLocalReplicaLeader ending");
}
@Test
public void testAddShardReplicaWithAddServerReplyFailure() throws Exception {
+ LOG.info("testAddShardReplicaWithAddServerReplyFailure starting");
new JavaTestKit(getSystem()) {{
JavaTestKit mockShardLeaderKit = new JavaTestKit(getSystem());
failure = expectMsgClass(duration("5 seconds"), Failure.class);
assertEquals("Failure cause", NoShardLeaderException.class, failure.cause().getClass());
}};
+
+ LOG.info("testAddShardReplicaWithAddServerReplyFailure ending");
}
@Test
public void testAddShardReplicaWithAlreadyInProgress() throws Exception {
- new JavaTestKit(getSystem()) {{
- JavaTestKit mockShardLeaderKit = new JavaTestKit(getSystem());
- JavaTestKit secondRequestKit = new JavaTestKit(getSystem());
-
- MockConfiguration mockConfig =
- new MockConfiguration(ImmutableMap.<String, List<String>>builder().
- put("astronauts", Arrays.asList("member-2")).build());
-
- final TestActorRef<TestShardManager> shardManager = actorFactory.createTestActor(
- newTestShardMgrBuilder(mockConfig).shardActor(mockShardActor).props(), shardMgrID);
- shardManager.underlyingActor().setMessageInterceptor(newFindPrimaryInterceptor(mockShardLeaderKit.getRef()));
-
- shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
-
- shardManager.tell(new AddShardReplica("astronauts"), getRef());
-
- mockShardLeaderKit.expectMsgClass(AddServer.class);
-
- shardManager.tell(new AddShardReplica("astronauts"), secondRequestKit.getRef());
-
- secondRequestKit.expectMsgClass(duration("5 seconds"), Failure.class);
- }};
+ testServerChangeWhenAlreadyInProgress("astronauts", new AddShardReplica("astronauts"),
+ AddServer.class, new AddShardReplica("astronauts"));
}
@Test
public void testAddShardReplicaWithFindPrimaryTimeout() throws Exception {
+ LOG.info("testAddShardReplicaWithFindPrimaryTimeout starting");
new JavaTestKit(getSystem()) {{
MockConfiguration mockConfig = new MockConfiguration(ImmutableMap.<String, List<String>>builder().
put("astronauts", Arrays.asList("member-2")).build());
assertEquals("Failure obtained", true,
(resp.cause() instanceof RuntimeException));
}};
+
+ LOG.info("testAddShardReplicaWithFindPrimaryTimeout ending");
}
@Test
ActorRef shardManager = actorFactory.createActor(newShardMgrProps(
new ConfigurationImpl(new EmptyModuleShardConfigProvider())));
- shardManager.tell(new RemoveShardReplica("model-inventory"), getRef());
- Status.Failure resp = expectMsgClass(duration("2 seconds"), Status.Failure.class);
+ shardManager.tell(new RemoveShardReplica("model-inventory", "member-1"), getRef());
+ Status.Failure resp = expectMsgClass(duration("10 seconds"), Status.Failure.class);
assertEquals("Failure obtained", true,
- (resp.cause() instanceof IllegalArgumentException));
+ (resp.cause() instanceof PrimaryNotFoundException));
+ }};
+ }
+
+ @Test
+ /**
+ * Primary is Local
+ */
+ public void testRemoveShardReplicaLocal() throws Exception {
+ new JavaTestKit(getSystem()) {{
+ String memberId = "member-1-shard-default-" + shardMrgIDSuffix;
+
+ final TestActorRef<MockRespondActor> respondActor =
+ TestActorRef.create(getSystem(), Props.create(MockRespondActor.class), memberId);
+
+ ActorRef shardManager = getSystem().actorOf(newPropsShardMgrWithMockShardActor(respondActor));
+
+ shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
+ shardManager.tell(new ActorInitialized(), respondActor);
+ shardManager.tell(new ShardLeaderStateChanged(memberId, memberId, Optional.of(mock(DataTree.class)),
+ DataStoreVersions.CURRENT_VERSION), getRef());
+ shardManager.tell((new RoleChangeNotification(memberId, RaftState.Candidate.name(),
+ RaftState.Leader.name())), respondActor);
+
+ respondActor.underlyingActor().updateResponse(new RemoveServerReply(ServerChangeStatus.OK, null));
+ shardManager.tell(new RemoveShardReplica(Shard.DEFAULT_NAME, "member-1"), getRef());
+ final RemoveServer removeServer = MessageCollectorActor.expectFirstMatching(respondActor, RemoveServer.class);
+ assertEquals(new ShardIdentifier("default", "member-1", shardMrgIDSuffix).toString(),
+ removeServer.getServerId());
+ expectMsgClass(duration("5 seconds"), Success.class);
+ }};
+ }
+
+ @Test
+ public void testRemoveShardReplicaRemote() throws Exception {
+ MockConfiguration mockConfig =
+ new MockConfiguration(ImmutableMap.<String, List<String>>builder().
+ put("default", Arrays.asList("member-1", "member-2")).
+ put("astronauts", Arrays.asList("member-1")).build());
+
+ String shardManagerID = ShardManagerIdentifier.builder().type(shardMrgIDSuffix).build().toString();
+
+ // Create an ActorSystem ShardManager actor for member-1.
+ final ActorSystem system1 = newActorSystem("Member1");
+ Cluster.get(system1).join(AddressFromURIString.parse("akka.tcp://cluster-test@127.0.0.1:2558"));
+ ActorRef mockDefaultShardActor = newMockShardActor(system1, Shard.DEFAULT_NAME, "member-1");
+
+ final TestActorRef<TestShardManager> newReplicaShardManager = TestActorRef.create(system1,
+ newTestShardMgrBuilder().configuration(mockConfig).shardActor(mockDefaultShardActor).cluster(
+ new ClusterWrapperImpl(system1)).props(),
+ shardManagerID);
+
+ // Create an ActorSystem ShardManager actor for member-2.
+ final ActorSystem system2 = newActorSystem("Member2");
+ Cluster.get(system2).join(AddressFromURIString.parse("akka.tcp://cluster-test@127.0.0.1:2558"));
+
+ String name = new ShardIdentifier("default", "member-2", shardMrgIDSuffix).toString();
+ final TestActorRef<MockRespondActor> mockShardLeaderActor =
+ TestActorRef.create(system2, Props.create(MockRespondActor.class), name);
+
+ LOG.error("Mock Shard Leader Actor : {}", mockShardLeaderActor);
+
+ final TestActorRef<TestShardManager> leaderShardManager = TestActorRef.create(system2,
+ newTestShardMgrBuilder().configuration(mockConfig).shardActor(mockShardLeaderActor).cluster(
+ new ClusterWrapperImpl(system2)).props(),
+ shardManagerID);
+
+ // Because mockShardLeaderActor is created at the top level of the actor system it has an address like so,
+ // akka.tcp://cluster-test@127.0.0.1:2559/user/member-2-shard-default-config1
+ // However when a shard manager has a local shard which is a follower and a leader that is remote it will
+ // try to compute an address for the remote shard leader using the ShardPeerAddressResolver. This address will
+ // look like so,
+ // akka.tcp://cluster-test@127.0.0.1:2559/user/shardmanager-config1/member-2-shard-default-config1
+ // In this specific case if we did a FindPrimary for shard default from member-1 we would come up
+ // with the address of an actor which does not exist, therefore any message sent to that actor would go to
+ // dead letters.
+ // To work around this problem we create a ForwardingActor with the right address and pass to it the
+ // mockShardLeaderActor. The ForwardingActor simply forwards all messages to the mockShardLeaderActor and every
+ // thing works as expected
+ final ActorRef actorRef = leaderShardManager.underlyingActor().context()
+ .actorOf(Props.create(ForwardingActor.class, mockShardLeaderActor), "member-2-shard-default-" + shardMrgIDSuffix);
+
+ LOG.error("Forwarding actor : {}", actorRef);
+
+ new JavaTestKit(system1) {{
+
+ newReplicaShardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
+ leaderShardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
+
+ leaderShardManager.tell(new ActorInitialized(), mockShardLeaderActor);
+ newReplicaShardManager.tell(new ActorInitialized(), mockShardLeaderActor);
+
+ String memberId2 = "member-2-shard-default-" + shardMrgIDSuffix;
+ short leaderVersion = DataStoreVersions.CURRENT_VERSION - 1;
+ leaderShardManager.tell(new ShardLeaderStateChanged(memberId2, memberId2,
+ Optional.of(mock(DataTree.class)), leaderVersion), mockShardLeaderActor);
+ leaderShardManager.tell(new RoleChangeNotification(memberId2,
+ RaftState.Candidate.name(), RaftState.Leader.name()), mockShardLeaderActor);
+
+ String memberId1 = "member-1-shard-default-" + shardMrgIDSuffix;
+ newReplicaShardManager.tell(new ShardLeaderStateChanged(memberId1, memberId2,
+ Optional.of(mock(DataTree.class)), leaderVersion), mockShardActor);
+ newReplicaShardManager.tell(new RoleChangeNotification(memberId1,
+ RaftState.Candidate.name(), RaftState.Follower.name()), mockShardActor);
+
+ newReplicaShardManager.underlyingActor().waitForMemberUp();
+ leaderShardManager.underlyingActor().waitForMemberUp();
+
+ //construct a mock response message
+ RemoveServerReply response = new RemoveServerReply(ServerChangeStatus.OK, memberId2);
+ mockShardLeaderActor.underlyingActor().updateResponse(response);
+ newReplicaShardManager.tell(new RemoveShardReplica("default", "member-1"), getRef());
+ RemoveServer removeServer = MessageCollectorActor.expectFirstMatching(mockShardLeaderActor,
+ RemoveServer.class);
+ String removeServerId = new ShardIdentifier("default", "member-1", shardMrgIDSuffix).toString();
+ assertEquals("RemoveServer serverId", removeServerId, removeServer.getServerId());
+ expectMsgClass(duration("5 seconds"), Status.Success.class);
}};
}
+ @Test
+ public void testRemoveShardReplicaWhenAnotherRemoveShardReplicaAlreadyInProgress() throws Exception {
+ testServerChangeWhenAlreadyInProgress("astronauts", new RemoveShardReplica("astronauts", "member-2"),
+ RemoveServer.class, new RemoveShardReplica("astronauts", "member-3"));
+ }
+
+ @Test
+ public void testRemoveShardReplicaWhenAddShardReplicaAlreadyInProgress() throws Exception {
+ testServerChangeWhenAlreadyInProgress("astronauts", new AddShardReplica("astronauts"),
+ AddServer.class, new RemoveShardReplica("astronauts", "member-2"));
+ }
+
+
+ public void testServerChangeWhenAlreadyInProgress(final String shardName, final Object firstServerChange,
+ final Class firstForwardedServerChangeClass,
+ final Object secondServerChange) throws Exception {
+ new JavaTestKit(getSystem()) {{
+ JavaTestKit mockShardLeaderKit = new JavaTestKit(getSystem());
+ JavaTestKit secondRequestKit = new JavaTestKit(getSystem());
+
+ MockConfiguration mockConfig =
+ new MockConfiguration(ImmutableMap.<String, List<String>>builder().
+ put(shardName, Arrays.asList("member-2")).build());
+
+ final TestActorRef<TestShardManager> shardManager = TestActorRef.create(getSystem(),
+ newTestShardMgrBuilder().configuration(mockConfig).shardActor(mockShardActor).cluster(
+ new MockClusterWrapper()).props(),
+ shardMgrID);
+
+ shardManager.underlyingActor().setMessageInterceptor(newFindPrimaryInterceptor(mockShardLeaderKit.getRef()));
+
+ shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
+
+ shardManager.tell(firstServerChange, getRef());
+
+ mockShardLeaderKit.expectMsgClass(firstForwardedServerChangeClass);
+
+ shardManager.tell(secondServerChange, secondRequestKit.getRef());
+
+ secondRequestKit.expectMsgClass(duration("5 seconds"), Failure.class);
+ }};
+ }
+
@Test
public void testServerRemovedShardActorNotRunning() throws Exception {
+ LOG.info("testServerRemovedShardActorNotRunning starting");
new JavaTestKit(getSystem()) {{
MockConfiguration mockConfig =
new MockConfiguration(ImmutableMap.<String, List<String>>builder().
TestActorRef<TestShardManager> shardManager = actorFactory.createTestActor(newShardMgrProps(mockConfig));
shardManager.underlyingActor().waitForRecoveryComplete();
-
shardManager.tell(new FindLocalShard("people", false), getRef());
expectMsgClass(duration("5 seconds"), NotInitializedException.class);
// Removed the default shard replica from member-1
ShardIdentifier.Builder builder = new ShardIdentifier.Builder();
- final ShardIdentifier shardId = builder.shardName("default").memberName("member-1").type("config1").build();
+ ShardIdentifier shardId = builder.shardName("default").memberName("member-1").type(shardMrgIDSuffix).build();
shardManager.tell(new ServerRemoved(shardId.toString()), getRef());
shardManager.underlyingActor().verifySnapshotPersisted(Sets.newHashSet("people"));
}};
+
+ LOG.info("testServerRemovedShardActorNotRunning ending");
}
@Test
public void testServerRemovedShardActorRunning() throws Exception {
+ LOG.info("testServerRemovedShardActorRunning starting");
new JavaTestKit(getSystem()) {{
MockConfiguration mockConfig =
new MockConfiguration(ImmutableMap.<String, List<String>>builder().
put("astronauts", Arrays.asList("member-2")).
put("people", Arrays.asList("member-1", "member-2")).build());
- TestActorRef<MessageCollectorActor> shard = actorFactory.createTestActor(MessageCollectorActor.props());
+ String shardId = ShardIdentifier.builder().shardName("default").memberName("member-1").
+ type(shardMrgIDSuffix).build().toString();
+ TestActorRef<MessageCollectorActor> shard = actorFactory.createTestActor(
+ MessageCollectorActor.props(), shardId);
TestActorRef<TestShardManager> shardManager = actorFactory.createTestActor(
newTestShardMgrBuilder(mockConfig).addShardActor("default", shard).props());
- watch(shard);
-
shardManager.underlyingActor().waitForRecoveryComplete();
shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
+ shardManager.tell(new ActorInitialized(), shard);
- shardManager.tell(new FindLocalShard("people", false), getRef());
- expectMsgClass(duration("5 seconds"), NotInitializedException.class);
-
- shardManager.tell(new FindLocalShard("default", false), getRef());
- expectMsgClass(duration("5 seconds"), NotInitializedException.class);
+ waitForShardInitialized(shardManager, "people", this);
+ waitForShardInitialized(shardManager, "default", this);
// Removed the default shard replica from member-1
- ShardIdentifier.Builder builder = new ShardIdentifier.Builder();
- final ShardIdentifier shardId = builder.shardName("default").memberName("member-1").type("config1").build();
- shardManager.tell(new ServerRemoved(shardId.toString()), getRef());
+ shardManager.tell(new ServerRemoved(shardId), getRef());
shardManager.underlyingActor().verifySnapshotPersisted(Sets.newHashSet("people"));
- expectMsgClass(duration("5 seconds"), Terminated.class);
+ MessageCollectorActor.expectFirstMatching(shard, Shutdown.class);
}};
+
+ LOG.info("testServerRemovedShardActorRunning ending");
}
@Test
public void testShardPersistenceWithRestoredData() throws Exception {
+ LOG.info("testShardPersistenceWithRestoredData starting");
new JavaTestKit(getSystem()) {{
MockConfiguration mockConfig =
new MockConfiguration(ImmutableMap.<String, List<String>>builder().
newRestoredShardManager.tell(new FindLocalShard("astronauts", false), getRef());
expectMsgClass(duration("5 seconds"), NotInitializedException.class);
}};
+
+ LOG.info("testShardPersistenceWithRestoredData ending");
}
+ @Test
+ public void testShutDown() throws Exception {
+ LOG.info("testShutDown starting");
+ new JavaTestKit(getSystem()) {{
+ MockConfiguration mockConfig =
+ new MockConfiguration(ImmutableMap.<String, List<String>>builder().
+ put("shard1", Arrays.asList("member-1")).
+ put("shard2", Arrays.asList("member-1")).build());
+
+ String shardId1 = ShardIdentifier.builder().shardName("shard1").memberName("member-1").
+ type(shardMrgIDSuffix).build().toString();
+ TestActorRef<MessageCollectorActor> shard1 = actorFactory.createTestActor(
+ MessageCollectorActor.props(), shardId1);
+
+ String shardId2 = ShardIdentifier.builder().shardName("shard2").memberName("member-1").
+ type(shardMrgIDSuffix).build().toString();
+ TestActorRef<MessageCollectorActor> shard2 = actorFactory.createTestActor(
+ MessageCollectorActor.props(), shardId2);
+
+ TestActorRef<TestShardManager> shardManager = actorFactory.createTestActor(newTestShardMgrBuilder(
+ mockConfig).addShardActor("shard1", shard1).addShardActor("shard2", shard2).props());
+
+ shardManager.tell(new UpdateSchemaContext(TestModel.createTestContext()), getRef());
+ shardManager.tell(new ActorInitialized(), shard1);
+ shardManager.tell(new ActorInitialized(), shard2);
+
+ FiniteDuration duration = FiniteDuration.create(5, TimeUnit.SECONDS);
+ Future<Boolean> stopFuture = Patterns.gracefulStop(shardManager, duration, new Shutdown());
+
+ MessageCollectorActor.expectFirstMatching(shard1, Shutdown.class);
+ MessageCollectorActor.expectFirstMatching(shard2, Shutdown.class);
+
+ try {
+ Await.ready(stopFuture, FiniteDuration.create(500, TimeUnit.MILLISECONDS));
+ fail("ShardManager actor stopped without waiting for the Shards to be stopped");
+ } catch(TimeoutException e) {
+ // expected
+ }
+
+ actorFactory.killActor(shard1, this);
+ actorFactory.killActor(shard2, this);
+
+ Boolean stopped = Await.result(stopFuture, duration);
+ assertEquals("Stopped", Boolean.TRUE, stopped);
+ }};
+
+ LOG.info("testShutDown ending");
+ }
private static class TestShardManager extends ShardManager {
private final CountDownLatch recoveryComplete = new CountDownLatch(1);
public void saveSnapshot(Object obj) {
snapshot = (ShardManagerSnapshot) obj;
snapshotPersist.countDown();
+ super.saveSnapshot(obj);
}
void verifySnapshotPersisted(Set<String> shardList) {
private static class MockRespondActor extends MessageCollectorActor {
static final String CLEAR_RESPONSE = "clear-response";
+ static final org.slf4j.Logger LOG = LoggerFactory.getLogger(MockRespondActor.class);
private volatile Object responseMsg;
@Override
public void onReceive(Object message) throws Exception {
+ if(!"get-all-messages".equals(message)) {
+ LOG.debug("Received message : {}", message);
+ }
super.onReceive(message);
- if (message instanceof AddServer) {
- if (responseMsg != null) {
- getSender().tell(responseMsg, getSelf());
- }
- } if(message.equals(CLEAR_RESPONSE)) {
+ if (message instanceof AddServer && responseMsg != null) {
+ getSender().tell(responseMsg, getSelf());
+ } else if(message instanceof RemoveServer && responseMsg != null){
+ getSender().tell(responseMsg, getSelf());
+ } else if(message.equals(CLEAR_RESPONSE)) {
responseMsg = null;
}
}
Code Review / controller.git / blobdiff