Enable checkstyle

[controller.git] / opendaylight / md-sal / sal-distributed-datastore / src / test / java / org / opendaylight / controller / cluster / datastore / messages / CommitTransactionTest.java

diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/CommitTransactionTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/CommitTransactionTest.java
index 0f46c585db32f1105921b0ad1c375f5f4771af5d..2ab6ca7b3a204c41900f72510130ab3c4933e423 100644 (file)
--- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/CommitTransactionTest.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/CommitTransactionTest.java
@@ -8,51 +8,39 @@
 package org.opendaylight.controller.cluster.datastore.messages;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
 import java.io.Serializable;
-import org.apache.commons.lang.SerializationUtils;
+import org.apache.commons.lang3.SerializationUtils;
 import org.junit.Test;
+import org.opendaylight.controller.cluster.datastore.AbstractTest;
 import org.opendaylight.controller.cluster.datastore.DataStoreVersions;
-import org.opendaylight.controller.protobuff.messages.cohort3pc.ThreePhaseCommitCohortMessages;
 
 /**
  * Unit tests for CommitTransaction.
  *
  * @author Thomas Pantelis
  */
-public class CommitTransactionTest {
+@Deprecated(since = "9.0.0", forRemoval = true)
+public class CommitTransactionTest extends AbstractTest {
 
     @Test
     public void testSerialization() {
-        CommitTransaction expected = new CommitTransaction("txId", DataStoreVersions.CURRENT_VERSION);
+        CommitTransaction expected = new CommitTransaction(nextTransactionId(), DataStoreVersions.CURRENT_VERSION);
 
         Object serialized = expected.toSerializable();
         assertEquals("Serialized type", CommitTransaction.class, serialized.getClass());
 
         CommitTransaction actual = CommitTransaction.fromSerializable(
                 SerializationUtils.clone((Serializable) serialized));
-        assertEquals("getTransactionID", expected.getTransactionID(), actual.getTransactionID());
+        assertEquals("getTransactionID", expected.getTransactionId(), actual.getTransactionId());
         assertEquals("getVersion", DataStoreVersions.CURRENT_VERSION, actual.getVersion());
     }
 
-    @Test
-    public void testSerializationWithPreBoronVersion() {
-        CommitTransaction expected = new CommitTransaction("txId", DataStoreVersions.LITHIUM_VERSION);
-
-        Object serialized = expected.toSerializable();
-        assertEquals("Serialized type", ThreePhaseCommitCohortMessages.CommitTransaction.class, serialized.getClass());
-
-        CommitTransaction actual = CommitTransaction.fromSerializable(
-                SerializationUtils.clone((Serializable) serialized));
-        assertEquals("getTransactionID", expected.getTransactionID(), actual.getTransactionID());
-        assertEquals("getVersion", DataStoreVersions.LITHIUM_VERSION, actual.getVersion());
-    }
-
     @Test
     public void testIsSerializedType() {
-        assertEquals("isSerializedType", true, CommitTransaction.isSerializedType(
-                ThreePhaseCommitCohortMessages.CommitTransaction.newBuilder().setTransactionId("").build()));
-
-        assertEquals("isSerializedType", true, CommitTransaction.isSerializedType(new CommitTransaction()));
-        assertEquals("isSerializedType", false, CommitTransaction.isSerializedType(new Object()));
+        assertTrue("isSerializedType", CommitTransaction.isSerializedType(new CommitTransaction()));
+        assertFalse("isSerializedType", CommitTransaction.isSerializedType(new Object()));
     }
 }