Make Netty-3 dependency optional

[controller.git] / opendaylight / md-sal / sal-distributed-datastore / src / test / java / org / opendaylight / controller / cluster / datastore / messages / CreateTransactionReplyTest.java

diff --git a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/CreateTransactionReplyTest.java b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/CreateTransactionReplyTest.java
index 19c7f012a4f5330281031941f9e5c2c6f1d6018a..5acacfe8b182587fca05202589f3f5a289b3843b 100644 (file)
--- a/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/CreateTransactionReplyTest.java
+++ b/opendaylight/md-sal/sal-distributed-datastore/src/test/java/org/opendaylight/controller/cluster/datastore/messages/CreateTransactionReplyTest.java
@@ -8,22 +8,26 @@
 package org.opendaylight.controller.cluster.datastore.messages;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
 import java.io.Serializable;
-import org.apache.commons.lang.SerializationUtils;
+import org.apache.commons.lang3.SerializationUtils;
 import org.junit.Test;
+import org.opendaylight.controller.cluster.datastore.AbstractTest;
 import org.opendaylight.controller.cluster.datastore.DataStoreVersions;
-import org.opendaylight.controller.protobuff.messages.transaction.ShardTransactionMessages;
 
 /**
  * Unit tests for CreateTransactionReply.
  *
  * @author Thomas Pantelis
  */
-public class CreateTransactionReplyTest {
-
+@Deprecated(since = "9.0.0", forRemoval = true)
+public class CreateTransactionReplyTest extends AbstractTest {
     @Test
     public void testSerialization() {
-        CreateTransactionReply expected = new CreateTransactionReply("txPath", "txId", DataStoreVersions.CURRENT_VERSION);
+        CreateTransactionReply expected = new CreateTransactionReply("txPath", nextTransactionId(),
+                DataStoreVersions.CURRENT_VERSION);
 
         Object serialized = expected.toSerializable();
         assertEquals("Serialized type", CreateTransactionReply.class, serialized.getClass());
@@ -35,27 +39,9 @@ public class CreateTransactionReplyTest {
         assertEquals("getVersion", DataStoreVersions.CURRENT_VERSION, actual.getVersion());
     }
 
-    @Test
-    public void testSerializationWithPreBoronVersion() {
-        CreateTransactionReply expected = new CreateTransactionReply("txPath", "txId", DataStoreVersions.LITHIUM_VERSION);
-
-        Object serialized = expected.toSerializable();
-        assertEquals("Serialized type", ShardTransactionMessages.CreateTransactionReply.class, serialized.getClass());
-
-        CreateTransactionReply actual = CreateTransactionReply.fromSerializable(
-                SerializationUtils.clone((Serializable) serialized));
-        assertEquals("getTransactionId", expected.getTransactionId(), actual.getTransactionId());
-        assertEquals("getTransactionPath", expected.getTransactionPath(), actual.getTransactionPath());
-        assertEquals("getVersion", DataStoreVersions.LITHIUM_VERSION, actual.getVersion());
-    }
-
     @Test
     public void testIsSerializedType() {
-        assertEquals("isSerializedType", true, CreateTransactionReply.isSerializedType(
-                ShardTransactionMessages.CreateTransactionReply.newBuilder().setTransactionActorPath("")
-                    .setTransactionId("").setMessageVersion(4).build()));
-
-        assertEquals("isSerializedType", true, CreateTransactionReply.isSerializedType(new CreateTransactionReply()));
-        assertEquals("isSerializedType", false, CreateTransactionReply.isSerializedType(new Object()));
+        assertTrue("isSerializedType", CreateTransactionReply.isSerializedType(new CreateTransactionReply()));
+        assertFalse("isSerializedType", CreateTransactionReply.isSerializedType(new Object()));
     }
 }