Bug 4035: Fixed some sonar / findbugs issues in DOM MD-SAL.

[controller.git] / opendaylight / md-sal / sal-dom-api / src / main / java / org / opendaylight / controller / sal / core / api / AbstractConsumer.java

diff --git a/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/AbstractConsumer.java b/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/AbstractConsumer.java
index c14d5a679cf8c2f8bcb2172f520273fac160ea50..12c26a98564ee35a8594e01edeb58bc4cdcf351a 100644 (file)
--- a/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/AbstractConsumer.java
+++ b/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/AbstractConsumer.java
@@ -9,7 +9,6 @@ package org.opendaylight.controller.sal.core.api;
 
 import java.util.Collection;
 import java.util.Collections;
-
 import org.osgi.framework.BundleActivator;
 import org.osgi.framework.BundleContext;
 import org.osgi.framework.ServiceReference;
@@ -18,15 +17,12 @@ import org.osgi.util.tracker.ServiceTrackerCustomizer;
 
 public abstract class AbstractConsumer implements Consumer, BundleActivator,ServiceTrackerCustomizer<Broker, Broker> {
 
-
-
-
     private BundleContext context;
     private ServiceTracker<Broker, Broker> tracker;
     private Broker broker;
 
     @Override
-    public final void start(BundleContext context) throws Exception {
+    public final void start(final BundleContext context) throws Exception {
         this.context = context;
         this.startImpl(context);
         tracker = new ServiceTracker<>(context, Broker.class, this);
@@ -36,16 +32,16 @@ public abstract class AbstractConsumer implements Consumer, BundleActivator,Serv
 
 
     @Override
-    public final void stop(BundleContext context) throws Exception {
+    public final void stop(final BundleContext context) throws Exception {
         stopImpl(context);
         broker = null;
         tracker.close();
     }
 
-    protected void startImpl(BundleContext context) {
+    protected void startImpl(final BundleContext context) {
         // NOOP
     }
-    protected void stopImpl(BundleContext context) {
+    protected void stopImpl(final BundleContext context) {
         // NOOP
     }
 
@@ -56,7 +52,7 @@ public abstract class AbstractConsumer implements Consumer, BundleActivator,Serv
 
 
     @Override
-    public Broker addingService(ServiceReference<Broker> reference) {
+    public Broker addingService(final ServiceReference<Broker> reference) {
         if(broker == null) {
             broker = context.getService(reference);
             broker.registerConsumer(this, context);
@@ -67,12 +63,12 @@ public abstract class AbstractConsumer implements Consumer, BundleActivator,Serv
     }
 
     @Override
-    public void modifiedService(ServiceReference<Broker> reference, Broker service) {
+    public void modifiedService(final ServiceReference<Broker> reference, final Broker service) {
         // NOOP
     }
 
     @Override
-    public void removedService(ServiceReference<Broker> reference, Broker service) {
+    public void removedService(final ServiceReference<Broker> reference, final Broker service) {
         stopImpl(context);
     }
 }