Bug 4035: Fixed some sonar / findbugs issues in DOM MD-SAL.

[controller.git] / opendaylight / md-sal / sal-dom-api / src / main / java / org / opendaylight / controller / sal / core / api / AbstractProvider.java

diff --git a/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/AbstractProvider.java b/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/AbstractProvider.java
index 22b0bf25cf9b65958131ace905b0176d351f4147..e300279d7b431ef02bbbed600852631c349df234 100644 (file)
--- a/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/AbstractProvider.java
+++ b/opendaylight/md-sal/sal-dom-api/src/main/java/org/opendaylight/controller/sal/core/api/AbstractProvider.java
@@ -9,7 +9,6 @@ package org.opendaylight.controller.sal.core.api;
 
 import java.util.Collection;
 import java.util.Collections;
-
 import org.osgi.framework.BundleActivator;
 import org.osgi.framework.BundleContext;
 import org.osgi.framework.ServiceReference;
@@ -21,28 +20,29 @@ public abstract class AbstractProvider implements BundleActivator, Provider,Serv
     private Broker broker;
     private BundleContext context;
     private ServiceTracker<Broker, Broker> tracker;
+
     @Override
     public Collection<ProviderFunctionality> getProviderFunctionality() {
         return Collections.emptySet();
     }
 
     @Override
-    public final void start(BundleContext context) throws Exception {
+    public final void start(final BundleContext context) throws Exception {
         this.context = context;
         this.startImpl(context);
         tracker = new ServiceTracker<>(context, Broker.class, this);
         tracker.open();
     }
 
-    protected void startImpl(BundleContext context) {
+    protected void startImpl(final BundleContext context) {
         // NOOP
     }
-    protected void stopImpl(BundleContext context) {
+    protected void stopImpl(final BundleContext context) {
         // NOOP
     }
 
     @Override
-    public final void stop(BundleContext context) throws Exception {
+    public final void stop(final BundleContext context) throws Exception {
         broker = null;
         tracker.close();
         tracker = null;
@@ -50,7 +50,7 @@ public abstract class AbstractProvider implements BundleActivator, Provider,Serv
     }
 
     @Override
-    public Broker addingService(ServiceReference<Broker> reference) {
+    public Broker addingService(final ServiceReference<Broker> reference) {
         if(broker == null) {
             broker = context.getService(reference);
             broker.registerProvider(this, context);
@@ -61,12 +61,12 @@ public abstract class AbstractProvider implements BundleActivator, Provider,Serv
     }
 
     @Override
-    public void modifiedService(ServiceReference<Broker> reference, Broker service) {
+    public void modifiedService(final ServiceReference<Broker> reference, final Broker service) {
         // NOOP
     }
 
     @Override
-    public void removedService(ServiceReference<Broker> reference, Broker service) {
+    public void removedService(final ServiceReference<Broker> reference, final Broker service) {
         stopImpl(context);
     }