*/
package org.opendaylight.controller.md.sal.dom.broker.impl;
-import com.google.common.base.Preconditions;
+import static java.util.Objects.requireNonNull;
+
import com.google.common.util.concurrent.ListenableFuture;
import com.google.common.util.concurrent.SettableFuture;
import com.lmax.disruptor.EventFactory;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
import java.util.Collection;
import org.opendaylight.controller.md.sal.dom.api.DOMNotification;
import org.opendaylight.controller.md.sal.dom.api.DOMNotificationListener;
* A single notification event in the disruptor ringbuffer. These objects are reused,
* so they do have mutable state.
*/
+@Deprecated
final class DOMNotificationRouterEvent {
private static final Logger LOG = LoggerFactory.getLogger(DOMNotificationRouterEvent.class);
public static final EventFactory<DOMNotificationRouterEvent> FACTORY = DOMNotificationRouterEvent::new;
// Hidden on purpose, initialized in initialize()
}
- ListenableFuture<Void> initialize(final DOMNotification notification, final Collection<ListenerRegistration<? extends DOMNotificationListener>> subscribers) {
- this.notification = Preconditions.checkNotNull(notification);
- this.subscribers = Preconditions.checkNotNull(subscribers);
+ @SuppressWarnings("checkstyle:hiddenField")
+ ListenableFuture<Void> initialize(final DOMNotification notification,
+ final Collection<ListenerRegistration<? extends DOMNotificationListener>>
+ subscribers) {
+ this.notification = requireNonNull(notification);
+ this.subscribers = requireNonNull(subscribers);
this.future = SettableFuture.create();
return this.future;
}
LOG.trace("Start delivery of notification {}", notification);
for (ListenerRegistration<? extends DOMNotificationListener> r : subscribers) {
final DOMNotificationListener listener = r.getInstance();
- if (listener != null) {
- try {
- LOG.trace("Notifying listener {}", listener);
- listener.onNotification(notification);
- LOG.trace("Listener notification completed");
- } catch (Exception e) {
- LOG.error("Delivery of notification {} caused an error in listener {}", notification, listener, e);
- }
- }
+ LOG.trace("Notifying listener {}", listener);
+ listener.onNotification(notification);
+ LOG.trace("Listener notification completed");
}
LOG.trace("Delivery completed");
}
+ @SuppressFBWarnings(value = "NP_NONNULL_PARAM_VIOLATION", justification = "Void is the only allowed value")
void setFuture() {
future.set(null);
notification = null;
subscribers = null;
future = null;
}
-}
\ No newline at end of file
+}