import java.util.concurrent.atomic.AtomicLong;
import java.util.concurrent.atomic.AtomicReference;
import org.opendaylight.controller.md.sal.binding.api.DataBroker;
-import org.opendaylight.controller.md.sal.binding.api.DataChangeListener;
import org.opendaylight.controller.md.sal.binding.api.DataTreeIdentifier;
import org.opendaylight.controller.md.sal.binding.api.WriteTransaction;
import org.opendaylight.controller.md.sal.common.api.clustering.CandidateAlreadyRegisteredException;
* @author Thomas Pantelis
*/
public class CarProvider implements CarService {
- private static final Logger log = LoggerFactory.getLogger(PurchaseCarProvider.class);
+ private static final Logger LOG_PURCHASE_CAR = LoggerFactory.getLogger(PurchaseCarProvider.class);
- private static final Logger LOG = LoggerFactory.getLogger(CarProvider.class);
+ private static final Logger LOG_CAR_PROVIDER = LoggerFactory.getLogger(CarProvider.class);
private static final String ENTITY_TYPE = "cars";
- private static final InstanceIdentifier CARS_IID = InstanceIdentifier.builder(Cars.class).build();
+ private static final InstanceIdentifier<Cars> CARS_IID = InstanceIdentifier.builder(Cars.class).build();
private static final DataTreeIdentifier<Cars> CARS_DTID = new DataTreeIdentifier<>(
LogicalDatastoreType.CONFIGURATION, CARS_IID);
private final CarEntityOwnershipListener ownershipListener = new CarEntityOwnershipListener();
private final AtomicBoolean registeredListener = new AtomicBoolean();
- private final Collection<ListenerRegistration<DataChangeListener>> carsDclRegistrations =
+ private final Collection<ListenerRegistration<?>> carsDclRegistrations =
Sets.newConcurrentHashSet();
private final Collection<ListenerRegistration<CarDataTreeChangeListener>> carsDtclRegistrations =
Sets.newConcurrentHashSet();
private final AtomicReference<DOMDataTreeCommitCohortRegistration<CarEntryDataTreeCommitCohort>> commitCohortReg =
new AtomicReference<>();
- public CarProvider(DataBroker dataProvider, EntityOwnershipService ownershipService,
- DOMDataBroker domDataBroker) {
+ public CarProvider(final DataBroker dataProvider, final EntityOwnershipService ownershipService,
+ final DOMDataBroker domDataBroker) {
this.dataProvider = dataProvider;
this.ownershipService = ownershipService;
this.domDataBroker = domDataBroker;
}
@Override
- public Future<RpcResult<Void>> stressTest(StressTestInput input) {
+ public Future<RpcResult<Void>> stressTest(final StressTestInput input) {
final int inputRate;
final long inputCount;
// If rate is not provided, or given as zero, then just return.
if (input.getRate() == null || input.getRate() == 0) {
- log.info("Exiting stress test as no rate is given.");
+ LOG_PURCHASE_CAR.info("Exiting stress test as no rate is given.");
return Futures.immediateFuture(RpcResultBuilder.<Void>failed()
.withError(ErrorType.PROTOCOL, "invalid rate")
.build());
- } else {
- inputRate = input.getRate();
}
+ inputRate = input.getRate();
if (input.getCount() != null) {
inputCount = input.getCount();
} else {
inputCount = 0;
}
- log.info("Stress test starting : rate: {} count: {}", inputRate, inputCount);
+ LOG_PURCHASE_CAR.info("Stress test starting : rate: {} count: {}", inputRate, inputCount);
stopThread();
// clear counters
try {
tx.submit().checkedGet(5, TimeUnit.SECONDS);
} catch (TransactionCommitFailedException | TimeoutException e) {
- log.error("Put Cars failed",e);
+ LOG_PURCHASE_CAR.error("Put Cars failed",e);
return Futures.immediateFuture(RpcResultBuilder.<Void>success().build());
}
public void onFailure(final Throwable t) {
// Transaction failed
failureCounter.getAndIncrement();
- LOG.error("Put Cars failed", t);
+ LOG_CAR_PROVIDER.error("Put Cars failed", t);
}
});
try {
}
if(count.get() % 1000 == 0) {
- log.info("Cars created {}, time: {}",count.get(),sw.elapsed(TimeUnit.SECONDS));
+ LOG_PURCHASE_CAR.info("Cars created {}, time: {}",count.get(),sw.elapsed(TimeUnit.SECONDS));
}
// Check if a count is specified in input and we have created that many cars.
}
}
- log.info("Stress test thread stopping after creating {} cars.", count.get());
+ LOG_PURCHASE_CAR.info("Stress test thread stopping after creating {} cars.", count.get());
});
testThread.start();
.setFailureCount(failureCounter.longValue());
StopStressTestOutput result = stopStressTestOutput.build();
- log.info("Executed Stop Stress test; No. of cars created {}; " +
+ LOG_PURCHASE_CAR.info("Executed Stop Stress test; No. of cars created {}; " +
"No. of cars failed {}; ", succcessCounter, failureCounter);
// clear counters
succcessCounter.set(0);
@Override
- public Future<RpcResult<Void>> registerOwnership(RegisterOwnershipInput input) {
+ public Future<RpcResult<Void>> registerOwnership(final RegisterOwnershipInput input) {
if(registeredListener.compareAndSet(false, true)) {
ownershipService.registerListener(ENTITY_TYPE, ownershipListener);
}
}
@Override
- public Future<RpcResult<Void>> unregisterOwnership(UnregisterOwnershipInput input) {
+ public Future<RpcResult<Void>> unregisterOwnership(final UnregisterOwnershipInput input) {
return RpcResultBuilder.<Void>success().buildFuture();
}
private static class CarEntityOwnershipListener implements EntityOwnershipListener {
@Override
- public void ownershipChanged(EntityOwnershipChange ownershipChange) {
- LOG.info("ownershipChanged: {}", ownershipChange);
+ public void ownershipChanged(final EntityOwnershipChange ownershipChange) {
+ LOG_CAR_PROVIDER.info("ownershipChanged: {}", ownershipChange);
}
}
@Override
public Future<RpcResult<java.lang.Void>> registerLoggingDcl() {
- LOG.info("Registering a new CarDataChangeListener");
+ LOG_CAR_PROVIDER.info("Registering a new CarDataChangeListener");
final ListenerRegistration carsDclRegistration = dataProvider.registerDataChangeListener(
LogicalDatastoreType.CONFIGURATION, CARS_IID, new CarDataChangeListener(),
AsyncDataBroker.DataChangeScope.SUBTREE);
@Override
public Future<RpcResult<java.lang.Void>> registerLoggingDtcl() {
- LOG.info("Registering a new CarDataTreeChangeListener");
+ LOG_CAR_PROVIDER.info("Registering a new CarDataTreeChangeListener");
final ListenerRegistration<CarDataTreeChangeListener> carsDtclRegistration =
dataProvider.registerDataTreeChangeListener(CARS_DTID, new CarDataTreeChangeListener());
@Override
public Future<RpcResult<java.lang.Void>> unregisterLoggingDcls() {
- LOG.info("Unregistering the CarDataChangeListener(s)");
+ LOG_CAR_PROVIDER.info("Unregistering the CarDataChangeListener(s)");
synchronized (carsDclRegistrations) {
int numListeners = 0;
- for (ListenerRegistration<DataChangeListener> carsDclRegistration : carsDclRegistrations) {
+ for (ListenerRegistration<?> carsDclRegistration : carsDclRegistrations) {
carsDclRegistration.close();
numListeners++;
}
carsDclRegistrations.clear();
- LOG.info("Unregistered {} CarDataChangeListener(s)", numListeners);
+ LOG_CAR_PROVIDER.info("Unregistered {} CarDataChangeListener(s)", numListeners);
}
return RpcResultBuilder.<Void>success().buildFuture();
}
@Override
public Future<RpcResult<java.lang.Void>> unregisterLoggingDtcls() {
- LOG.info("Unregistering the CarDataTreeChangeListener(s)");
+ LOG_CAR_PROVIDER.info("Unregistering the CarDataTreeChangeListener(s)");
synchronized (carsDtclRegistrations) {
int numListeners = 0;
for (ListenerRegistration<CarDataTreeChangeListener> carsDtclRegistration : carsDtclRegistrations) {
numListeners++;
}
carsDtclRegistrations.clear();
- LOG.info("Unregistered {} CaraDataTreeChangeListener(s)", numListeners);
+ LOG_CAR_PROVIDER.info("Unregistered {} CaraDataTreeChangeListener(s)", numListeners);
}
return RpcResultBuilder.<Void>success().buildFuture();
}
if (reg != null) {
try {
reg.close();
- LOG.info("Unregistered commit cohort");
+ LOG_CAR_PROVIDER.info("Unregistered commit cohort");
} catch (Exception e) {
return RpcResultBuilder.<Void>failed().withError(ErrorType.APPLICATION,
"Error closing commit cohort registration", e).buildFuture();
org.opendaylight.mdsal.common.api.LogicalDatastoreType.CONFIGURATION,
carEntryPath), new CarEntryDataTreeCommitCohort()));
- LOG.info("Registered commit cohort");
+ LOG_CAR_PROVIDER.info("Registered commit cohort");
return RpcResultBuilder.<Void>success().buildFuture();
}
Code Review / controller.git / blobdiff